feat: Multiplatform OFREP provider #6
Conversation
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
bencehornak
force-pushed
the
ofrep-provider
branch
from
332e715 to
b1db377
Compare
bencehornak
changed the title
|
@bencehornak do you know why the CI is failing? |
|
@thomaspoignant the CI I have fixed in #15, I'm waiting for approvals. If you give it, I can merge it and rebase this one :) |
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
|
@thomaspoignant I have fixed the CI. From my side the only thing missing is some manual testing. I have no experience with any OFREP backends, can you help with performing some manual tests? |
If you want to have a OFREP backend running locally you can use GO Feature Flag easily. You can launch those 2 commands: Download an example of a basic configuration file. curl https://raw.githubusercontent.com/thomaspoignant/go-feature-flag/main/cmd/relayproxy/testdata/dockerhub-example/goff-proxy.yaml -o goff-proxy.yamlLaunch GO Feature Flag in a container docker run \
-p 1031:1031 \
-v $(pwd)/goff-proxy.yaml:/goff/goff-proxy.yaml \
gofeatureflag/go-feature-flag:latestIt will start GO Feature Flag on port 1031, you can now set your OFREP endpoint to http://localhost:1031 and you should be good to go. |
bencehornak
force-pushed
the
ofrep-provider
branch
from
fa6a007 to
82281bf
Compare
Signed-off-by: Bence Hornák <[email protected]>
Signed-off-by: Bence Hornák <[email protected]>
bencehornak
force-pushed
the
ofrep-provider
branch
from
82281bf to
59cb175
Compare
Signed-off-by: Bence Hornák <[email protected]>
bencehornak
force-pushed
the
ofrep-provider
branch
from
d6349f9 to
a992cac
Compare
|
@thomaspoignant thanks for the hint, I've added some integration tests with the GOFF container, and fixed some bugs thanks to that. The PR is ready from my side. |
Signed-off-by: Bence Hornák <[email protected]>
3 participants
This PR
Implements an OFREP provider for Kotlin Multiplatform. The implementation was initially based on @thomaspoignant's OFREP implementation, then I made a bunch of changes to make it compatible with multiple platforms:
Now the project is compatible with multiple platforms, and can be easily extended to other ones by changing the targets in the
build.gradle.kts:Notes
I have based these changes on the unmerged open-feature/kotlin-sdk#148, which brings in multiplatform support for the SDK.
Prerequisites
How to test
For manual testing: set up a local OFREP provider and try out various evaluations.