Skip to content

Commit 5a2bc63

Browse files
refactor: Rename shutdown event to notready event (#97)
Signed-off-by: Fabrizio Demaria <[email protected]>
1 parent 53a0908 commit 5a2bc63

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

android/src/main/java/dev/openfeature/sdk/events/EventHandler.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class EventHandler(dispatcher: CoroutineDispatcher) :
3131
ProviderStatus {
3232
private val sharedFlow: MutableSharedFlow<OpenFeatureEvents> = MutableSharedFlow()
3333
private val currentStatus: MutableStateFlow<OpenFeatureEvents> =
34-
MutableStateFlow(OpenFeatureEvents.ProviderShutDown)
34+
MutableStateFlow(OpenFeatureEvents.ProviderNotReady)
3535
private val job = Job()
3636
private val coroutineScope = CoroutineScope(job + dispatcher)
3737

@@ -40,7 +40,7 @@ class EventHandler(dispatcher: CoroutineDispatcher) :
4040
sharedFlow.collect {
4141
currentStatus.value = it
4242
when (it) {
43-
is OpenFeatureEvents.ProviderShutDown -> {
43+
is OpenFeatureEvents.ProviderNotReady -> {
4444
job.cancelChildren()
4545
}
4646

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package dev.openfeature.sdk.events
22

33
sealed interface OpenFeatureEvents {
4+
object ProviderNotReady : OpenFeatureEvents
45
object ProviderReady : OpenFeatureEvents
56
data class ProviderError(val error: Throwable) : OpenFeatureEvents
67
object ProviderStale : OpenFeatureEvents
7-
object ProviderShutDown : OpenFeatureEvents
88
}

android/src/test/java/dev/openfeature/sdk/EventsHandlerTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ class EventsHandlerTest {
181181
val eventHandler = EventHandler(dispatcher)
182182
val provider = TestFeatureProvider(dispatcher, eventHandler)
183183

184-
Assert.assertEquals(OpenFeatureEvents.ProviderShutDown, provider.getProviderStatus())
184+
Assert.assertEquals(OpenFeatureEvents.ProviderNotReady, provider.getProviderStatus())
185185

186186
provider.emitReady()
187187

@@ -201,6 +201,6 @@ class EventsHandlerTest {
201201

202202
provider.shutdown()
203203

204-
Assert.assertEquals(OpenFeatureEvents.ProviderShutDown, provider.getProviderStatus())
204+
Assert.assertEquals(OpenFeatureEvents.ProviderNotReady, provider.getProviderStatus())
205205
}
206206
}

android/src/test/java/dev/openfeature/sdk/TestFeatureProvider.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class TestFeatureProvider(
1818
}
1919

2020
override fun shutdown() {
21-
eventHandler.publish(OpenFeatureEvents.ProviderShutDown)
21+
eventHandler.publish(OpenFeatureEvents.ProviderNotReady)
2222
}
2323

2424
override fun onContextSet(oldContext: EvaluationContext?, newContext: EvaluationContext) {

0 commit comments

Comments
 (0)