Skip to content

Commit af07e0f

Browse files
nicklaslbeeme1mr
andauthored
test: adjust some assert logic to reduce flakiness (#127)
Signed-off-by: Nicklas Lundin <[email protected]> Co-authored-by: Michael Beemer <[email protected]>
1 parent 465f7ec commit af07e0f

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

android/src/test/java/dev/openfeature/sdk/DeveloperExperienceTests.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,9 @@ class DeveloperExperienceTests {
259259
assertEquals(OpenFeatureStatus.NotReady, OpenFeatureAPI.getStatus())
260260
}
261261
testScheduler.advanceTimeBy(1)
262-
assertEquals(OpenFeatureStatus.NotReady, OpenFeatureAPI.getStatus())
262+
waitAssert {
263+
assertEquals(OpenFeatureStatus.NotReady, OpenFeatureAPI.getStatus())
264+
}
263265
testScheduler.advanceTimeBy(healDelayMillis)
264266
waitAssert {
265267
assertEquals(OpenFeatureStatus.Ready, OpenFeatureAPI.getStatus())

android/src/test/java/dev/openfeature/sdk/StatusTests.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ class StatusTests {
8383
}
8484
job.cancelAndJoin()
8585

86-
assertEquals(7, statuses.size)
8786
assertEquals(
8887
listOf(
8988
OpenFeatureStatus.NotReady,
@@ -100,13 +99,15 @@ class StatusTests {
10099
}
101100

102101
@OptIn(ExperimentalCoroutinesApi::class)
103-
suspend fun TestScope.waitAssert(function: () -> Unit) {
104-
while (true) {
102+
suspend fun TestScope.waitAssert(timeoutMs: Long = 5000, function: () -> Unit) {
103+
var timeWaited = 0L
104+
while (timeWaited < timeoutMs) {
105105
try {
106106
function()
107107
return
108108
} catch (e: Throwable) {
109-
delay(100)
109+
delay(10)
110+
timeWaited += 10
110111
advanceUntilIdle()
111112
}
112113
}

0 commit comments

Comments
 (0)