Skip to content

Commit 0735f38

Browse files
committed
refactor: remove code duplication, move tokio to dev dependencies
Signed-off-by: Rahul Baradol <[email protected]>
1 parent c7ca05f commit 0735f38

File tree

3 files changed

+53
-345
lines changed

3 files changed

+53
-345
lines changed

crates/ofrep/Cargo.toml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,18 @@ edition = "2024"
66
[dev-dependencies]
77
wiremock = "0.6.3"
88
test-log = { version = "0.2", features = ["trace"] }
9+
tokio = { version = "1.45", features = ["full"] }
910

1011
[dependencies]
1112
async-trait = "0.1.88"
1213
open-feature = "0.2.5"
13-
reqwest = { version = "0.12", default-features = false, features = ["json", "stream", "rustls-tls"] }
14+
reqwest = { version = "0.12", default-features = false, features = [
15+
"json",
16+
"stream",
17+
"rustls-tls",
18+
] }
1419
serde = "1.0.219"
1520
serde_json = "1.0.140"
1621
tracing = "0.1.41"
1722
thiserror = "2.0"
1823
anyhow = "1.0.98"
19-
tokio = { version = "1.45", features = ["full"] }

crates/ofrep/src/lib.rs

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -58,49 +58,38 @@ impl FeatureProvider for OfrepProvider {
5858
flag_key: &str,
5959
context: &EvaluationContext,
6060
) -> Result<ResolutionDetails<bool>, EvaluationError> {
61-
let result = self.provider.resolve_bool_value(flag_key, context).await?;
62-
Ok(result)
61+
self.provider.resolve_bool_value(flag_key, context).await
6362
}
6463

6564
async fn resolve_int_value(
6665
&self,
6766
flag_key: &str,
6867
context: &EvaluationContext,
6968
) -> Result<ResolutionDetails<i64>, EvaluationError> {
70-
let result = self.provider.resolve_int_value(flag_key, context).await?;
71-
Ok(result)
69+
self.provider.resolve_int_value(flag_key, context).await
7270
}
7371

7472
async fn resolve_float_value(
7573
&self,
7674
flag_key: &str,
7775
context: &EvaluationContext,
7876
) -> Result<ResolutionDetails<f64>, EvaluationError> {
79-
let result = self.provider.resolve_float_value(flag_key, context).await?;
80-
Ok(result)
77+
self.provider.resolve_float_value(flag_key, context).await
8178
}
8279

8380
async fn resolve_string_value(
8481
&self,
8582
flag_key: &str,
8683
context: &EvaluationContext,
8784
) -> Result<ResolutionDetails<String>, EvaluationError> {
88-
let result = self
89-
.provider
90-
.resolve_string_value(flag_key, context)
91-
.await?;
92-
Ok(result)
85+
self.provider.resolve_string_value(flag_key, context).await
9386
}
9487

9588
async fn resolve_struct_value(
9689
&self,
9790
flag_key: &str,
9891
context: &EvaluationContext,
9992
) -> Result<ResolutionDetails<StructValue>, EvaluationError> {
100-
let result = self
101-
.provider
102-
.resolve_struct_value(flag_key, context)
103-
.await?;
104-
Ok(result)
93+
self.provider.resolve_struct_value(flag_key, context).await
10594
}
10695
}

0 commit comments

Comments
 (0)