fix: base url validation

Signed-off-by: Rahul Baradol <[email protected]>

Author: Rahul-Baradol

crates/ofrep/Cargo.toml

@@ -22,4 +22,5 @@ thiserror = "2.0"
 anyhow = "1.0.98"
 chrono = "0.4"
 once_cell = "1.18"
-tokio = { version = "1.45", features = ["full"] }
+tokio = { version = "1.45", features = ["full"] }
+url = "2.5.4"

crates/ofrep/src/error.rs

@@ -1,6 +1,6 @@
 use thiserror::Error;
 
-#[derive(Error, Debug)]
+#[derive(Error, Debug, PartialEq)]
 pub enum OfrepError {
     #[error("Provider error: {0}")]
     Provider(String),

crates/ofrep/src/lib.rs

@@ -10,6 +10,8 @@ use std::sync::Arc;
 use std::time::Duration;
 use tracing::debug;
 use tracing::instrument;
+use url::Url;
+use std::fmt;
 
 use async_trait::async_trait;
 
@@ -37,10 +39,30 @@ pub struct OfrepProvider {
     provider: Arc<dyn FeatureProvider + Send + Sync>,
 }
 
+impl fmt::Debug for OfrepProvider {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_struct("OfrepProvider")
+         .field("provider", &"<FeatureProvider>")
+         .finish()
+    }
+}
+
 impl OfrepProvider {
     #[instrument(skip(options))]
     pub async fn new(options: OfrepOptions) -> Result<Self, OfrepError> {
         debug!("Initializing OfrepProvider with options: {:?}", options);
+
+        let url = Url::parse(&options.base_url).map_err(|e| {
+            OfrepError::Config(format!("Invalid base url: '{}' ({})", options.base_url, e))
+        })?;
+
+        if !matches!(url.scheme(), "http" | "https") {
+            return Err(OfrepError::Config(format!(
+                "Invalid base url: '{}' (unsupported scheme)",
+                url.scheme()
+            )));
+        }
+
         Ok(Self {
             provider: Arc::new(Resolver::new(&options)),
         })
@@ -93,3 +115,28 @@ impl FeatureProvider for OfrepProvider {
         self.provider.resolve_struct_value(flag_key, context).await
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use test_log::test;
+
+    #[test(tokio::test)]
+    async fn test_ofrep_options_validation() {
+        let provider_with_empty_host = OfrepProvider::new(OfrepOptions {
+            base_url: "http://".to_string(),
+            ..Default::default()
+        }).await;
+
+        let provider_with_invalid_scheme = OfrepProvider::new(OfrepOptions {
+            base_url: "invalid://".to_string(),
+            ..Default::default()
+        }).await;
+
+        assert!(provider_with_empty_host.is_err());
+        assert!(provider_with_invalid_scheme.is_err());
+
+        assert_eq!(provider_with_empty_host.unwrap_err(), OfrepError::Config("Invalid base url: 'http://' (empty host)".to_string()));
+        assert_eq!(provider_with_invalid_scheme.unwrap_err(), OfrepError::Config("Invalid base url: 'invalid' (unsupported scheme)".to_string()));
+    }
+}