Skip to content

Commit 0f5afc2

Browse files
committed
Fixtures are not worth it
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
1 parent 6d0a3d5 commit 0f5afc2

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tests/test_acvp_vectors.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
if helpers.is_sig_enabled_by_name(sig) and sig.startswith("SLH_DSA"):
2020
slh_sig.append(sig)
2121

22+
# NOTE: these are not made into fixture because each is used once or twice, so
23+
# the (probably non-existent) performance gain is not worth the loss of
24+
# debuggability
2225
URLROOT = "https://raw.githubusercontent.com/usnistgov/ACVP-Server/refs/tags/v1.1.0.40/gen-val/json-files/"
2326
ml_kem_encdec = urljoin(URLROOT, "ML-KEM-encapDecap-FIPS203/internalProjection.json")
2427
ml_kem_kg = urljoin(URLROOT, "ML-KEM-keyGen-FIPS203/internalProjection.json")

0 commit comments

Comments
 (0)