[Instrumentation.AspNet] Stable release

[Kielek]

Component

OpenTelemetry.Instrumentation.AspNet

Is your feature request related to a problem?

Issue to track the effort to stabilize OpenTelemetry.Instrumentation.AspNet and OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.

What is the expected behavior?

.

Which alternative solutions or features have you considered?

.

Additional context

.

[Kielek]

Metrics status, based on: https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/http/http-metrics.md
Implementation needs to be adjusted. It should be covered by: #2916

This package is supporting only
http.server.request.duration.
Following metrics are not supported. Stable release should be not blocked by this. Introducing them lates should not be treated as a breaking change.

• http.server.active_requests
• http.server.request.body.size
• http.server.response.body.size.

http.server.request.duration status:

• name
• type
• unit
• description
• attributes
  • http.request.method
  • url.scheme
  • error.type - will be handled by [Instrumentation.AspNet] Metrics should support error.type #2921
  • http.response.status_code
  • http.route - added, when available
  • network.protocol.name - not supported, not needed if http is used
  • network.protocol.version - not supported, it is fine
  • server.address - opt-in, hidden by internal property, officially not supported
  • server.port - opt-in, hidden by internal property, officially not supported
  • user_agent.synthetic.type - development state, not supported

[Kielek]

Spans status based on https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/http/http-spans.md#http-server

• span name
• span kind
• span status
• attributes
  • http.request.method
  • url.path, not trying to identify sensitive data
  • url.scheme
  • error.type - full exception name if occured
  • http.request.method_original
  • http.response.status_code
  • http.route
  • network.protocol.name - not added, it http it is not mandatory, I do not found any way to detect anything else that http. MNot supported also by AspNetCore and Http
  • server.port - added, it is not using ForwardHost or any other headers for reverse proxy: https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/http/http-spans.md#setting-serveraddress-and-serverport-attributes
  • url.query - all values are redacted, technically, it is possible to disable it by env-var OTEL_DOTNET_EXPERIMENTAL_ASPNET_DISABLE_URL_QUERY_REDACTION, same behavior for AspNetCore
  • client.address - recommended, not supported, same for AspNetCore
  • network.peer.address - recommended, not supported, same for AspNetCore
  • network.peer.port - recommended, not supported, same for AspNetCore
  • network.protocol.version
  • server.address - added, it is not using ForwardHost or any other headers for reverse proxy: https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/http/http-spans.md#setting-serveraddress-and-serverport-attributes
  • user_agent.original
  • client.port - opt in, not supported
  • http.request.body.size - development state, not supported
  • http.request.header. - opt-in, not directly supported, possible by enrichment
  • http.request.size - development state, not supported
  • http.response.body.size - development state, not supported
  • http.response.header. - opt-in, not directly supported, possible by enrichment
  • http.response.size - development state, not supported
  • network.local.address - opt-in, not supported
  • network.local.port - opt-in, not supported
  • network.transport - opt-in, not supported
  • user_agent.synthetic.type - development state, not supported
• attributes at creation time
  • client.address - recommended, no set also later
  • http.request.header.<key> - opt-in, not directly supported, possible by enrichment, not set also later
  • http.request.method
  • server.address
  • server.port
  • url.path
  • url.query
  • url.scheme
  • user_agent.original