tool_name and tool_description for Agent#as_tool() method

[subhankaladi]

In the Agent Class, the name: strproperty is required — that's fine.
The property handoff_description: str | None = None is optional because it accepts both str and None types — this is also fine.

But But But...

def as_tool(
    self,
    tool_name: str | None,
    tool_description: str | None,
    custom_output_extractor: Callable[[RunResult], Awaitable[str]] | None = None,
) -> Tool:

This is a method of the Agent class. Bothtool_name and tool_description are annotated as str | None.
So why does it raise this error?
TypeError: Agent.as_tool() missing 2 required positional arguments: 'tool_name' and 'tool_description'

My mind is getting disturbed because of this issue.
Please help me fix it.
Thank You
Best Regard
SubhanKaladi

[mar-yam12]

Using tool_name: str | None indicates that the name parameter can be either a string or None.
However, no default value is provided, so this argument is required when the function is called.
This is useful when the value must always be explicitly passed, even if it might be None.

def as_tool(name: str | None):
...

[seratch]

I mentioned passing both is currently recommended for better performance of the tool calls. That being said, one thing I should mention is with Agents SDK TypeScript, actually these are required parameters when calling Agent#asTool(): https://openai.github.io/openai-agents-js/guides/tools/#3-agents-as-tools and it's also reasonable.

I personally think removing the possibility of None for the name and description here (again, note that not setting these affects stability of tool calls) rather than setting default None for the arguments.

@rm-openai This could be a minor breaking change, but what do you think? If you're down to allowing default None + falling back to agent.name & empty description, it's fine for me too. Happy to make the adjustments in future release.

[github-actions]

This issue is stale because it has been open for 7 days with no activity.