From 3d03378b93acc952356c9d51e50e97dbfdbfb5a9 Mon Sep 17 00:00:00 2001
From: amandel <andreas.mandel@gmail.com>
Date: Fri, 28 Feb 2025 14:52:39 +0100
Subject: [PATCH 1/4] Soft-off after 10 seconds not earlier

---
 src/OpenBikeSensorFirmware.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/OpenBikeSensorFirmware.cpp b/src/OpenBikeSensorFirmware.cpp
index 39b26cd..6b11f8a 100644
--- a/src/OpenBikeSensorFirmware.cpp
+++ b/src/OpenBikeSensorFirmware.cpp
@@ -252,7 +252,7 @@ static void powerKeepAliveTimerISR()
     }
   }
 
-  // Soft power-off OBSPro when button is pressed for more than 2 seconds
+  // Soft power-off OBSPro when button is pressed for more than 10 seconds
   if(button.read())
   {
     if(buttonPressedCounter < 255)
@@ -261,7 +261,7 @@ static void powerKeepAliveTimerISR()
   else
     buttonPressedCounter = 0;
 
-  if(shutdownState == 0 && buttonPressedCounter >= 50) {
+  if(shutdownState == 0 && buttonPressedCounter >= 100) {
     shutdownState = 1;
   }
   switch(shutdownState)

From f43061249a8e040c80839fbdebe9d745c64f9653 Mon Sep 17 00:00:00 2001
From: amandel <andreas.mandel@gmail.com>
Date: Fri, 28 Feb 2025 15:06:19 +0100
Subject: [PATCH 2/4] Use the Button class, introduce constant.

---
 src/OpenBikeSensorFirmware.cpp | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/src/OpenBikeSensorFirmware.cpp b/src/OpenBikeSensorFirmware.cpp
index 6b11f8a..4abc4e0 100644
--- a/src/OpenBikeSensorFirmware.cpp
+++ b/src/OpenBikeSensorFirmware.cpp
@@ -103,7 +103,7 @@ CircularBuffer<DataSet*, 10> dataBuffer;
 FileWriter* writer;
 
 const uint8_t displayAddress = 0x3c;
-
+const uint16_t BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS = 10000;
 
 // Enable dev-mode. Allows to
 // - set wifi config
@@ -233,35 +233,26 @@ static uint8_t shutdownState = 0;
 // Power-management keep alive timer
 // This function is called every 100 ms
 static unsigned long timeOfLastPowerKeepAlive = 0;
-static uint8_t buttonPressedCounter = 0;
 static void powerKeepAliveTimerISR()
 {
   // Send "keep alive" trigger to power management module
   // This is done by toggling the pin every 300 ms or more
   if(shutdownState == 0)
   {
-    if(!digitalRead(IP5306_BUTTON) && millis() - timeOfLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)
+    unsigned long timeSinceLastPowerKeepAlive = millis() - timeOfLastPowerKeepAlive;
+    if(!digitalRead(IP5306_BUTTON) && timeSinceLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)
     {
       timeOfLastPowerKeepAlive = millis();
       digitalWrite(IP5306_BUTTON, HIGH);
     }
-    else if(digitalRead(IP5306_BUTTON) && millis() - timeOfLastPowerKeepAlive > 300)
+    else if(digitalRead(IP5306_BUTTON) && timeSinceLastPowerKeepAlive > 300)
     {
       timeOfLastPowerKeepAlive = millis();
       digitalWrite(IP5306_BUTTON, LOW);
     }
   }
 
-  // Soft power-off OBSPro when button is pressed for more than 10 seconds
-  if(button.read())
-  {
-    if(buttonPressedCounter < 255)
-      buttonPressedCounter++;
-  }
-  else
-    buttonPressedCounter = 0;
-
-  if(shutdownState == 0 && buttonPressedCounter >= 100) {
+  if(shutdownState == 0 && button.read() && button.getCurrentStateMillis() >= BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS) {
     shutdownState = 1;
   }
   switch(shutdownState)

From 45fde04a69378bb4e23db9879e6df93e97e14deb Mon Sep 17 00:00:00 2001
From: amandel <andreas.mandel@gmail.com>
Date: Fri, 28 Feb 2025 15:21:27 +0100
Subject: [PATCH 3/4] read button only once

---
 src/OpenBikeSensorFirmware.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/OpenBikeSensorFirmware.cpp b/src/OpenBikeSensorFirmware.cpp
index 4abc4e0..cf715f9 100644
--- a/src/OpenBikeSensorFirmware.cpp
+++ b/src/OpenBikeSensorFirmware.cpp
@@ -240,12 +240,14 @@ static void powerKeepAliveTimerISR()
   if(shutdownState == 0)
   {
     unsigned long timeSinceLastPowerKeepAlive = millis() - timeOfLastPowerKeepAlive;
-    if(!digitalRead(IP5306_BUTTON) && timeSinceLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)
+    bool ip5306ButtonState = digitalRead(IP5306_BUTTON);
+
+    if(!ip5306ButtonState && timeSinceLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)
     {
       timeOfLastPowerKeepAlive = millis();
       digitalWrite(IP5306_BUTTON, HIGH);
     }
-    else if(digitalRead(IP5306_BUTTON) && timeSinceLastPowerKeepAlive > 300)
+    else if(ip5306ButtonState && timeSinceLastPowerKeepAlive > 300)
     {
       timeOfLastPowerKeepAlive = millis();
       digitalWrite(IP5306_BUTTON, LOW);

From 76b3be35c8a9a29c8da83a477ca2ccd8c0236928 Mon Sep 17 00:00:00 2001
From: amandel <andreas.mandel@gmail.com>
Date: Fri, 28 Feb 2025 18:01:42 +0100
Subject: [PATCH 4/4] work in progress

- button / switch off not reliable?
- display of process not in all cases
---
 .github/fake-cc                |  0
 .idea/codeStyles/Project.xml   |  4 ----
 README.md                      |  0
 src/OpenBikeSensorFirmware.cpp | 15 +++++++++------
 src/configServer.cpp           |  2 ++
 src/displays.cpp               | 27 +++++++++++++++++++++++++--
 src/displays.h                 |  1 +
 src/globals.h                  |  1 +
 src/utils/button.cpp           |  7 ++++---
 src/utils/button.h             |  4 ++--
 10 files changed, 44 insertions(+), 17 deletions(-)
 mode change 100755 => 100644 .github/fake-cc
 mode change 100755 => 100644 README.md

diff --git a/.github/fake-cc b/.github/fake-cc
old mode 100755
new mode 100644
diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml
index 9574a18..abb5df9 100644
--- a/.idea/codeStyles/Project.xml
+++ b/.idea/codeStyles/Project.xml
@@ -8,10 +8,6 @@
       <option name="INDENT_INSIDE_CODE_BLOCK" value="2" />
     </Objective-C>
     <codeStyleSettings language="ObjectiveC">
-      <option name="IF_BRACE_FORCE" value="3" />
-      <option name="DOWHILE_BRACE_FORCE" value="3" />
-      <option name="WHILE_BRACE_FORCE" value="3" />
-      <option name="FOR_BRACE_FORCE" value="3" />
       <indentOptions>
         <option name="INDENT_SIZE" value="2" />
         <option name="CONTINUATION_INDENT_SIZE" value="2" />
diff --git a/README.md b/README.md
old mode 100755
new mode 100644
diff --git a/src/OpenBikeSensorFirmware.cpp b/src/OpenBikeSensorFirmware.cpp
index cf715f9..2579580 100644
--- a/src/OpenBikeSensorFirmware.cpp
+++ b/src/OpenBikeSensorFirmware.cpp
@@ -77,7 +77,7 @@ Gps gps;
 static const long BLUETOOTH_INTERVAL_MILLIS = 100;
 static long lastBluetoothInterval = 0;
 
-static const long DISPLAY_INTERVAL_MILLIS = 200;
+static const long DISPLAY_INTERVAL_MILLIS = 300;
 static long lastDisplayInterval = 0;
 
 float TemperatureValue = -1;
@@ -103,7 +103,7 @@ CircularBuffer<DataSet*, 10> dataBuffer;
 FileWriter* writer;
 
 const uint8_t displayAddress = 0x3c;
-const uint16_t BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS = 10000;
+constexpr uint16_t BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS = 5000;
 
 // Enable dev-mode. Allows to
 // - set wifi config
@@ -235,26 +235,29 @@ static uint8_t shutdownState = 0;
 static unsigned long timeOfLastPowerKeepAlive = 0;
 static void powerKeepAliveTimerISR()
 {
+  unsigned long now = millis();
+
   // Send "keep alive" trigger to power management module
   // This is done by toggling the pin every 300 ms or more
   if(shutdownState == 0)
   {
-    unsigned long timeSinceLastPowerKeepAlive = millis() - timeOfLastPowerKeepAlive;
+    unsigned long timeSinceLastPowerKeepAlive = now - timeOfLastPowerKeepAlive;
     bool ip5306ButtonState = digitalRead(IP5306_BUTTON);
 
     if(!ip5306ButtonState && timeSinceLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)
     {
-      timeOfLastPowerKeepAlive = millis();
+      timeOfLastPowerKeepAlive = now;
       digitalWrite(IP5306_BUTTON, HIGH);
     }
     else if(ip5306ButtonState && timeSinceLastPowerKeepAlive > 300)
     {
-      timeOfLastPowerKeepAlive = millis();
+      timeOfLastPowerKeepAlive = now;
       digitalWrite(IP5306_BUTTON, LOW);
     }
   }
 
-  if(shutdownState == 0 && button.read() && button.getCurrentStateMillis() >= BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS) {
+  if(shutdownState == 0 && button.handle(now)
+    && button.getCurrentStateMillis() >= BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS) {
     shutdownState = 1;
   }
   switch(shutdownState)
diff --git a/src/configServer.cpp b/src/configServer.cpp
index 272fac2..2716c8f 100644
--- a/src/configServer.cpp
+++ b/src/configServer.cpp
@@ -509,6 +509,7 @@ String getIp() {
 }
 
 void updateDisplay(DisplayDevice * const display, String action = "") {
+  obsDisplay->handleShutdownDisplay();
   if (action.isEmpty()) {
     display->showTextOnGrid(0, 0, "Ver.:");
     display->showTextOnGrid(1, 0, OBSVersion);
@@ -2068,6 +2069,7 @@ void configServerHandle() {
   if (obsImprov) {
     obsImprov->handle();
   }
+  obsDisplay->handleShutdownDisplay();
 }
 
 std::vector<std::pair<String,String>> extractParameters(HTTPRequest *req) {
diff --git a/src/displays.cpp b/src/displays.cpp
index d3de344..e6d9932 100644
--- a/src/displays.cpp
+++ b/src/displays.cpp
@@ -54,6 +54,30 @@ void DisplayDevice::displaySimple(uint16_t value) {
   this->prepareTextOnGrid(3, 2, "cm", MEDIUM_FONT, -7, -5);
 }
 
+bool startedShutdownDisplay = false;
+
+bool DisplayDevice::handleShutdownDisplay()
+{
+  bool updated = false;
+#ifdef OBSPRO
+  bool buttonPressed = button.getState();
+  if (buttonPressed && button.getCurrentStateMillis() > 3000)
+  {
+    auto pressTimeMs = button.getCurrentStateMillis() - 3000;
+    // black out the display from top to bottom for so that after 7000 ms the whole display is black
+    auto linesToFill = (pressTimeMs * 64) / (BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS - 3000);
+
+    m_display->drawBox(0, 0, 128, linesToFill);
+    startedShutdownDisplay = true;
+  } else if (startedShutdownDisplay) {
+    startedShutdownDisplay = false;
+    clear();
+    updated = true;
+  }
+#endif
+  return updated;
+}
+
 void DisplayDevice::showValues(
   uint16_t sensor1MinDistance, const char* sensor1Location, uint16_t sensor1RawDistance,
   uint16_t sensor2MinDistance, const char* sensor2Location, uint16_t sensor2RawDistance, uint16_t sensor2Distance,
@@ -138,9 +162,8 @@ void DisplayDevice::showValues(
     if(BMP280_active == true)
       showTemperatureValue(TemperaturValue);
   }
-
+  handleShutdownDisplay();
   m_display->updateDisplay();
-
 }
 
 void DisplayDevice::showGPS(uint8_t sats) {
diff --git a/src/displays.h b/src/displays.h
index 44af388..85e2fe2 100644
--- a/src/displays.h
+++ b/src/displays.h
@@ -100,6 +100,7 @@ class DisplayDevice {
     uint8_t scrollUp();
     uint8_t startLine();
     void highlight(uint32_t highlightTimeMillis = 500);
+    bool handleShutdownDisplay();
 
     //##############################################################
     // Basic display configuration
diff --git a/src/globals.h b/src/globals.h
index a9cb0e5..6b727fb 100644
--- a/src/globals.h
+++ b/src/globals.h
@@ -73,5 +73,6 @@ extern Gps gps;
 
 extern const uint8_t LEFT_SENSOR_ID;
 extern const uint8_t RIGHT_SENSOR_ID;
+extern const uint16_t BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS;
 
 #endif
diff --git a/src/utils/button.cpp b/src/utils/button.cpp
index 224e1db..89eea71 100644
--- a/src/utils/button.cpp
+++ b/src/utils/button.cpp
@@ -31,11 +31,11 @@ Button::Button(int pin) : mPin(pin) {
   mLastState = mLastRawState = read();
 }
 
-void Button::handle() {
-  handle(millis());
+bool Button::handle() {
+  return handle(millis());
 }
 
-void Button::handle(unsigned long millis) {
+bool Button::handle(unsigned long millis) {
   const int state = read();
 
   if (state != mLastRawState) {
@@ -52,6 +52,7 @@ void Button::handle(unsigned long millis) {
       mReleaseEvents++;
     }
   }
+  return state;
 }
 
 bool Button::gotPressed() {
diff --git a/src/utils/button.h b/src/utils/button.h
index e8201dd..b206260 100644
--- a/src/utils/button.h
+++ b/src/utils/button.h
@@ -28,8 +28,8 @@
 class Button {
   public:
     explicit Button(int pin);
-    void handle();
-    void handle(unsigned long millis);
+    bool handle();
+    bool handle(unsigned long millis);
     int read() const;
     int getState() const;
     bool gotPressed();