Skip to content

Commit 8e631d9

Browse files
authored
Changed SPDM-Key Definiton for endorsed-csr (#37)
Signed-off-by: Fabrizio Damato <[email protected]>
1 parent 2d34fe8 commit 8e631d9

File tree

4 files changed

+25
-21
lines changed

4 files changed

+25
-21
lines changed
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
ocp-endorsed-csr = ocp-endorsed-csr-map / tagged-ocp-endorsed-csr
2+
3+
tagged-ocp-endorsed-csr= #6.572(ocp-endorsed-csr) ; speculative because IANA registry is still pending
4+
5+
; TODO: OCP will assign few attributes types but the field is not restricted to those
6+
7+
ocp-endorsed-csr-map = {
8+
&(key: 0) => [+ ocp-endorsed-csr-dict]
9+
}
10+
11+
ocp-endorsed-csr-dict = {
12+
&(id: 0) => uint
13+
&(csr: 1) => bstr
14+
&(attrib: 2) => [+ $key-attributes-type]
15+
}
16+
17+
$key-attributes-type = tagged-oid-type
18+

specifications/device-identity-provisioning/cddl/spdm-key.cddl

Lines changed: 0 additions & 17 deletions
This file was deleted.

specifications/device-identity-provisioning/diag/spdm-key-map.diag renamed to specifications/device-identity-provisioning/diag/endorsed-csr-unsigned-all.diag

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
1-
/ tagged-spdm-key-map / 572( {
1+
/ ocp-endorsed-csr-map / 572( {
22
/ key / 0 : [
33
{
44
/ id / 0 : 0,
5-
/ attrib / 1: [
5+
/ csr / 1 : h'59025630820252308201d9a003020102021431a4e0',
6+
/ attrib / 2: [
67
/ tagged-oid-type / 111(h'6086480186F84D010F046301')
78
]
89
},
910
{
1011
/ id / 0 : 1,
11-
/ attrib / 1: [
12+
/ csr / 1 : h'59025630820252308201d9a003020102021431a4e0',
13+
/ attrib / 2: [
1214
/ tagged-oid-type / 111(h'6086480186F84D010F046301')
1315
]
1416
}

specifications/device-identity-provisioning/spec.ocp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,8 @@ Table: GET_ENDORSED_CSR VendorDefinedReqPayload {#tbl:ecsr-req}
216216
| 6 | Param1 | 1 | KeyPairID. The value of this field |
217217
| | | | shall be the keypair ID identifying |
218218
| | | | the desired asymmetric key pair for |
219-
| | | | which the CSR should be issued. |
219+
| | | | which the CSR should be issued. if 0xFF |
220+
| | | | returns a list of all availabe CSRs |
220221
+---------------------+---------------------+---------------------+----------------------------------------------+
221222
| 7 | Param2 | 1 | Request Attributes. Shall adhere to |
222223
| | | | Table 91 of SPDM 1.3. |

0 commit comments

Comments
 (0)