Skip to content

Commit 1eeebfb

Browse files
Backward compatible to python 3.5
1 parent ab7a298 commit 1eeebfb

File tree

5 files changed

+28
-10
lines changed

5 files changed

+28
-10
lines changed

.github/workflows/python-package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
fail-fast: false
1818
matrix:
19-
python-version: [3.3, 3.4, 3.5, 3.6, 3.7, 3.8, 3.9]
19+
python-version: [3.5, 3.6, 3.7, 3.8, 3.9]
2020

2121
steps:
2222
- uses: actions/checkout@v2

opengsq/cli.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def register(self, parser: argparse.ArgumentParser):
2323
for (protocol_path, protocol_classnames) in re.findall(pattern, f.read()):
2424
for protocol_classname in protocol_classnames.split(','):
2525
name, fullpath, parameters = self.__extract(protocol_path, protocol_classname)
26-
subparser_name = f'protocol-{name}'
26+
subparser_name = 'protocol-{}'.format(name)
2727

2828
# Save to self.__paths dictionary
2929
# Example: subparser_name = 'protocol-a2s', fullpath = 'opengsq.protocols.a2s.A2S'
@@ -65,7 +65,7 @@ def run(self, args: Sequence[str]) -> str:
6565
# Extract name, fullpath, parameters from path, classname
6666
def __extract(self, path: str, classname: str):
6767
name = path.split('.')[-1]
68-
fullpath = f'{path}.{classname.strip()}'
68+
fullpath = '{}.{}'.format(path, classname.strip())
6969
parameters = inspect.signature(locate(fullpath).__init__).parameters
7070

7171
return name, fullpath, parameters
@@ -75,7 +75,7 @@ def __add_arguments(self, sub: argparse.ArgumentParser, parameters: Mapping[str,
7575
if parameters[key].name == 'self':
7676
continue
7777

78-
name_or_flags = f'--{parameters[key].name}'
78+
name_or_flags = '--{}'.format(parameters[key].name)
7979
required = parameters[key].default == inspect._empty
8080
default = None if required else parameters[key].default
8181
type = parameters[key].annotation

opengsq/protocols/a2s.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,10 @@ def get_info(self) -> dict:
7474
header, br = self.__challenge_request(data=self.__Request.A2S_INFO)
7575

7676
if header != self.__Response.S2A_INFO_SRC and header != self.__Response.S2A_INFO_DETAILED:
77-
raise InvalidPacketException(f'Packet header mismatch. Received: {chr(header)}. Expected: {chr(self.__Response.S2A_INFO_SRC)} or {chr(self.__Response.S2A_INFO_DETAILED)}.')
77+
raise InvalidPacketException(
78+
'Packet header mismatch. Received: {}. Expected: {} or {}.'
79+
.format(chr(header), chr(self.__Response.S2A_INFO_SRC), chr(self.__Response.S2A_INFO_DETAILED))
80+
)
7881

7982
info = {}
8083

@@ -158,7 +161,10 @@ def get_players(self) -> list:
158161
header, br = self.__challenge_request(data=self.__Request.A2S_PLAYER, challenge=self.__PACKET_HEADER)
159162

160163
if header != self.__Response.S2A_PLAYER:
161-
raise InvalidPacketException(f'Packet header mismatch. Received: {chr(header)}. Expected: {chr(self.__Response.S2A_PLAYER)}.')
164+
raise InvalidPacketException(
165+
'Packet header mismatch. Received: {}. Expected: {}.'
166+
.format(chr(header), chr(self.__Response.S2A_PLAYER))
167+
)
162168

163169
player_count = br.read_byte()
164170
players = []
@@ -183,7 +189,10 @@ def get_rules(self) -> list:
183189
header, br = self.__challenge_request(data=self.__Request.A2S_RULES, challenge=self.__PACKET_HEADER)
184190

185191
if header != self.__Response.S2A_RULES:
186-
raise InvalidPacketException(f'Packet header mismatch. Received: {chr(header)}. Expected: {chr(self.__Response.S2A_RULES)}.')
192+
raise InvalidPacketException(
193+
'Packet header mismatch. Received: {}. Expected: {}.'
194+
.format(chr(header), chr(self.__Response.S2A_RULES))
195+
)
187196

188197
rule_count = br.read_short()
189198
rules = []
@@ -220,7 +229,10 @@ def get_challenge(self) -> bytes:
220229
header = br.read_byte()
221230

222231
if header != self.__Response.S2C_CHALLENGE:
223-
raise InvalidPacketException(f'Packet header mismatch. Received: {chr(header)}. Expected: {chr(self.__Response.S2C_CHALLENGE)}.')
232+
raise InvalidPacketException(
233+
'Packet header mismatch. Received: {}. Expected: {}.'
234+
.format(chr(header), chr(self.__Response.S2C_CHALLENGE))
235+
)
224236

225237
self.__disconnect()
226238

tests/test_a2s.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@
1212

1313
servers = []
1414

15-
with urllib.request.urlopen(f'http://api.steampowered.com/IGameServersService/GetServerList/v1/?key={steam_api_key}&filter=appid\\{appid}\\empty\\1&limit=100') as f:
15+
with urllib.request.urlopen(
16+
'http://api.steampowered.com/IGameServersService/GetServerList/v1/?key={}&filter=appid\\{}\\empty\\1&limit=100'
17+
.format(steam_api_key, appid)
18+
) as f:
1619
server_list = json.loads(f.read().decode('latin-1').encode('utf-8'))['response']['servers']
1720
server_list = sorted(server_list, key=lambda s: s['players'], reverse=True)[:3]
1821

tests/test_mordhau.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@
1212

1313
servers = []
1414

15-
with urllib.request.urlopen(f'http://api.steampowered.com/IGameServersService/GetServerList/v1/?key={steam_api_key}&filter=appid\\{appid}&limit=100') as f:
15+
with urllib.request.urlopen(
16+
'http://api.steampowered.com/IGameServersService/GetServerList/v1/?key={}&filter=appid\\{}&limit=100'
17+
.format(steam_api_key, appid)
18+
) as f:
1619
server_list = json.loads(f.read().decode('latin-1').encode('utf-8'))['response']['servers']
1720
server_list = sorted(server_list, key=lambda s: s['players'], reverse=True)[:3]
1821

0 commit comments

Comments
 (0)