8359339: applications/jcstress tests should report SkippedException when can not resolve jcstress.jar

[sendaoYan]

Hi all,

I think it's more elegant that applications/jcstress tests report SkippedException when can not resolve jcstress.jar, rather than report test failure. Change has been verified locally, test-fix only, no risk.

Tests:

• Run test test/hotspot/jtreg/applications/jcstress/countdownlatch.java with -Djdk.test.lib.artifacts.jcstress-tests-all=/hygonjdk/yansendao/software/jdk/jcstress-tests-all-20241217-2035.jar, test run success as expected.
• Run test test/hotspot/jtreg/applications/jcstress/countdownlatch.java without -Djdk.test.lib.artifacts.jcstress-tests-all=/hygonjdk/yansendao/software/jdk/jcstress-tests-all-20241217-2035.jar, test report shipped as expected.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359339: applications/jcstress tests should report SkippedException when can not resolve jcstress.jar (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26345/head:pull/26345
$ git checkout pull/26345

Update a local copy of the PR:
$ git checkout pull/26345
$ git pull https://git.openjdk.org/jdk.git pull/26345/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26345

View PR using the GUI difftool:
$ git pr show -t 26345

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26345.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@sendaoYan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• net
• nio
• security
• serviceability
• shenandoah

[sendaoYan]

/label add hotspot-runtime

[openjdk]

@sendaoYan
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (f066da39)

[dholmes-ora]

I don't agree. If the jar is not found then you have a configuration/setup error. You need to know that. An Error makes you aware of the problem. Skipping won't be noticed unless you analyze SkippedException the same way you analyze errors - in which case just keep it an error.

[sendaoYan]

I don't agree. If the jar is not found then you have a configuration/setup error. You need to know that. An Error makes you aware of the problem. Skipping won't be noticed unless you analyze SkippedException the same way you analyze errors - in which case just keep it an error.

Thanks @dholmes-ora. I think you are right, I will close this PR and the issue as 'not a issue'

[sendaoYan]

But I found that there is no document to say how to run the application/jcstress tests, Should we update the file test/hotspot/jtreg/applications/jcstress/README

[tstuefe]

But I found that there is no document to say how to run the application/jcstress tests, Should we update the file test/hotspot/jtreg/applications/jcstress/README

Sure, that would be useful.

[sendaoYan]

But I found that there is no document to say how to run the application/jcstress tests, Should we update the file test/hotspot/jtreg/applications/jcstress/README

Sure, that would be useful.

I have created a new PR #26369 to update the document.