Add @Stable to LocaleProviderAdapter #26354
Draft
+163
−111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read @minberg 's PR #25727 (JDK-8359119: Change Charset to use StableValue ) and found that LocaleProviderAdapter can also be optimized.
In this way, calls like the following can fold away unnecessary branches
In the JRELocaleProviderAdapter::getLocaleServiceProvider method, use multiple ifs instead of switch(String) so that CodeSize < 325 can be inlined
Add @stable to the immutable fields of FallbackLocaleProviderAdapter/JRELocaleProviderAdapter/CLDRLocaleProviderAdapter
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26354/head:pull/26354
$ git checkout pull/26354
Update a local copy of the PR:
$ git checkout pull/26354
$ git pull https://git.openjdk.org/jdk.git pull/26354/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26354
View PR using the GUI difftool:
$ git pr show -t 26354
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26354.diff