8362582: GHA: Increase bundle retention time to deal with infra overload better

[shipilev]

I have now seen GHA runs where we spend more than 24 hours for a testing workflow. The practical effect of this is that bundles that we current carry with retention-days: 1 gets purged before jobs can use them. This then fails the test jobs that e.g. unable to pull jtreg.

This seems to happen in openjdk-bots -driven backports quite a bit (the run a lots of GHA runs, so they are often at capacity) and with Mac jobs (where the compute capacity is not great).

We can bump the retention time a bit to handle this a bit better.

Additional testing:

• GHA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362582: GHA: Increase bundle retention time to deal with infra overload better (Enhancement - P4)

Reviewers

• Goetz Lindenmaier (@GoeLin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26383/head:pull/26383
$ git checkout pull/26383

Update a local copy of the PR:
$ git checkout pull/26383
$ git pull https://git.openjdk.org/jdk.git pull/26383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26383

View PR using the GUI difftool:
$ git pr show -t 26383

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26383.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362582: GHA: Increase bundle retention time to deal with infra overload better

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2430bf90)

[tstuefe]

+1

[tstuefe]

I have now seen GHA runs where we spend more than 24 hours for a testing workflow.

:-( What tests are those, are they special runs? Or the standard ones?

[shipilev]

:-( What tests are those, are they special runs? Or the standard ones?

No, just normal ones. @GoeLin showed me https://github.com/openjdk-bots/jdk21u-dev/actions/runs/16302821665/job/46063676040 this morning, but I see there are others in https://github.com/openjdk-bots/jdk21u-dev/actions/. I have a gut feeling that this is a combination of per-user quota (which hits "shared" openjdk-bots heavily) and the Mac capacity in GHA. So it hits /backport users more often, than those who use their own personal forks.

[tstuefe]

:-( What tests are those, are they special runs? Or the standard ones?

No, just normal ones. @GoeLin showed me https://github.com/openjdk-bots/jdk21u-dev/actions/runs/16302821665/job/46063676040 this morning, but I see there are others in https://github.com/openjdk-bots/jdk21u-dev/actions/. I have a gut feeling that this is a combination of per-user quota (which hits "shared" openjdk-bots heavily) and the Mac capacity in GHA. So it hits /backport users more often, than those who use their own personal forks.

yes, makes sense its a quota limit, since none of the individual jobs themselves took that long, but total runtime is still 1d8hrs.

[GoeLin]

Hi,
Sometimes I address many simple test fix backports. This can easily be 20+ in 2-3 hours. This is probably what saturates the infra and my quota.
In general, I don't await all tests to finish. On a test change, running all the other tests is pointless. But if there are failed tests, I look at all of these (tedious!). Usually, it takes me two working days to get through all the process steps and to push such a change. But I can't make the 24h deadline, nor do I want to to give at least some time for others to eventually have a look at the backport.

So I really appreciate this change.

[tstuefe]

BTW, this is one more reason why its important to require backporters to have run the full suite of GHAs in their own fork before fix-requesting.

[shipilev]

OK, good. I think we can integrate this. I need a formal approval from someone in build group, like @magicus @erikj79 @TheShermanTanker.