diff --git a/src/hotspot/share/oops/compressedOops.cpp b/src/hotspot/share/oops/compressedOops.cpp index 2c5f1631d853b..b09aaa3547d14 100644 --- a/src/hotspot/share/oops/compressedOops.cpp +++ b/src/hotspot/share/oops/compressedOops.cpp @@ -22,6 +22,7 @@ * */ +#include "gc/shared/collectedHeap.hpp" #include "logging/log.hpp" #include "logging/logStream.hpp" #include "memory/memRegion.hpp" @@ -29,7 +30,6 @@ #include "memory/resourceArea.hpp" #include "memory/universe.hpp" #include "oops/compressedOops.hpp" -#include "gc/shared/collectedHeap.hpp" #include "runtime/arguments.hpp" #include "runtime/globals.hpp" diff --git a/src/hotspot/share/oops/compressedOops.hpp b/src/hotspot/share/oops/compressedOops.hpp index 33af420305cba..4493444237491 100644 --- a/src/hotspot/share/oops/compressedOops.hpp +++ b/src/hotspot/share/oops/compressedOops.hpp @@ -29,6 +29,7 @@ #include "memory/memRegion.hpp" #include "oops/oopsHierarchy.hpp" #include "utilities/globalDefinitions.hpp" + #include class outputStream; diff --git a/src/hotspot/share/oops/cpCache.cpp b/src/hotspot/share/oops/cpCache.cpp index a855639e74b8f..a56e345397075 100644 --- a/src/hotspot/share/oops/cpCache.cpp +++ b/src/hotspot/share/oops/cpCache.cpp @@ -31,8 +31,8 @@ #include "classfile/systemDictionaryShared.hpp" #include "classfile/vmClasses.hpp" #include "code/codeCache.hpp" -#include "interpreter/bytecodeStream.hpp" #include "interpreter/bytecodes.hpp" +#include "interpreter/bytecodeStream.hpp" #include "interpreter/interpreter.hpp" #include "interpreter/linkResolver.hpp" #include "interpreter/rewriter.hpp" diff --git a/src/hotspot/share/oops/fieldInfo.cpp b/src/hotspot/share/oops/fieldInfo.cpp index d0825ba6df8b5..8c1a9e46d4034 100644 --- a/src/hotspot/share/oops/fieldInfo.cpp +++ b/src/hotspot/share/oops/fieldInfo.cpp @@ -22,8 +22,8 @@ * */ -#include "memory/resourceArea.hpp" #include "cds/cdsConfig.hpp" +#include "memory/resourceArea.hpp" #include "oops/fieldInfo.inline.hpp" #include "runtime/atomic.hpp" #include "utilities/packedTable.hpp" diff --git a/src/hotspot/share/oops/fieldStreams.hpp b/src/hotspot/share/oops/fieldStreams.hpp index 0ae828d73d99a..23ec156473bfa 100644 --- a/src/hotspot/share/oops/fieldStreams.hpp +++ b/src/hotspot/share/oops/fieldStreams.hpp @@ -25,8 +25,8 @@ #ifndef SHARE_OOPS_FIELDSTREAMS_HPP #define SHARE_OOPS_FIELDSTREAMS_HPP -#include "oops/instanceKlass.hpp" #include "oops/fieldInfo.hpp" +#include "oops/instanceKlass.hpp" #include "runtime/fieldDescriptor.hpp" // The is the base class for iteration over the fields array diff --git a/src/hotspot/share/oops/instanceKlass.cpp b/src/hotspot/share/oops/instanceKlass.cpp index f4ab8c3140966..0c9d6b0bcdcaf 100644 --- a/src/hotspot/share/oops/instanceKlass.cpp +++ b/src/hotspot/share/oops/instanceKlass.cpp @@ -50,8 +50,8 @@ #include "interpreter/rewriter.hpp" #include "jvm.h" #include "jvmtifiles/jvmti.h" -#include "logging/log.hpp" #include "klass.inline.hpp" +#include "logging/log.hpp" #include "logging/logMessage.hpp" #include "logging/logStream.hpp" #include "memory/allocation.inline.hpp" @@ -61,8 +61,8 @@ #include "memory/oopFactory.hpp" #include "memory/resourceArea.hpp" #include "memory/universe.hpp" -#include "oops/fieldStreams.inline.hpp" #include "oops/constantPool.hpp" +#include "oops/fieldStreams.inline.hpp" #include "oops/instanceClassLoaderKlass.hpp" #include "oops/instanceKlass.inline.hpp" #include "oops/instanceMirrorKlass.hpp" @@ -78,8 +78,8 @@ #include "prims/jvmtiThreadState.hpp" #include "prims/methodComparator.hpp" #include "runtime/arguments.hpp" -#include "runtime/deoptimization.hpp" #include "runtime/atomic.hpp" +#include "runtime/deoptimization.hpp" #include "runtime/fieldDescriptor.inline.hpp" #include "runtime/handles.inline.hpp" #include "runtime/javaCalls.hpp" diff --git a/src/hotspot/share/oops/instanceOop.hpp b/src/hotspot/share/oops/instanceOop.hpp index e97cd00f79fee..bfc16ea3a25a4 100644 --- a/src/hotspot/share/oops/instanceOop.hpp +++ b/src/hotspot/share/oops/instanceOop.hpp @@ -26,6 +26,7 @@ #define SHARE_OOPS_INSTANCEOOP_HPP #include "oops/oop.hpp" + #include // An instanceOop is an instance of a Java Class diff --git a/src/hotspot/share/oops/klassVtable.cpp b/src/hotspot/share/oops/klassVtable.cpp index 8d13310cdc7a0..e9da33b280e60 100644 --- a/src/hotspot/share/oops/klassVtable.cpp +++ b/src/hotspot/share/oops/klassVtable.cpp @@ -40,8 +40,8 @@ #include "oops/objArrayOop.hpp" #include "oops/oop.inline.hpp" #include "runtime/flags/flagSetting.hpp" -#include "runtime/java.hpp" #include "runtime/handles.inline.hpp" +#include "runtime/java.hpp" #include "runtime/safepointVerifiers.hpp" #include "utilities/copy.hpp" diff --git a/src/hotspot/share/oops/markWord.inline.hpp b/src/hotspot/share/oops/markWord.inline.hpp index 27c8cfdeaef59..8936ed1d52347 100644 --- a/src/hotspot/share/oops/markWord.inline.hpp +++ b/src/hotspot/share/oops/markWord.inline.hpp @@ -25,9 +25,10 @@ #ifndef SHARE_OOPS_MARKWORD_INLINE_HPP #define SHARE_OOPS_MARKWORD_INLINE_HPP -#include "oops/compressedOops.inline.hpp" #include "oops/markWord.hpp" +#include "oops/compressedOops.inline.hpp" + narrowKlass markWord::narrow_klass() const { #ifdef _LP64 assert(UseCompactObjectHeaders, "only used with compact object headers"); diff --git a/src/hotspot/share/oops/metadata.cpp b/src/hotspot/share/oops/metadata.cpp index be3b523c5d5b1..8f86be292bd28 100644 --- a/src/hotspot/share/oops/metadata.cpp +++ b/src/hotspot/share/oops/metadata.cpp @@ -22,8 +22,8 @@ * */ -#include "oops/metadata.hpp" #include "memory/resourceArea.hpp" +#include "oops/metadata.hpp" #include "prims/jvmtiRedefineClasses.hpp" void Metadata::set_on_stack(const bool value) { diff --git a/src/hotspot/share/oops/method.cpp b/src/hotspot/share/oops/method.cpp index 7552bf50ed9f9..595b4e528824a 100644 --- a/src/hotspot/share/oops/method.cpp +++ b/src/hotspot/share/oops/method.cpp @@ -36,9 +36,9 @@ #include "code/debugInfoRec.hpp" #include "compiler/compilationPolicy.hpp" #include "gc/shared/collectedHeap.inline.hpp" +#include "interpreter/bytecodes.hpp" #include "interpreter/bytecodeStream.hpp" #include "interpreter/bytecodeTracer.hpp" -#include "interpreter/bytecodes.hpp" #include "interpreter/interpreter.hpp" #include "interpreter/oopMapCache.hpp" #include "logging/log.hpp" @@ -51,8 +51,8 @@ #include "memory/resourceArea.hpp" #include "memory/universe.hpp" #include "nmt/memTracker.hpp" -#include "oops/constMethod.hpp" #include "oops/constantPool.hpp" +#include "oops/constMethod.hpp" #include "oops/jmethodIDTable.hpp" #include "oops/klass.inline.hpp" #include "oops/method.inline.hpp" @@ -64,8 +64,8 @@ #include "oops/trainingData.hpp" #include "prims/jvmtiExport.hpp" #include "prims/methodHandles.hpp" -#include "runtime/atomic.hpp" #include "runtime/arguments.hpp" +#include "runtime/atomic.hpp" #include "runtime/continuationEntry.hpp" #include "runtime/frame.inline.hpp" #include "runtime/handles.inline.hpp" diff --git a/src/hotspot/share/oops/method.hpp b/src/hotspot/share/oops/method.hpp index b241104b62cb0..4592cb8a8c0c6 100644 --- a/src/hotspot/share/oops/method.hpp +++ b/src/hotspot/share/oops/method.hpp @@ -29,8 +29,8 @@ #include "compiler/compilerDefinitions.hpp" #include "oops/annotations.hpp" #include "oops/constantPool.hpp" -#include "oops/methodFlags.hpp" #include "oops/instanceKlass.hpp" +#include "oops/methodFlags.hpp" #include "oops/oop.hpp" #include "utilities/accessFlags.hpp" #include "utilities/align.hpp" diff --git a/src/hotspot/share/oops/methodCounters.cpp b/src/hotspot/share/oops/methodCounters.cpp index c0787cab5e4bc..8f29f9b7bbde4 100644 --- a/src/hotspot/share/oops/methodCounters.cpp +++ b/src/hotspot/share/oops/methodCounters.cpp @@ -26,11 +26,11 @@ #include "compiler/compiler_globals.hpp" #include "compiler/compilerOracle.hpp" #include "memory/metaspaceClosure.hpp" +#include "memory/resourceArea.hpp" #include "oops/method.hpp" #include "oops/methodCounters.hpp" #include "oops/trainingData.hpp" #include "runtime/handles.inline.hpp" -#include "memory/resourceArea.hpp" MethodCounters::MethodCounters(const methodHandle& mh) : _method(mh()), diff --git a/src/hotspot/share/oops/methodCounters.hpp b/src/hotspot/share/oops/methodCounters.hpp index 4f4a1d1948fde..df8acefc3eb97 100644 --- a/src/hotspot/share/oops/methodCounters.hpp +++ b/src/hotspot/share/oops/methodCounters.hpp @@ -25,9 +25,9 @@ #ifndef SHARE_OOPS_METHODCOUNTERS_HPP #define SHARE_OOPS_METHODCOUNTERS_HPP -#include "oops/metadata.hpp" #include "compiler/compilerDefinitions.hpp" #include "interpreter/invocationCounter.hpp" +#include "oops/metadata.hpp" #include "utilities/align.hpp" class MethodTrainingData; diff --git a/src/hotspot/share/oops/objArrayOop.hpp b/src/hotspot/share/oops/objArrayOop.hpp index 20e2953fee9f5..8e39b897018f6 100644 --- a/src/hotspot/share/oops/objArrayOop.hpp +++ b/src/hotspot/share/oops/objArrayOop.hpp @@ -27,6 +27,7 @@ #include "oops/arrayOop.hpp" #include "utilities/align.hpp" + #include class Klass; diff --git a/src/hotspot/share/oops/oop.hpp b/src/hotspot/share/oops/oop.hpp index 8048c8770c2ba..549b5b0bff8c8 100644 --- a/src/hotspot/share/oops/oop.hpp +++ b/src/hotspot/share/oops/oop.hpp @@ -27,14 +27,15 @@ #include "memory/iterator.hpp" #include "memory/memRegion.hpp" -#include "oops/compressedKlass.hpp" #include "oops/accessDecorators.hpp" +#include "oops/compressedKlass.hpp" #include "oops/markWord.hpp" #include "oops/metadata.hpp" #include "oops/objLayout.hpp" #include "runtime/atomic.hpp" #include "utilities/globalDefinitions.hpp" #include "utilities/macros.hpp" + #include // oopDesc is the top baseclass for objects classes. The {name}Desc classes describe diff --git a/src/hotspot/share/oops/oop.inline.hpp b/src/hotspot/share/oops/oop.inline.hpp index 3dad778a73a47..683792e52019c 100644 --- a/src/hotspot/share/oops/oop.inline.hpp +++ b/src/hotspot/share/oops/oop.inline.hpp @@ -27,22 +27,22 @@ #include "oops/oop.hpp" -#include "memory/universe.hpp" #include "memory/iterator.inline.hpp" +#include "memory/universe.hpp" #include "oops/access.inline.hpp" #include "oops/arrayKlass.hpp" #include "oops/arrayOop.hpp" #include "oops/compressedKlass.inline.hpp" #include "oops/instanceKlass.hpp" -#include "oops/objLayout.inline.hpp" #include "oops/markWord.inline.hpp" +#include "oops/objLayout.inline.hpp" #include "oops/oopsHierarchy.hpp" #include "runtime/atomic.hpp" #include "runtime/globals.hpp" #include "utilities/align.hpp" #include "utilities/debug.hpp" -#include "utilities/macros.hpp" #include "utilities/globalDefinitions.hpp" +#include "utilities/macros.hpp" // Implementation of all inlined member functions defined in oop.hpp // We need a separate file to avoid circular references diff --git a/src/hotspot/share/oops/oopCast.inline.hpp b/src/hotspot/share/oops/oopCast.inline.hpp index 64c4ffe1b8014..1b21b3fd4e7ee 100644 --- a/src/hotspot/share/oops/oopCast.inline.hpp +++ b/src/hotspot/share/oops/oopCast.inline.hpp @@ -24,8 +24,8 @@ #ifndef SHARE_OOPS_OOPCAST_INLINE_HPP #define SHARE_OOPS_OOPCAST_INLINE_HPP -#include "oops/oopsHierarchy.hpp" #include "oops/oop.inline.hpp" +#include "oops/oopsHierarchy.hpp" template static bool is_oop_type(oop theOop) { diff --git a/src/hotspot/share/oops/oopHandle.inline.hpp b/src/hotspot/share/oops/oopHandle.inline.hpp index 77dd1790159a5..343d677ab04fe 100644 --- a/src/hotspot/share/oops/oopHandle.inline.hpp +++ b/src/hotspot/share/oops/oopHandle.inline.hpp @@ -27,8 +27,8 @@ #include "oops/oopHandle.hpp" -#include "oops/access.inline.hpp" #include "gc/shared/oopStorage.inline.hpp" +#include "oops/access.inline.hpp" inline oop OopHandle::resolve() const { if (_obj == nullptr) { diff --git a/src/hotspot/share/oops/stackChunkOop.inline.hpp b/src/hotspot/share/oops/stackChunkOop.inline.hpp index 4b2c160cd8140..384dbefc10b3f 100644 --- a/src/hotspot/share/oops/stackChunkOop.inline.hpp +++ b/src/hotspot/share/oops/stackChunkOop.inline.hpp @@ -27,9 +27,9 @@ #include "oops/stackChunkOop.hpp" -#include "gc/shared/collectedHeap.hpp" #include "gc/shared/barrierSet.hpp" #include "gc/shared/barrierSetStackChunk.hpp" +#include "gc/shared/collectedHeap.hpp" #include "gc/shared/gc_globals.hpp" #include "memory/memRegion.hpp" #include "memory/universe.hpp" diff --git a/src/hotspot/share/oops/trainingData.cpp b/src/hotspot/share/oops/trainingData.cpp index e82a7a3e2bdbd..70e8f2437c1b6 100644 --- a/src/hotspot/share/oops/trainingData.cpp +++ b/src/hotspot/share/oops/trainingData.cpp @@ -22,10 +22,10 @@ * */ -#include "ci/ciEnv.hpp" -#include "ci/ciMetadata.hpp" #include "cds/cdsConfig.hpp" #include "cds/metaspaceShared.hpp" +#include "ci/ciEnv.hpp" +#include "ci/ciMetadata.hpp" #include "classfile/classLoaderData.hpp" #include "classfile/compactHashtable.hpp" #include "classfile/javaClasses.hpp" diff --git a/src/hotspot/share/oops/trainingData.hpp b/src/hotspot/share/oops/trainingData.hpp index 1d03056871bd1..b4fd5fd61abaf 100644 --- a/src/hotspot/share/oops/trainingData.hpp +++ b/src/hotspot/share/oops/trainingData.hpp @@ -28,8 +28,8 @@ #include "cds/cdsConfig.hpp" #include "classfile/classLoaderData.hpp" #include "classfile/compactHashtable.hpp" -#include "compiler/compilerDefinitions.hpp" #include "compiler/compiler_globals.hpp" +#include "compiler/compilerDefinitions.hpp" #include "memory/allocation.hpp" #include "memory/metaspaceClosure.hpp" #include "oops/instanceKlass.hpp" diff --git a/src/hotspot/share/oops/typeArrayOop.hpp b/src/hotspot/share/oops/typeArrayOop.hpp index 0ca63622d1d64..c96001e93630b 100644 --- a/src/hotspot/share/oops/typeArrayOop.hpp +++ b/src/hotspot/share/oops/typeArrayOop.hpp @@ -27,6 +27,7 @@ #include "oops/arrayOop.hpp" #include "oops/typeArrayKlass.hpp" + #include // A typeArrayOop is an array containing basic types (non oop elements). diff --git a/src/hotspot/share/oops/typeArrayOop.inline.hpp b/src/hotspot/share/oops/typeArrayOop.inline.hpp index 43fb6a06b395d..a5a1e3200d18e 100644 --- a/src/hotspot/share/oops/typeArrayOop.inline.hpp +++ b/src/hotspot/share/oops/typeArrayOop.inline.hpp @@ -28,8 +28,8 @@ #include "oops/typeArrayOop.hpp" #include "oops/access.inline.hpp" -#include "oops/oop.inline.hpp" #include "oops/arrayOop.hpp" +#include "oops/oop.inline.hpp" size_t typeArrayOopDesc::object_size(const TypeArrayKlass* tk) const { return object_size(tk->layout_helper(), length()); diff --git a/test/hotspot/jtreg/sources/TestIncludesAreSorted.java b/test/hotspot/jtreg/sources/TestIncludesAreSorted.java index ed3712810cbb9..222b97d605668 100644 --- a/test/hotspot/jtreg/sources/TestIncludesAreSorted.java +++ b/test/hotspot/jtreg/sources/TestIncludesAreSorted.java @@ -47,6 +47,7 @@ public class TestIncludesAreSorted { "share/ci", "share/compiler", "share/jvmci", + "share/oops", "share/opto" };