Skip to content

8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization #3611

wants to merge 2 commits into from
+3 −3

Conversation

@jankratochvil
Copy link
Contributor

@jankratochvil jankratochvil commented May 25, 2025 •
edited by openjdk bot
Loading

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8355077 needs maintainer approval

Issue

  • JDK-8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3611/head:pull/3611
$ git checkout pull/3611

Update a local copy of the PR:
$ git checkout pull/3611
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3611/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3611

View PR using the GUI difftool:
$ git pr show -t 3611

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3611.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 25, 2025 •
edited
Loading

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 898d4798003d7b9cd54ef3a149eb037998a39887 8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization May 25, 2025
@openjdk
Copy link

openjdk bot commented May 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 25, 2025
@openjdk
Copy link

openjdk bot commented May 25, 2025

⚠️ @jankratochvil This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 25, 2025
@mlbridge
Copy link

mlbridge bot commented May 25, 2025 •
edited
Loading

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2025

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2025

@jankratochvil This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jul 20, 2025
@jankratochvil
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this Jul 21, 2025
@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@jankratochvil This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2025

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2025

@jankratochvil This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Sep 16, 2025
@avu
Copy link
Contributor

avu commented Sep 22, 2025

/open

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@avu Only the pull request author can set the pull request state to "open"

@jankratochvil
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this Sep 22, 2025
@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@jankratochvil This pull request is now open

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 17, 2025
@jankratochvil
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 20, 2025
@openjdk
Copy link

openjdk bot commented Oct 20, 2025

@jankratochvil
Your change (at version cd5d52a) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

Same comment as for 21u-dev PR: re-merge from master to make sure there no surprising errors.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jankratochvil @avu @shipilev @YaSuenag