Skip to content

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 3, 2025

Hi all,

This pull request contains a backport of commit 8fcbb110 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 27 Jul 2025 and was reviewed by Jaikiran Pai.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8362855 needs maintainer approval

Issue

  • JDK-8362855: Test java/net/ipv6tests/TcpTest.java should report SkippedException when there no ia4addr or ia6addr (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3793/head:pull/3793
$ git checkout pull/3793

Update a local copy of the PR:
$ git checkout pull/3793
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3793

View PR using the GUI difftool:
$ git pr show -t 3793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3793.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 3, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362855: Test java/net/ipv6tests/TcpTest.java should report SkippedException when there no ia4addr  or ia6addr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0f49f65af3ac85b93ccf140dcfad823fb03b5ce1 8362855: Test java/net/ipv6tests/TcpTest.java should report SkippedException when there no ia4addr or ia6addr Aug 3, 2025
@openjdk
Copy link

openjdk bot commented Aug 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 3, 2025
@openjdk
Copy link

openjdk bot commented Aug 3, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 3, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

GHA report two failures, all about "Cannot check Release signature" during 'Create sysroot'. It seems like infrastructure issue, it's unrelated to this backport PR.

@sendaoYan
Copy link
Member Author

/approval request Clean backport to make test more robustness, test-fix only, change has been verified locally, no risk.

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@sendaoYan
8362855: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 1, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

Going to push as commit a9cadcd.
Since your change was applied there have been 95 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 5, 2025
@openjdk openjdk bot closed this Sep 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2025
@openjdk
Copy link

openjdk bot commented Sep 5, 2025

@sendaoYan Pushed as commit a9cadcd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant