-
Notifications
You must be signed in to change notification settings - Fork 145
8325277: [21u] Backout test change of JDK-8291809 #2381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 30 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
…-8291809 with fastdebug build on aarch64 platform with SVE
|
/issue JDK-8325277 |
|
@sendaoYan This issue is referenced in the PR title - it will now be updated. |
|
|
|
Thanks for the reviews @phohensee /approval request Cleanly git revert for backout the JDK-8291809 , since the JDK-8291809 will cause test fails on linux-aarch64 with SVE2. Change has been verified locally. Test-fix only, no risk. |
|
@sendaoYan |
|
Thanks for the approved @jerboaa /integrate |
|
Going to push as commit d29794f.
Your commit was automatically rebased without conflicts. |
|
@sendaoYan Pushed as commit d29794f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
As discuss in JDK-8325277, we want to backout the "backport JDK-8291809 to jdk21u-dev".
The test_divc and test_divc_n cannot be vectorized on 128-bit vector platforms with JDK 21u due to algorithmic constraints in superword.cpp, which led to the reported failure in JDK-8325277.
Starting from JDK 23, the algorithm has been significantly improved, and both cases can now be vectorized on 128-bit platforms, allowing the test to pass.
Test-fix only, risk is low.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2381/head:pull/2381$ git checkout pull/2381Update a local copy of the PR:
$ git checkout pull/2381$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2381/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2381View PR using the GUI difftool:
$ git pr show -t 2381Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2381.diff
Using Webrev
Link to Webrev Comment