Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 23, 2025

Hi all,

As discuss in JDK-8325277, we want to backout the "backport JDK-8291809 to jdk21u-dev".

The test_divc and test_divc_n cannot be vectorized on 128-bit vector platforms with JDK 21u due to algorithmic constraints in superword.cpp, which led to the reported failure in JDK-8325277.
Starting from JDK 23, the algorithm has been significantly improved, and both cases can now be vectorized on 128-bit platforms, allowing the test to pass.

Test-fix only, risk is low.

Testing:

  • Run tests compiler/c2/cr7200264/TestSSE2IntVect.java compiler/c2/cr7200264/TestSSE4IntVect.java on linux-x64
  • Run tests compiler/c2/cr7200264/TestSSE2IntVect.java compiler/c2/cr7200264/TestSSE4IntVect.java on linux-aarch64 without SVE2, jtreg shows no test.
  • Run tests compiler/c2/cr7200264/TestSSE2IntVect.java compiler/c2/cr7200264/TestSSE4IntVect.java on linux-aarch64 with SVE2, jtreg shows no test.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8325277 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8325277: [21u] Backout test change of JDK-8291809 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2381/head:pull/2381
$ git checkout pull/2381

Update a local copy of the PR:
$ git checkout pull/2381
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2381/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2381

View PR using the GUI difftool:
$ git pr show -t 2381

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2381.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325277: [21u] Backout test change of JDK-8291809

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2025

Webrevs

…-8291809 with fastdebug build on aarch64 platform with SVE
@sendaoYan
Copy link
Member Author

/issue JDK-8325277

@openjdk openjdk bot changed the title 8325277: [21u] compiler/c2/cr7200264/TestIntVect.java fails after JDK-8291809 with fastdebug build on aarch64 platform with SVE 8325277: [21u] Backout test change of JDK-8291809 Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@sendaoYan This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

Thanks for the reviews @phohensee

/approval request Cleanly git revert for backout the JDK-8291809 , since the JDK-8291809 will cause test fails on linux-aarch64 with SVE2. Change has been verified locally. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@sendaoYan
8325277: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 28, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved @jerboaa

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

Going to push as commit d29794f.
Since your change was applied there have been 45 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 29, 2025
@openjdk openjdk bot closed this Oct 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2025
@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@sendaoYan Pushed as commit d29794f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants