Skip to content

Commit 8a8063e

Browse files
Completes OPEN-3551 Remove missing value validation from the dataset upload process
1 parent 6549c75 commit 8a8063e

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

openlayer/validators.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -556,12 +556,6 @@ def _validate_dataset_and_config_consistency(self):
556556
text_column_name = self.dataset_config.get("textColumnName")
557557
predictions_column_name = self.dataset_config.get("predictionsColumnName")
558558

559-
if self._contains_null_values(dataset_df):
560-
dataset_and_config_consistency_failed_validations.append(
561-
"The dataset contains null values, which are currently not supported. "
562-
"Please provide a dataset without null values."
563-
)
564-
565559
if self._contains_unsupported_dtypes(dataset_df):
566560
dataset_and_config_consistency_failed_validations.append(
567561
"The dataset contains unsupported dtypes. The supported dtypes are "
@@ -698,11 +692,6 @@ def _validate_dataset_and_config_consistency(self):
698692
dataset_and_config_consistency_failed_validations
699693
)
700694

701-
@staticmethod
702-
def _contains_null_values(dataset_df: pd.DataFrame) -> bool:
703-
"""Checks whether the dataset contains null values."""
704-
return dataset_df.isnull().values.any()
705-
706695
@staticmethod
707696
def _labels_not_zero_indexed(
708697
dataset_df: pd.DataFrame, label_column_name: str, class_names: List[str]

0 commit comments

Comments
 (0)