Skip to content

Conversation

@jhadvig
Copy link
Member

@jhadvig jhadvig commented Oct 22, 2025

If the console-plugin-storage-version-migration SVM succeeds we need to remove the ConsolePlugin CRD so CVO will recreate it, without the v1alpha1 version.
Implemented retry in case the SVM status condition is not successful, which eventually will leave in SVM deletion, which will kick off its recreation by CVO.

NOTICE: this PR is opened against 4.20 branch, so the functionality can be tested. @yapei PTAL

/assign @JoelSpeed

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 22, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 22, 2025

@jhadvig: This pull request references Jira Issue OCPBUGS-52556, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • dependent bug CONSOLE-4612 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the console-plugin-storage-version-migration SVM succeeds we need to remove the ConsolePlugin CRD's status.storedVersions v1alpha1 entry and leave just v1 version.
Implemented retry in case the SVM status condition is not successful, which eventually will leave in SVM deletion, which will kick off its recreation by CVO.

NOTICE: this PR is opened against 4.20 branch, so the functionality can be tested. @yapei PTAL

/assign @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@jhadvig jhadvig changed the title OCPBUGS-52556: Remove SVM console instance if v1alpha1 ConsolePlugin version in present in the CRDs status [release-4.20] OCPBUGS-52556: Remove SVM console instance if v1alpha1 ConsolePlugin version in present in the CRDs status Oct 22, 2025
@jhadvig jhadvig force-pushed the OCPBUGS-52556 branch 2 times, most recently from 5541ca6 to b921e0a Compare October 23, 2025 11:01
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2025

@jhadvig: This pull request references Jira Issue OCPBUGS-52556, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • dependent bug CONSOLE-4612 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the console-plugin-storage-version-migration SVM succeeds we need to remove the ConsolePlugin CRD so CVO will recreate it, without the v1alpha1 version.
Implemented retry in case the SVM status condition is not successful, which eventually will leave in SVM deletion, which will kick off its recreation by CVO.

NOTICE: this PR is opened against 4.20 branch, so the functionality can be tested. @yapei PTAL

/assign @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig jhadvig changed the title [release-4.20] OCPBUGS-52556: Remove SVM console instance if v1alpha1 ConsolePlugin version in present in the CRDs status [release-4.20] OCPBUGS-52556: Delete ConsolePlugin CRD after successful SVM migration, forcing CVO to recreate the CRD without the v1alpha1 storedVersion Oct 24, 2025
@jhadvig jhadvig changed the title [release-4.20] OCPBUGS-52556: Delete ConsolePlugin CRD after successful SVM migration, forcing CVO to recreate the CRD without the v1alpha1 storedVersion [release-4.20] OCPBUGS-52556: Remove v1alpha1 ConsolePlugin version from CRDs status Oct 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

@jhadvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6638158 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yapei
Copy link
Contributor

yapei commented Oct 26, 2025

tested through upgrade from 4.18

==== at 418
$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.18.27   True        False         3h44m   Cluster version is 4.18.27

$ oc get crd consoleplugins.console.openshift.io -o json | jq '(.spec.versions[] | .name, .storage)'
"v1"
true
"v1alpha1"
false

$ oc get crd consoleplugins.console.openshift.io -o json | jq .status.storedVersions
[
  "v1",
  "v1alpha1"
]
======= at 419
$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.19.17   True        False         5h29m   Cluster version is 4.19.17

$ oc get crd consoleplugins.console.openshift.io -o json | jq '(.spec.versions[] | .name, .storage)'
"v1"
true
"v1alpha1"
false
$ oc get crd consoleplugins.console.openshift.io -o json | jq .status.storedVersions
[
  "v1",
  "v1alpha1"
]
======= at 420
$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.20.0-0-2025-10-26-005626-test-ci-ln-zvpc70t-latest   True        False         61m     Cluster version is 4.20.0-0-2025-10-26-005626-test-ci-ln-zvpc70t-latest

$ oc get crd consoleplugins.console.openshift.io -o json | jq .status.storedVersions
[
  "v1"
]

$ oc get crd consoleplugins.console.openshift.io -o json | jq '(.spec.versions[] | .name, .storage)'
"v1"
true
"v1alpha1"
false

Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yapei
Copy link
Contributor

yapei commented Oct 30, 2025

/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 30, 2025
@openshift-ci-robot
Copy link
Contributor

@yapei: This PR has been marked as verified by @yapei.

In response to this:

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig jhadvig changed the title [release-4.20] OCPBUGS-52556: Remove v1alpha1 ConsolePlugin version from CRDs status [release-4.20] OCPBUGS-64602: Remove v1alpha1 ConsolePlugin version from CRDs status Nov 3, 2025
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-64602, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-64602 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the console-plugin-storage-version-migration SVM succeeds we need to remove the ConsolePlugin CRD so CVO will recreate it, without the v1alpha1 version.
Implemented retry in case the SVM status condition is not successful, which eventually will leave in SVM deletion, which will kick off its recreation by CVO.

NOTICE: this PR is opened against 4.20 branch, so the functionality can be tested. @yapei PTAL

/assign @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig
Copy link
Member Author

jhadvig commented Nov 5, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 5, 2025
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-64602, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-64601 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-64601 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei November 5, 2025 12:10
@jhadvig
Copy link
Member Author

jhadvig commented Nov 5, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit cdbc995 into openshift:release-4.20 Nov 5, 2025
10 of 11 checks passed
@openshift-ci-robot
Copy link
Contributor

@jhadvig: Jira Issue Verification Checks: Jira Issue OCPBUGS-64602
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-64602 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

If the console-plugin-storage-version-migration SVM succeeds we need to remove the ConsolePlugin CRD so CVO will recreate it, without the v1alpha1 version.
Implemented retry in case the SVM status condition is not successful, which eventually will leave in SVM deletion, which will kick off its recreation by CVO.

NOTICE: this PR is opened against 4.20 branch, so the functionality can be tested. @yapei PTAL

/assign @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.20.0-0.nightly-2025-11-05-192504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants