Skip to content

Conversation

@jhadvig
Copy link
Member

@jhadvig jhadvig commented Oct 23, 2025

If the console-plugin-storage-version-migration SVM succeeds we need to remove the ConsolePlugin CRD's status.storedVersions v1alpha1 entry and leave just v1 version.
Implemented retry in case the SVM status condition is not successful, which eventually will leave in SVM deletion, which will kick off its recreation by CVO.

RBAC: Adding patch permissions for the consoleplugins.console.openshift.io CRD.

/assign @TheRealJon @Leo6Leo

@yapei FYI

4.20 backport for testing purposes - #1060

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 23, 2025
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-52556, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the console-plugin-storage-version-migration SVM succeeds we need to remove the ConsolePlugin CRD's status.storedVersions v1alpha1 entry and leave just v1 version.
Implemented retry in case the SVM status condition is not successful, which eventually will leave in SVM deletion, which will kick off its recreation by CVO.

RBAC: Adding patch permissions for the consoleplugins.console.openshift.io CRD.

/assign @TheRealJon @Leo6Leo

@yapei FYI

4.20 backport for testing purposes - #1060

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TheRealJon and spadgett October 23, 2025 11:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@jhadvig jhadvig force-pushed the OCPBUGS-52556_main branch from a22b6e2 to c9f469d Compare October 29, 2025 15:38
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yapei
Copy link
Contributor

yapei commented Oct 30, 2025

==== initial 419
$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.19.17   True        False         28m     Cluster version is 4.19.17

$ oc edit crd consoleplugins.console.openshift.io --subresource status
customresourcedefinition.apiextensions.k8s.io/consoleplugins.console.openshift.io edited


$ oc get crd consoleplugins.console.openshift.io -o json | jq .status.storedVersions
[
  "v1",
  "v1alpha1"
]

==== upgraded to 420
$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.20.1    True        False         125m    Cluster version is 4.20.1

$ oc get crd consoleplugins.console.openshift.io -o json | jq .status.storedVersions
[
  "v1",
  "v1alpha1"
]

==== upgraded to 421
$ 
$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.21.0-0-2025-10-30-013259-test-ci-ln-i9t67s2-latest   True        False         121m    Cluster version is 4.21.0-0-2025-10-30-013259-test-ci-ln-i9t67s2-latest
$ oc get crd consoleplugins.console.openshift.io -o json | jq .status.storedVersions
[
  "v1"
]

/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 30, 2025
@openshift-ci-robot
Copy link
Contributor

@yapei: This PR has been marked as verified by @yapei.

In response to this:

==== initial 419
$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.19.17   True        False         28m     Cluster version is 4.19.17

$ oc edit crd consoleplugins.console.openshift.io --subresource status
customresourcedefinition.apiextensions.k8s.io/consoleplugins.console.openshift.io edited


$ oc get crd consoleplugins.console.openshift.io -o json | jq .status.storedVersions
[
 "v1",
 "v1alpha1"
]

==== upgraded to 420
$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.20.1    True        False         125m    Cluster version is 4.20.1

$ oc get crd consoleplugins.console.openshift.io -o json | jq .status.storedVersions
[
 "v1",
 "v1alpha1"
]

==== upgraded to 421
$ 
$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.21.0-0-2025-10-30-013259-test-ci-ln-i9t67s2-latest   True        False         121m    Cluster version is 4.21.0-0-2025-10-30-013259-test-ci-ln-i9t67s2-latest
$ oc get crd consoleplugins.console.openshift.io -o json | jq .status.storedVersions
[
 "v1"
]

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yapei
Copy link
Contributor

yapei commented Oct 30, 2025

/retest-required

@jhadvig
Copy link
Member Author

jhadvig commented Nov 3, 2025

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Nov 3, 2025

Overriding flaking tests
/override ci/prow/e2e-aws-console

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-aws-console

In response to this:

Overriding flaking tests
/override ci/prow/e2e-aws-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhadvig jhadvig changed the title OCPBUGS-52556: Remove SVM console instance if v1alpha1 ConsolePlugin version in present in the CRDs status OCPBUGS-64601: Remove SVM console instance if v1alpha1 ConsolePlugin version in present in the CRDs status Nov 3, 2025
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-64601, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the console-plugin-storage-version-migration SVM succeeds we need to remove the ConsolePlugin CRD's status.storedVersions v1alpha1 entry and leave just v1 version.
Implemented retry in case the SVM status condition is not successful, which eventually will leave in SVM deletion, which will kick off its recreation by CVO.

RBAC: Adding patch permissions for the consoleplugins.console.openshift.io CRD.

/assign @TheRealJon @Leo6Leo

@yapei FYI

4.20 backport for testing purposes - #1060

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig
Copy link
Member Author

jhadvig commented Nov 3, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 3, 2025
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-64601, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei November 3, 2025 16:12
@openshift-merge-bot openshift-merge-bot bot merged commit 0bd8bdd into openshift:main Nov 3, 2025
11 checks passed
@openshift-ci-robot
Copy link
Contributor

@jhadvig: Jira Issue Verification Checks: Jira Issue OCPBUGS-64601
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-64601 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

If the console-plugin-storage-version-migration SVM succeeds we need to remove the ConsolePlugin CRD's status.storedVersions v1alpha1 entry and leave just v1 version.
Implemented retry in case the SVM status condition is not successful, which eventually will leave in SVM deletion, which will kick off its recreation by CVO.

RBAC: Adding patch permissions for the consoleplugins.console.openshift.io CRD.

/assign @TheRealJon @Leo6Leo

@yapei FYI

4.20 backport for testing purposes - #1060

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@jhadvig: Jira Issue OCPBUGS-64601 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants