MCO-1999: align extended tests code with private repo. Pointers and pe… #5453
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@sergiordlr: This pull request references MCO-1999 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-2of2 |
|
@sergiordlr: trigger 9 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dece9330-cc52-11f0-8f07-1763188f6c11-0 |
sergiordlr
changed the title
test/extended-priv/events.go
Outdated
| events, ok := actual.([]*Event) | ||
| if !ok { | ||
| return false, fmt.Errorf("HaveSequence matcher expects a slice of Events in test case %v", g.CurrentSpecReport().FullText()) | ||
| return false, fmt.Errorf("HaveSequence matcher expects a slice of []*Event in test case %v", g.CurrentSpecReport().FullText()) |
There was a problem hiding this comment.
nit: a "a slice of []*Event " is [][]*Event. I think the original form but with the pointer was what you wanted *Event
There was a problem hiding this comment.
Fixed. Thank you!
…rmissions in lists
sergiordlr
force-pushed
the
mco_1999_pointers_and_permissions_in_lists
branch
from
37c7efc to
8b17be5
Compare
isabella-janssen
left a comment
isabella-janssen
left a comment
There was a problem hiding this comment.
/lgtm
Changes look fair and previous review comment has been addressed.
/verified by @isabella-janssen
I looked at the payload rehearsals and the tests are performing as expected, so this should be safe to merge.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, sergiordlr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override ci/prow/e2e-hypershift These test updates do not impact hypershift. |
|
@isabella-janssen: Overrode contexts on behalf of isabella-janssen: ci/prow/e2e-hypershift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/verified by @isabella-janssen I looked at the payload rehearsals and the tests are performing as expected, so this should be safe to merge. I'm not sure why the bot didn't catch this from my previous comment. 🤔 |
openshift-ci-robot
added
the
verified
|
@isabella-janssen: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/label acknowledge-critical-fixes-only Since the PR does not touch MCO code we can merge it now. |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
@sergiordlr: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit f33b415
into
openshift:main
4 participants
…rmissions in lists
- What I did
Modify the extended tests code so that it is aligned with the private tests code.
Modifications:
- How to verify it
All tests should pass
- Description for the changelog