Skip to content

Commit 9e1d4ff

Browse files
committed
Allow three long term flaky k8s tests to retry
We attempted fixing in 4.20 but couldn't quite make it. All are believed related to the kubelet metrics problem. Restoring retries for 4.20 release but the bugs will remain open.
1 parent 33d26ed commit 9e1d4ff

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

pkg/test/ginkgo/cmd_runsuite.go

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,21 @@ func shouldRetryTest(ctx context.Context, test *testCase, permittedRetryImageTag
156156

157157
tlog := logrus.WithField("test", test.name)
158158

159+
// Test retries were disabled for some suites when they moved to OTE. This exposed small numbers of tests that
160+
// were actually flaky and nobody knew. We attempted to fix these, a few did not make it in time. Restore
161+
// retries for specific test names so the overall suite can continue to not retry.
162+
retryTestNames := []string{
163+
"[sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s]", // https://issues.redhat.com/browse/OCPBUGS-57477
164+
"[sig-network] Services should be rejected for evicted pods (no endpoints exist) [Suite:openshift/conformance/parallel] [Suite:k8s]", // https://issues.redhat.com/browse/OCPBUGS-57665
165+
"[sig-node] Pods Extended Pod Container lifecycle evicted pods should be terminal [Suite:openshift/conformance/parallel] [Suite:k8s]", // https://issues.redhat.com/browse/OCPBUGS-57658
166+
}
167+
for _, rtn := range retryTestNames {
168+
if test.name == rtn {
169+
tlog.Debug("test has an exception allowing retry")
170+
return true
171+
}
172+
}
173+
159174
// Get extension info to check if it's from a permitted image
160175
info, err := test.binary.Info(ctx)
161176
if err != nil {

0 commit comments

Comments
 (0)