feat: add NepalTimezoneDate class and integrate with NepaliDate #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj3sh
requested changes
Sep 2, 2025
Member
aj3sh
left a comment
aj3sh
left a comment
There was a problem hiding this comment.
@sajin-shrestha, I have added a few suggestions. Please review them. Also, let's add the tests for this new feature.
sajin-shrestha
force-pushed
the
nepal-timezone-date-class
branch
from
900d5e0 to
21fd14c
Compare
sajin-shrestha
force-pushed
the
nepal-timezone-date-class
branch
from
21fd14c to
92624cf
Compare
aj3sh
reviewed
Nov 12, 2025
| expect(npTz.getHours()).toBe(13) | ||
| expect(npTz.getMinutes()).toBe(53) | ||
| // UTC time should be 8:08 AM | ||
| expect(npTz.toDate().getUTCHours()).toBe(8) |
aj3sh
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #104
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
README.md.Additional Notes
[Add any additional notes or context that you think the reviewers should know about.]
By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.