feat: script_value.h compiled successful

Author: david

bridge/bindings/v8/base/memory/scoped_refptr.h

@@ -344,7 +344,7 @@ class TRIVIAL_ABI scoped_refptr {
   // RAW_PTR_EXCLUSION: scoped_refptr<> has its own UaF prevention mechanism.
   // Given how widespread it is, we it'll likely a perf regression for no
   // additional security benefit.
-  RAW_PTR_EXCLUSION T* ptr_ = nullptr;
+  T* ptr_ = nullptr;
 
  private:
   template <typename U>

bridge/bindings/v8/gin/public/context_holder.h

@@ -44,7 +44,7 @@ class GIN_EXPORT ContextHolder {
   void SetContext(v8::Local<v8::Context> context);
 
  private:
-  raw_ptr<v8::Isolate> isolate_;
+  v8::Isolate *isolate_;
   v8::UniquePersistent<v8::Context> context_;
   std::unique_ptr<PerContextData> data_;
 };

bridge/bindings/v8/platform/heap/member.h

@@ -11,6 +11,7 @@
 #include "bindings/v8/platform/heap/persistent.h"
 #include "bindings/v8/platform/wtf/hash_traits.h"
 #include "bindings/v8/platform/heap/write_barrier.h"
+#include "foundation/macros.h"
 
 namespace webf {
 
@@ -37,19 +38,19 @@ constexpr auto kMemberDeletedValue = cppgc::kSentinelPointer;
 
 template <typename T>
 struct ThreadingTrait<Member<T>> {
-  STATIC_ONLY(ThreadingTrait);
+  WEBF_STATIC_ONLY(ThreadingTrait);
   static constexpr ThreadAffinity kAffinity = ThreadingTrait<T>::kAffinity;
 };
 
 template <typename T>
 struct ThreadingTrait<WeakMember<T>> {
-  STATIC_ONLY(ThreadingTrait);
+  WEBF_STATIC_ONLY(ThreadingTrait);
   static constexpr ThreadAffinity kAffinity = ThreadingTrait<T>::kAffinity;
 };
 
 template <typename T>
 struct ThreadingTrait<UntracedMember<T>> {
-  STATIC_ONLY(ThreadingTrait);
+  WEBF_STATIC_ONLY(ThreadingTrait);
   static constexpr ThreadAffinity kAffinity = ThreadingTrait<T>::kAffinity;
 };
 
@@ -74,7 +75,7 @@ static_assert(kBlinkMemberGCHasDebugChecks ||
 
 template <typename T>
 struct IsTraceable<Member<T>> {
-  STATIC_ONLY(IsTraceable);
+  WEBF_STATIC_ONLY(IsTraceable);
   static const bool value = true;
 };
 
@@ -83,7 +84,7 @@ struct IsWeak<WeakMember<T>> : std::true_type {};
 
 template <typename T>
 struct IsTraceable<WeakMember<T>> {
-  STATIC_ONLY(IsTraceable);
+  WEBF_STATIC_ONLY(IsTraceable);
   static const bool value = true;
 };
 
@@ -92,7 +93,7 @@ struct IsTraceable<WeakMember<T>> {
 // directly with any of those types.
 template <typename T>
 class ValuePeeker final {
-  DISALLOW_NEW();
+  WEBF_DISALLOW_NEW();
 
  public:
   // NOLINTNEXTLINE
@@ -131,7 +132,7 @@ class ValuePeeker final {
 // Default hash for hash tables with Member<>-derived elements.
 template <typename T, typename MemberType>
 struct BaseMemberHashTraits : SimpleClassHashTraits<MemberType> {
-  STATIC_ONLY(BaseMemberHashTraits);
+  WEBF_STATIC_ONLY(BaseMemberHashTraits);
 
   // Heap hash containers allow to operate with raw pointers, e.g.
   //   HeapHashSet<Member<GCed>> set;
@@ -198,22 +199,22 @@ struct HashTraits<webf::UntracedMember<T>> : UntracedMemberHashTraits<T> {};
 
 template <typename T>
 class MemberConstructTraits {
-  STATIC_ONLY(MemberConstructTraits);
+  WEBF_STATIC_ONLY(MemberConstructTraits);
 
  public:
   template <typename... Args>
   static T* Construct(void* location, Args&&... args) {
     // `Construct()` creates a new Member which must not be visible to the
     // concurrent marker yet, similar to regular ctors in Member.
-    return new (NotNullTag::kNotNull, location) T(std::forward<Args>(args)...);
+    return new (base::NotNullTag::kNotNull, location) T(std::forward<Args>(args)...);
   }
 
   template <typename... Args>
   static T* ConstructAndNotifyElement(void* location, Args&&... args) {
     // `ConstructAndNotifyElement()` updates an existing Member which might
     // also be concurrently traced while we update it. The regular ctors
     // for Member don't use an atomic write which can lead to data races.
-    T* object = new (NotNullTag::kNotNull, location)
+    T* object = new (base::NotNullTag::kNotNull, location)
         T(std::forward<Args>(args)..., typename T::AtomicInitializerTag());
     NotifyNewElement(object);
     return object;

bridge/bindings/v8/platform/heap/persistent.h

@@ -13,6 +13,7 @@
 #include "bindings/v8/platform/heap/heap_buildflags.h"
 #include "bindings/v8/platform/wtf/vector_traits.h"
 #include "bindings/v8/platform/wtf/hash_traits.h"
+#include "foundation/macros.h"
 
 // Required to optimize away locations for builds that do not need them to avoid
 // binary size blowup.
@@ -75,7 +76,7 @@ namespace webf {
 
 template <typename T>
 struct PersistentVectorTraitsBase : VectorTraitsBase<T> {
-  STATIC_ONLY(PersistentVectorTraitsBase);
+  WEBF_STATIC_ONLY(PersistentVectorTraitsBase);
   static const bool kCanInitializeWithMemset = true;
 };
 

bridge/bindings/v8/platform/heap/self_keep_alive.h

@@ -40,7 +40,7 @@ namespace webf {
 // implementation of the object.
 template <typename Self>
 class SelfKeepAlive final {
-  DISALLOW_NEW();
+  WEBF_DISALLOW_NEW();
 
  public:
   explicit SelfKeepAlive(

bridge/bindings/v8/platform/heap/write_barrier.h

@@ -12,11 +12,12 @@
 #include <v8/cppgc/member.h>
 #include <v8/cppgc/heap-consistency.h>
 #include "bindings/v8/platform/wtf/type_traits.h"
+#include "foundation/macros.h"
 
 namespace webf {
 
 class WriteBarrier final {
-  STATIC_ONLY(WriteBarrier);
+  WEBF_STATIC_ONLY(WriteBarrier);
 
   using HeapConsistency = cppgc::subtle::HeapConsistency;
 

bridge/bindings/v8/platform/wtf/hash_traits.h

@@ -18,6 +18,9 @@
 #include "bindings/v8/platform/wtf/type_traits.h"
 #include "bindings/v8/platform/wtf/hash_functions.h"
 #include "bindings/v8/platform/wtf/hash_table_deleted_value_type.h"
+#include "foundation/macros.h"
+#include "bindings/v8/base/memory/stack_allocated.h"
+#include "bindings/v8/base/memory/scoped_refptr.h"
 
 namespace webf {
 
@@ -62,7 +65,7 @@ namespace internal {
 
 template <typename T>
 struct GenericHashTraitsBase {
-  STATIC_ONLY(GenericHashTraitsBase);
+  WEBF_STATIC_ONLY(GenericHashTraitsBase);
 
   using TraitType = T;
 
@@ -275,7 +278,7 @@ struct GenericHashTraits<scoped_refptr<P>>
   static bool Equal(const scoped_refptr<P>& a, P* b) { return a == b; }
 
   class RefPtrValuePeeker {
-    DISALLOW_NEW();
+    WEBF_DISALLOW_NEW();
 
    public:
     ALWAYS_INLINE RefPtrValuePeeker(P* p) : ptr_(p) {}
@@ -346,7 +349,7 @@ struct GenericHashTraits<std::unique_ptr<T>>
   static void ConstructDeletedValue(std::unique_ptr<T>& slot) {
     // Dirty trick: implant an invalid pointer to unique_ptr. Destructor isn't
     // called for deleted buckets, so this is okay.
-    new (NotNullTag::kNotNull, &slot)
+    new (base::NotNullTag::kNotNull, &slot)
         std::unique_ptr<T>(reinterpret_cast<T*>(1u));
   }
   static bool IsDeletedValue(const std::unique_ptr<T>& value) {
@@ -385,7 +388,7 @@ struct SimpleClassHashTraits : GenericHashTraits<T> {
     static constexpr bool value = false;
   };
   static void ConstructDeletedValue(T& slot) {
-    new (NotNullTag::kNotNull, &slot) T(kHashTableDeletedValue);
+    new (base::NotNullTag::kNotNull, &slot) T(kHashTableDeletedValue);
   }
   static bool IsDeletedValue(const T& value) {
     return value.IsHashTableDeletedValue();
@@ -422,7 +425,7 @@ struct HashTraitsDeletedValueHelper {
     return value == Traits::DeletedValue();
   }
   static void ConstructDeletedValue(typename Traits::TraitType& slot) {
-    new (NotNullTag::kNotNull, &slot)
+    new (base::NotNullTag::kNotNull, &slot)
         typename Traits::TraitType(Traits::DeletedValue());
   }
 };

bridge/bindings/v8/script_value.h

@@ -13,18 +13,19 @@
 #include "dictionary_base.h"
 #include "foundation/macros.h"
 #include "foundation/native_string.h"
-//#include "platform/script_state.h"
+#include "platform/script_state.h"
 #include "union_base.h"
 //#include "bindings/v8/platform/wtf/vector_traits.h"
 //#include "script_wrappable.h"
 #include "foundation/macros.h"
+#include "bindings/v8/trace_wrapper_v8_reference.h"
 
 namespace webf {
 namespace bindings {
 class DictionaryBase;
 class UnionBase;
 }  // namespace bindings
-//class ScriptState;
+class ScriptState;
 
 // ScriptValue is used when an idl specifies the type as 'any'. ScriptValue
 // stores the v8 value using WorldSafeV8Reference.
@@ -139,7 +140,7 @@ class ScriptValue final {
   // Returns v8Value() if a given ScriptState is the same as the
   // ScriptState which is associated with this ScriptValue. Otherwise
   // this "clones" the v8 value and returns it.
-//  v8::Local<v8::Value> V8ValueFor(ScriptState*) const;
+  v8::Local<v8::Value> V8ValueFor(ScriptState*) const;
 
   bool ToString(AtomicString&) const;