fix: wait for pods to be ready before port-forwarding in MetricsHandlingE2E (#3210)

Replace one-shot pod lookup with an awaitility-based readiness wait (up to 3 minutes)
to avoid IllegalStateException when pods are not yet scheduled after observability
stack installation.

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: csviri

sample-operators/metrics-processing/src/test/java/io/javaoperatorsdk/operator/sample/metrics/MetricsHandlingE2E.java

@@ -22,6 +22,8 @@
 import java.time.Duration;
 import java.util.ArrayDeque;
 import java.util.Deque;
+import java.util.Optional;
+import java.util.concurrent.atomic.AtomicReference;
 
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
@@ -31,6 +33,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import io.fabric8.kubernetes.api.model.Pod;
 import io.fabric8.kubernetes.client.CustomResource;
 import io.fabric8.kubernetes.client.KubernetesClient;
 import io.fabric8.kubernetes.client.KubernetesClientBuilder;
@@ -81,15 +84,14 @@ class MetricsHandlingE2E {
               .build();
 
   @BeforeAll
-  void setupObservability() throws InterruptedException {
+  void setupObservability() {
     log.info("Setting up observability stack...");
     installObservabilityServices();
     prometheusPortForward = portForward(NAME_LABEL_KEY, "prometheus", PROMETHEUS_PORT);
     if (isLocal()) {
       otelCollectorPortForward =
           portForward(NAME_LABEL_KEY, "otel-collector-collector", OTEL_COLLECTOR_PORT);
     }
-    Thread.sleep(2000);
   }
 
   @AfterAll
@@ -99,25 +101,43 @@ void cleanup() throws IOException {
   }
 
   private LocalPortForward portForward(String labelKey, String labelValue, int port) {
+    log.info("Waiting for pod with label {}={} to be ready...", labelKey, labelValue);
+    AtomicReference<Pod> portForwardPod = new AtomicReference<>();
+
+    await()
+        .atMost(Duration.ofMinutes(15))
+        .pollInterval(Duration.ofSeconds(10))
+        .untilAsserted(
+            () -> {
+              var pod = findReadyPod(labelKey, labelValue);
+              assertThat(pod).isPresent();
+              portForwardPod.set(pod.orElseThrow());
+            });
+    var pod = portForwardPod.get();
+    log.info(
+        "Pod {} is ready, establishing port-forward on port {}", pod.getMetadata().getName(), port);
+    return client
+        .pods()
+        .inNamespace(OBSERVABILITY_NAMESPACE)
+        .withName(pod.getMetadata().getName())
+        .portForward(port, port);
+  }
+
+  private Optional<Pod> findReadyPod(String labelKey, String labelValue) {
     return client
         .pods()
         .inNamespace(OBSERVABILITY_NAMESPACE)
         .withLabel(labelKey, labelValue)
         .list()
         .getItems()
         .stream()
-        .findFirst()
-        .map(
+        .filter(
             pod ->
-                client
-                    .pods()
-                    .inNamespace(OBSERVABILITY_NAMESPACE)
-                    .withName(pod.getMetadata().getName())
-                    .portForward(port, port))
-        .orElseThrow(
-            () ->
-                new IllegalStateException(
-                    "Pod not found for label " + labelKey + "=" + labelValue));
+                pod.getStatus() != null
+                    && pod.getStatus().getConditions() != null
+                    && pod.getStatus().getConditions().stream()
+                        .anyMatch(c -> "Ready".equals(c.getType()) && "True".equals(c.getStatus())))
+        .findFirst();
   }
 
   private void closePortForward(LocalPortForward pf) throws IOException {