Fix type-o in test name. (#6086)

* Fix type-o in test name.

I've also fixed a few other type-o's and spelling mistakes.

Signed-off-by: David Lanouette <[email protected]>

* Run go build -gcflags "all=-trimpath=/Users/dlanouet/code/opensource/operator-framework" -asmflags "all=-trimpath=/Users/dlanouet/code/opensource/operator-framework" -ldflags " -X 'github.com/operator-framework/operator-sdk/internal/version.Version=v1.24.0+git' -X 'github.com/operator-framework/operator-sdk/internal/version.GitVersion=v1.24.0-9-g2181a063-dirty' -X 'github.com/operator-framework/operator-sdk/internal/version.GitCommit=2181a063d750e4648b676950fcabe1a3baf3f8ae' -X 'github.com/operator-framework/operator-sdk/internal/version.KubernetesVersion=v1.25.0' -X 'github.com/operator-framework/operator-sdk/internal/version.ImageVersion=v1.24.0' "  -o build ./cmd/{operator-sdk,ansible-operator,helm-operator}
rm -rf testdata
go run ./hack/generate/cncf-maintainers/main.go
go run ./hack/generate/cli-doc/gen-cli-doc.go
go run ./hack/generate/samples/generate_testdata.go
running: docker rmi -f quay.io/example/memcached-operator:v0.0.1
warning: docker rmi -f quay.io/example/memcached-operator:v0.0.1 failed with error: (chdir /Users/dlanouet/code/opensource/operator-framework/operator-sdk/testdata/helm/memcached-operator: no such file or directory)
cleaning up tools
preparing testing directory: /Users/dlanouet/code/opensource/operator-framework/operator-sdk/testdata/helm/memcached-operator
running: operator-sdk init --plugins helm --domain example.com --group cache --version v1alpha1 --kind Memcached --helm-chart ../../../hack/generate/samples/internal/helm/testdata/memcached-0.0.2.tgz
running: make bundle IMG=quay.io/example/memcached-operator:v0.0.1
running: docker rmi -f quay.io/example/memcached-operator:v0.0.1
warning: docker rmi -f quay.io/example/memcached-operator:v0.0.1 failed with error: (chdir /Users/dlanouet/code/opensource/operator-framework/operator-sdk/testdata/ansible/memcached-operator: no such file or directory)
cleaning up tools
preparing testing directory: /Users/dlanouet/code/opensource/operator-framework/operator-sdk/testdata/ansible/memcached-operator
running: operator-sdk init --plugins ansible --group cache --version v1alpha1 --kind Memcached --domain example.com --generate-role --generate-playbook
running: make bundle IMG=quay.io/example/memcached-operator:v0.0.1
running: docker rmi -f quay.io/example/memcached-operator:v0.0.1
warning: docker rmi -f quay.io/example/memcached-operator:v0.0.1 failed with error: (chdir /Users/dlanouet/code/opensource/operator-framework/operator-sdk/testdata/go/v3/memcached-operator: no such file or directory)
cleaning up tools
preparing testing directory: /Users/dlanouet/code/opensource/operator-framework/operator-sdk/testdata/go/v3/memcached-operator
running: operator-sdk init --plugins go/v3 --project-version 3 --repo github.com/example/memcached-operator --domain example.com
running: operator-sdk create api --group cache --version v1alpha1 --kind Memcached --plugins deploy-image/v1-alpha --image memcached:1.4.36-alpine --image-container-command memcached,-m=64,-o,modern,-v --image-container-port 11211 --run-as-user 1001 --make=false --manifests=false
running: operator-sdk create webhook --group cache --version v1alpha1 --kind Memcached --defaulting --defaulting
running: go mod tidy
running: make bundle IMG=quay.io/example/memcached-operator:v0.0.1
running: make fmt
running: docker rmi -f quay.io/example/memcached-operator:v0.0.1
warning: docker rmi -f quay.io/example/memcached-operator:v0.0.1 failed with error: (chdir /Users/dlanouet/code/opensource/operator-framework/operator-sdk/testdata/go/v4-alpha/memcached-operator: no such file or directory)
cleaning up tools
preparing testing directory: /Users/dlanouet/code/opensource/operator-framework/operator-sdk/testdata/go/v4-alpha/memcached-operator
running: operator-sdk init --plugins go/v3 --project-version 3 --repo github.com/example/memcached-operator --domain example.com
running: operator-sdk create api --group cache --version v1alpha1 --kind Memcached --plugins deploy-image/v1-alpha --image memcached:1.4.36-alpine --image-container-command memcached,-m=64,-o,modern,-v --image-container-port 11211 --run-as-user 1001 --make=false --manifests=false
running: operator-sdk create webhook --group cache --version v1alpha1 --kind Memcached --defaulting --defaulting
running: go mod tidy
running: make bundle IMG=quay.io/example/memcached-operator:v0.0.1
running: make fmt
go generate ./... to update test data

Signed-off-by: David Lanouette <[email protected]>

Signed-off-by: David Lanouette <[email protected]>

Author: davidlanouette

hack/generate/samples/internal/go/memcached-with-webhooks/e2e_test_code.go

@@ -14,11 +14,11 @@ import (
 func (mh *Memcached) implementingE2ETests() {
 	log.Infof("implementing example e2e tests")
 
-	// testdDir is testdata/go/v3/memcached-operator/test
+	// testDir is testdata/go/v3/memcached-operator/test
 	testDir := filepath.Join(mh.ctx.Dir, "test")
 	// testE2eDir is testdata/go/v3/memcached-operator/test/e2e
 	testE2eDir := filepath.Join(testDir, "e2e")
-	// testE2eDir is testdata/go/v3/memcached-operator/test/utils
+	// testUtilsDir is testdata/go/v3/memcached-operator/test/utils
 	testUtilsDir := filepath.Join(testDir, "utils")
 
 	// Following we will create the directories
@@ -29,10 +29,10 @@ func (mh *Memcached) implementingE2ETests() {
 	mh.addContent(testE2eDir, testUtilsDir)
 
 	// Add a target to run the tests into the Makefile
-	mh.addTestE2eMaekefileTarget()
+	mh.addTestE2eMakefileTarget()
 }
 
-func (mh *Memcached) addTestE2eMaekefileTarget() {
+func (mh *Memcached) addTestE2eMakefileTarget() {
 	err := kbutil.ReplaceInFile(filepath.Join(mh.ctx.Dir, "Makefile"),
 		`KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test ./... -coverprofile cover.out`,
 		`KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)"  go test $(go list ./... | grep -v /test/) -coverprofile cover.out`,
@@ -176,17 +176,17 @@ var _ = Describe("memcached", func() {
 			Expect(utils.InstallCertManager()).To(Succeed())
 
 			// The namespace can be created when we run make install
-			// However, in this test we want ensure that the solution 
+			// However, in this test we want to ensure that the solution 
 			// can run in a ns labeled as restricted. Therefore, we are
-            // creating the namespace an lebeling it. 
+            // creating the namespace and labeling it. 
 			By("creating manager namespace")
 			cmd := exec.Command("kubectl", "create", "ns", namespace)
 			_, _ = utils.Run(cmd)
 
-			// Now, let's ensure that all namespaces can raise an Warn when we apply the manifests
+			// Now, let's ensure that all namespaces can raise a Warn when we apply the manifests
             // and that the namespace where the Operator and Operand will run are enforced as 
             // restricted so that we can ensure that both can be admitted and run with the enforcement
-			By("labeling all namespaces to warn when we apply the manifest if would violate the PodStandards")
+			By("labeling all namespaces to warn when we apply the manifest if it would violate the PodStandards")
 			cmd = exec.Command("kubectl", "label", "--overwrite", "ns", "--all",
 				"pod-security.kubernetes.io/audit=restricted",
 				"pod-security.kubernetes.io/enforce-version=v1.24",
@@ -376,7 +376,7 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
 	fmt.Fprintf(GinkgoWriter, "running dir: %s\n", cmd.Dir)
 
 	// To allow make commands be executed from the project directory which is subdir on SDK repo
-	// TODO:(user) You might does not need the following code
+	// TODO:(user) You might not need the following code
 	if err := os.Chdir(cmd.Dir); err != nil {
 		fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
 	}

testdata/go/v3/memcached-operator/test/e2e/e2e_test.go

@@ -51,17 +51,17 @@ var _ = Describe("memcached", func() {
 			Expect(utils.InstallCertManager()).To(Succeed())
 
 			// The namespace can be created when we run make install
-			// However, in this test we want ensure that the solution
+			// However, in this test we want to ensure that the solution
 			// can run in a ns labeled as restricted. Therefore, we are
-			// creating the namespace an lebeling it.
+			// creating the namespace and labeling it.
 			By("creating manager namespace")
 			cmd := exec.Command("kubectl", "create", "ns", namespace)
 			_, _ = utils.Run(cmd)
 
-			// Now, let's ensure that all namespaces can raise an Warn when we apply the manifests
+			// Now, let's ensure that all namespaces can raise a Warn when we apply the manifests
 			// and that the namespace where the Operator and Operand will run are enforced as
 			// restricted so that we can ensure that both can be admitted and run with the enforcement
-			By("labeling all namespaces to warn when we apply the manifest if would violate the PodStandards")
+			By("labeling all namespaces to warn when we apply the manifest if it would violate the PodStandards")
 			cmd = exec.Command("kubectl", "label", "--overwrite", "ns", "--all",
 				"pod-security.kubernetes.io/audit=restricted",
 				"pod-security.kubernetes.io/enforce-version=v1.24",

testdata/go/v3/memcached-operator/test/utils/utils.go

@@ -53,7 +53,7 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
 	fmt.Fprintf(GinkgoWriter, "running dir: %s\n", cmd.Dir)
 
 	// To allow make commands be executed from the project directory which is subdir on SDK repo
-	// TODO:(user) You might does not need the following code
+	// TODO:(user) You might not need the following code
 	if err := os.Chdir(cmd.Dir); err != nil {
 		fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
 	}

testdata/go/v4-alpha/memcached-operator/test/e2e/e2e_test.go

@@ -51,17 +51,17 @@ var _ = Describe("memcached", func() {
 			Expect(utils.InstallCertManager()).To(Succeed())
 
 			// The namespace can be created when we run make install
-			// However, in this test we want ensure that the solution
+			// However, in this test we want to ensure that the solution
 			// can run in a ns labeled as restricted. Therefore, we are
-			// creating the namespace an lebeling it.
+			// creating the namespace and labeling it.
 			By("creating manager namespace")
 			cmd := exec.Command("kubectl", "create", "ns", namespace)
 			_, _ = utils.Run(cmd)
 
-			// Now, let's ensure that all namespaces can raise an Warn when we apply the manifests
+			// Now, let's ensure that all namespaces can raise a Warn when we apply the manifests
 			// and that the namespace where the Operator and Operand will run are enforced as
 			// restricted so that we can ensure that both can be admitted and run with the enforcement
-			By("labeling all namespaces to warn when we apply the manifest if would violate the PodStandards")
+			By("labeling all namespaces to warn when we apply the manifest if it would violate the PodStandards")
 			cmd = exec.Command("kubectl", "label", "--overwrite", "ns", "--all",
 				"pod-security.kubernetes.io/audit=restricted",
 				"pod-security.kubernetes.io/enforce-version=v1.24",

testdata/go/v4-alpha/memcached-operator/test/utils/utils.go

@@ -53,7 +53,7 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
 	fmt.Fprintf(GinkgoWriter, "running dir: %s\n", cmd.Dir)
 
 	// To allow make commands be executed from the project directory which is subdir on SDK repo
-	// TODO:(user) You might does not need the following code
+	// TODO:(user) You might not need the following code
 	if err := os.Chdir(cmd.Dir); err != nil {
 		fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
 	}