Move object commands into own package (#935)

The CRUD command files (create, delete, get, update) and their shared
utilities lived in a generic "commands" directory that didn't convey
what they were for. Since they all belong to the "infrahubctl object"
subgroup, it makes sense to colocate them as an "object" package.

Test files follow the same restructuring.

Author: gmazoyer

dev/knowledge/cli-architecture.md

@@ -21,11 +21,23 @@ For a **root command**, define the function in the appropriate module and regist
 app.command(name="mycommand")(my_function)
 ```
 
-For a **subcommand**, add it to the relevant group's module. For example, object subcommands go in `infrahub_sdk/ctl/object.py` or in dedicated files under `infrahub_sdk/ctl/commands/` and are registered on the object app.
+For a **subcommand**, add it to the relevant group's package or module. For example, object subcommands live in `infrahub_sdk/ctl/object/` and are registered on the object app in `__init__.py`.
 
-## The `commands/` directory
+## Group packages
 
-`infrahub_sdk/ctl/commands/` contains modular command implementations that are imported and registered on a group app. This keeps individual command logic separated from the group wiring. Shared utilities live in `commands/utils.py`.
+When a subcommand group has multiple commands, it lives as a package (directory with `__init__.py`) rather than a single module file. The `object` group is the reference example:
+
+```text
+infrahub_sdk/ctl/object/
+├── __init__.py    # App, callback, load/validate commands, registers CRUD
+├── create.py      # create subcommand
+├── delete.py      # delete subcommand
+├── get.py         # get subcommand
+├── update.py      # update subcommand
+└── utils.py       # Shared utilities (resolve_node, etc.)
+```
+
+Each command file contains a single command function. Shared logic goes in `utils.py`. The `__init__.py` wires everything together by importing and registering commands on the group's `AsyncTyper` app. Other groups that grow beyond a single file should follow this same pattern.
 
 ## Decorators
 

infrahub_sdk/ctl/commands/__init__.py

@@ -4,21 +4,22 @@
 import typer
 from rich.console import Console
 
-from ..async_typer import AsyncTyper
-from ..ctl.client import initialize_client
-from ..ctl.utils import catch_exception, init_logging
-from ..exceptions import ObjectValidationError, ValidationError
-from ..spec.object import ObjectFile
-from .commands.create import create_command
-from .commands.delete import delete_command
-from .commands.get import get_command
-from .commands.update import update_command
-from .parameters import CONFIG_PARAM
-from .utils import (
+from infrahub_sdk.async_typer import AsyncTyper
+from infrahub_sdk.ctl.client import initialize_client
+from infrahub_sdk.ctl.object.create import create_command
+from infrahub_sdk.ctl.object.delete import delete_command
+from infrahub_sdk.ctl.object.get import get_command
+from infrahub_sdk.ctl.object.update import update_command
+from infrahub_sdk.ctl.parameters import CONFIG_PARAM
+from infrahub_sdk.ctl.utils import (
+    catch_exception,
     display_object_validate_format_error,
     display_object_validate_format_success,
+    init_logging,
     load_yamlfile_from_disk_and_exit,
 )
+from infrahub_sdk.exceptions import ObjectValidationError, ValidationError
+from infrahub_sdk.spec.object import ObjectFile
 
 app = AsyncTyper()
 console = Console()

infrahub_sdk/ctl/object.py infrahub_sdk/ctl/object/__init__.pyinfrahub_sdk/ctl/object.py renamed to infrahub_sdk/ctl/object/__init__.py

@@ -13,7 +13,7 @@
 from rich.console import Console
 
 from infrahub_sdk.ctl.client import initialize_client
-from infrahub_sdk.ctl.commands.utils import derive_identifier, prepare_relationship_data, resolve_node
+from infrahub_sdk.ctl.object.utils import derive_identifier, prepare_relationship_data, resolve_node
 from infrahub_sdk.ctl.parameters import CONFIG_PARAM
 from infrahub_sdk.ctl.parsers import parse_set_args, validate_set_fields
 from infrahub_sdk.ctl.utils import catch_exception

infrahub_sdk/ctl/commands/create.py infrahub_sdk/ctl/object/create.pyinfrahub_sdk/ctl/commands/create.py renamed to infrahub_sdk/ctl/object/create.py

@@ -9,7 +9,7 @@
 from rich.console import Console
 
 from infrahub_sdk.ctl.client import initialize_client
-from infrahub_sdk.ctl.commands.utils import resolve_node
+from infrahub_sdk.ctl.object.utils import resolve_node
 from infrahub_sdk.ctl.parameters import CONFIG_PARAM
 from infrahub_sdk.ctl.utils import catch_exception
 

infrahub_sdk/ctl/commands/delete.py infrahub_sdk/ctl/object/delete.pyinfrahub_sdk/ctl/commands/delete.py renamed to infrahub_sdk/ctl/object/delete.py

@@ -14,8 +14,8 @@
 from rich.console import Console
 
 from infrahub_sdk.ctl.client import initialize_client
-from infrahub_sdk.ctl.commands.utils import resolve_node
 from infrahub_sdk.ctl.formatters import OutputFormat, detect_output_format, get_formatter
+from infrahub_sdk.ctl.object.utils import resolve_node
 from infrahub_sdk.ctl.parameters import CONFIG_PARAM
 from infrahub_sdk.ctl.parsers import parse_filter_args
 from infrahub_sdk.ctl.utils import catch_exception

infrahub_sdk/ctl/commands/get.py infrahub_sdk/ctl/object/get.pyinfrahub_sdk/ctl/commands/get.py renamed to infrahub_sdk/ctl/object/get.py

@@ -13,7 +13,7 @@
 from rich.console import Console
 
 from infrahub_sdk.ctl.client import initialize_client
-from infrahub_sdk.ctl.commands.utils import prepare_relationship_data, resolve_node
+from infrahub_sdk.ctl.object.utils import prepare_relationship_data, resolve_node
 from infrahub_sdk.ctl.parameters import CONFIG_PARAM
 from infrahub_sdk.ctl.parsers import parse_set_args, validate_set_fields
 from infrahub_sdk.ctl.utils import catch_exception

infrahub_sdk/ctl/commands/update.py infrahub_sdk/ctl/object/update.pyinfrahub_sdk/ctl/commands/update.py renamed to infrahub_sdk/ctl/object/update.py

@@ -49,9 +49,9 @@ def test_create_with_set_args() -> None:
     mock_client.create = AsyncMock(return_value=mock_node)
 
     with (
-        patch("infrahub_sdk.ctl.commands.create.initialize_client", return_value=mock_client),
+        patch("infrahub_sdk.ctl.object.create.initialize_client", return_value=mock_client),
         patch(
-            "infrahub_sdk.ctl.commands.create.resolve_node",
+            "infrahub_sdk.ctl.object.create.resolve_node",
             new_callable=AsyncMock,
             side_effect=NodeNotFoundError(identifier={"name": ["router1"]}),
         ),
@@ -82,9 +82,9 @@ def test_create_with_set_args_and_branch() -> None:
     mock_client.create = AsyncMock(return_value=mock_node)
 
     with (
-        patch("infrahub_sdk.ctl.commands.create.initialize_client", return_value=mock_client),
+        patch("infrahub_sdk.ctl.object.create.initialize_client", return_value=mock_client),
         patch(
-            "infrahub_sdk.ctl.commands.create.resolve_node",
+            "infrahub_sdk.ctl.object.create.resolve_node",
             new_callable=AsyncMock,
             side_effect=NodeNotFoundError(identifier={"name": ["router2"]}),
         ),
@@ -110,9 +110,9 @@ def test_create_with_file() -> None:
     mock_client = MagicMock()
 
     with (
-        patch("infrahub_sdk.ctl.commands.create.initialize_client", return_value=mock_client),
+        patch("infrahub_sdk.ctl.object.create.initialize_client", return_value=mock_client),
         patch(
-            "infrahub_sdk.ctl.commands.create.ObjectFile.load_from_disk",
+            "infrahub_sdk.ctl.object.create.ObjectFile.load_from_disk",
             return_value=[mock_file],
         ),
     ):
@@ -143,9 +143,9 @@ def make_obj_file(kind: str, count: int) -> MagicMock:
     mock_client = MagicMock()
 
     with (
-        patch("infrahub_sdk.ctl.commands.create.initialize_client", return_value=mock_client),
+        patch("infrahub_sdk.ctl.object.create.initialize_client", return_value=mock_client),
         patch(
-            "infrahub_sdk.ctl.commands.create.ObjectFile.load_from_disk",
+            "infrahub_sdk.ctl.object.create.ObjectFile.load_from_disk",
             return_value=[file_a, file_b],
         ),
     ):
@@ -169,9 +169,9 @@ def test_create_with_file_kind_mismatch() -> None:
     mock_client = MagicMock()
 
     with (
-        patch("infrahub_sdk.ctl.commands.create.initialize_client", return_value=mock_client),
+        patch("infrahub_sdk.ctl.object.create.initialize_client", return_value=mock_client),
         patch(
-            "infrahub_sdk.ctl.commands.create.ObjectFile.load_from_disk",
+            "infrahub_sdk.ctl.object.create.ObjectFile.load_from_disk",
             return_value=[mock_file],
         ),
     ):
@@ -191,7 +191,7 @@ def test_create_invalid_field() -> None:
     mock_client.schema = MagicMock()
     mock_client.schema.get = AsyncMock(return_value=mock_schema)
 
-    with patch("infrahub_sdk.ctl.commands.create.initialize_client", return_value=mock_client):
+    with patch("infrahub_sdk.ctl.object.create.initialize_client", return_value=mock_client):
         result = runner.invoke(app, ["object", "create", "InfraDevice", "--set", "nonexistent_field=value"])
 
     assert result.exit_code != 0
@@ -214,9 +214,9 @@ def test_create_multiple_set_args() -> None:
     mock_client.create = AsyncMock(return_value=mock_node)
 
     with (
-        patch("infrahub_sdk.ctl.commands.create.initialize_client", return_value=mock_client),
+        patch("infrahub_sdk.ctl.object.create.initialize_client", return_value=mock_client),
         patch(
-            "infrahub_sdk.ctl.commands.create.resolve_node",
+            "infrahub_sdk.ctl.object.create.resolve_node",
             new_callable=AsyncMock,
             side_effect=NodeNotFoundError(identifier={"name": ["router3"]}),
         ),
@@ -236,7 +236,7 @@ def test_create_malformed_set_arg(bad_arg: str) -> None:
     """Malformed --set arguments (no ``=`` or empty key) exit with a non-zero code."""
     mock_client = MagicMock()
 
-    with patch("infrahub_sdk.ctl.commands.create.initialize_client", return_value=mock_client):
+    with patch("infrahub_sdk.ctl.object.create.initialize_client", return_value=mock_client):
         result = runner.invoke(app, ["object", "create", "InfraDevice", "--set", bad_arg])
 
     assert result.exit_code != 0