Skip to content

Commit 8d89883

Browse files
authored
Merge pull request #470 from opsmill/bkr-remove-node-process-page
Fixes #469
2 parents ec3627f + c67fb29 commit 8d89883

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

changelog/469.fixed.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixes ignored node variable in filters()

infrahub_sdk/client.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -784,7 +784,6 @@ async def filters(
784784
if at:
785785
at = Timestamp(at)
786786

787-
node = InfrahubNode(client=self, schema=schema, branch=branch)
788787
filters = kwargs
789788
pagination_size = self.pagination_size
790789

@@ -830,7 +829,7 @@ async def process_batch() -> tuple[list[InfrahubNode], list[InfrahubNode]]:
830829

831830
for page_number in range(1, total_pages + 1):
832831
page_offset = (page_number - 1) * pagination_size
833-
batch_process.add(task=process_page, node=node, page_offset=page_offset, page_number=page_number)
832+
batch_process.add(task=process_page, page_offset=page_offset, page_number=page_number)
834833

835834
async for _, response in batch_process.execute():
836835
nodes.extend(response[1]["nodes"])
@@ -847,7 +846,7 @@ async def process_non_batch() -> tuple[list[InfrahubNode], list[InfrahubNode]]:
847846

848847
while has_remaining_items:
849848
page_offset = (page_number - 1) * pagination_size
850-
response, process_result = await process_page(page_offset, page_number)
849+
response, process_result = await process_page(page_offset=page_offset, page_number=page_number)
851850

852851
nodes.extend(process_result["nodes"])
853852
related_nodes.extend(process_result["related_nodes"])
@@ -1949,7 +1948,6 @@ def filters(
19491948
if at:
19501949
at = Timestamp(at)
19511950

1952-
node = InfrahubNodeSync(client=self, schema=schema, branch=branch)
19531951
filters = kwargs
19541952
pagination_size = self.pagination_size
19551953

@@ -1996,7 +1994,7 @@ def process_batch() -> tuple[list[InfrahubNodeSync], list[InfrahubNodeSync]]:
19961994

19971995
for page_number in range(1, total_pages + 1):
19981996
page_offset = (page_number - 1) * pagination_size
1999-
batch_process.add(task=process_page, node=node, page_offset=page_offset, page_number=page_number)
1997+
batch_process.add(task=process_page, page_offset=page_offset, page_number=page_number)
20001998

20011999
for _, response in batch_process.execute():
20022000
nodes.extend(response[1]["nodes"])

0 commit comments

Comments
 (0)