IFC-1952 Add generic/attribute relationships in profile schema

This change is relatively simple and just adds relationships of kind generic and kind attribute to profile schemas corresponding to node schemas having these relationships.

When we load a schema, we make sure to clear all the relationships, except the ones of kind PROFILE such as related_nodes, to create a brand new list of relationships which will account for deleted and new ones. This is very similar to what we do for templates already.

Author: gmazoyer

backend/infrahub/core/schema/schema_branch.py

@@ -2149,6 +2149,36 @@ def add_hierarchy_node(self) -> None:
 
             self.set(name=node_name, schema=node)
 
+    def add_relationships_to_profile(self, profile: ProfileSchema, node: NodeSchema | GenericSchema) -> None:
+        # Remove previous relationships to account for new ones
+        profile.relationships = [r for r in profile.relationships if r.kind == RelationshipKind.PROFILE]
+
+        for relationship in node.relationships:
+            if relationship.kind not in [RelationshipKind.ATTRIBUTE, RelationshipKind.GENERIC]:
+                continue
+
+            identifier = (
+                f"profile_{relationship.identifier}"
+                if relationship.identifier
+                else self._generate_identifier_string(profile.kind, relationship.peer)
+            )
+
+            profile.relationships.append(
+                RelationshipSchema(
+                    name=relationship.name,
+                    peer=relationship.peer,
+                    kind=relationship.kind,
+                    cardinality=relationship.cardinality,
+                    direction=relationship.direction,
+                    branch=relationship.branch,
+                    identifier=identifier,
+                    min_count=relationship.min_count,
+                    max_count=relationship.max_count,
+                    label=relationship.label,
+                    inherited=False,
+                )
+            )
+
     def manage_profile_schemas(self) -> None:
         if not self.has(name=InfrahubKind.PROFILE):
             # TODO: This logic is actually only for testing purposes as since 1.0.9 CoreProfile is loaded in db.
@@ -2170,6 +2200,7 @@ def manage_profile_schemas(self) -> None:
                 continue
 
             profile = self.generate_profile_from_node(node=node)
+            self.add_relationships_to_profile(profile=profile, node=node)
             self.set(name=profile.kind, schema=profile)
             profile_schema_kinds.add(profile.kind)
 
@@ -2253,13 +2284,13 @@ def generate_profile_from_node(self, node: NodeSchema) -> ProfileSchema:
         core_name_attr = core_profile_schema.get_attribute(name="profile_name")
         name_attr_schema_class = get_attribute_schema_class_for_kind(kind=core_name_attr.kind)
         profile_name_attr = name_attr_schema_class(
-            **core_name_attr.model_dump(exclude=["id", "inherited"]),
+            **core_name_attr.model_dump(exclude={"id", "inherited"}),
         )
         profile_name_attr.branch = node.branch
         core_priority_attr = core_profile_schema.get_attribute(name="profile_priority")
         priority_attr_schema_class = get_attribute_schema_class_for_kind(kind=core_priority_attr.kind)
         profile_priority_attr = priority_attr_schema_class(
-            **core_priority_attr.model_dump(exclude=["id", "inherited"]),
+            **core_priority_attr.model_dump(exclude={"id", "inherited"}),
         )
         profile_priority_attr.branch = node.branch
         profile = ProfileSchema(
@@ -2292,7 +2323,7 @@ def generate_profile_from_node(self, node: NodeSchema) -> ProfileSchema:
             attr_schema_class = get_attribute_schema_class_for_kind(kind=node_attr.kind)
             attr = attr_schema_class(
                 optional=True,
-                **node_attr.model_dump(exclude=["id", "unique", "optional", "read_only", "default_value", "inherited"]),
+                **node_attr.model_dump(exclude={"id", "unique", "optional", "read_only", "default_value", "inherited"}),
             )
             profile.attributes.append(attr)
 
@@ -2428,9 +2459,7 @@ def generate_object_template_from_node(
         )
         core_name_attr = core_template_schema.get_attribute(name=OBJECT_TEMPLATE_NAME_ATTR)
         name_attr_schema_class = get_attribute_schema_class_for_kind(kind=core_name_attr.kind)
-        template_name_attr = name_attr_schema_class(
-            **core_name_attr.model_dump(exclude=["id", "inherited"]),
-        )
+        template_name_attr = name_attr_schema_class(**core_name_attr.model_dump(exclude={"id", "inherited"}))
         template_name_attr.branch = node.branch
 
         template: TemplateSchema | GenericSchema
@@ -2489,7 +2518,7 @@ def generate_object_template_from_node(
             attr_schema_class = get_attribute_schema_class_for_kind(kind=node_attr.kind)
             attr = attr_schema_class(
                 optional=node_attr.optional if is_autogenerated_subtemplate else True,
-                **node_attr.model_dump(exclude=["id", "unique", "optional", "read_only", "order_weight"]),
+                **node_attr.model_dump(exclude={"id", "unique", "optional", "read_only", "order_weight"}),
             )
             template.attributes.append(attr)
 

backend/tests/unit/core/schema_manager/test_manager_schema.py

@@ -720,8 +720,10 @@ async def test_schema_branch_add_profile_schema(schema_all_in_one) -> None:
     assert node_profile.get_attribute("profile_name").branch == BranchSupportType.AGNOSTIC.value
     assert node_profile.get_attribute("profile_priority").branch == BranchSupportType.AGNOSTIC.value
     assert set(node_profile.attribute_names) == {"profile_name", "profile_priority", "description", "mybool"}
+    assert set(node_profile.relationship_names) == {"badges", "primary_tag", "related_nodes", "status", "tags"}
     generic_profile = schema.get(name="ProfileInfraGenericInterface", duplicate=False)
     assert set(generic_profile.attribute_names) == {"profile_name", "profile_priority", "mybool"}
+    assert set(generic_profile.relationship_names) == {"badges", "primary_tag", "related_nodes", "status"}
     core_profile_schema = schema.get("CoreProfile")
     core_node_schema = schema.get("CoreNode")
     assert set(core_profile_schema.used_by) == {