use hash 2562

Author: LucasG0

backend/infrahub/lock_getter.py

@@ -1,3 +1,5 @@
+import hashlib
+
 from infrahub.core.branch import Branch
 from infrahub.core.constants import InfrahubKind
 from infrahub.core.node import Node
@@ -60,6 +62,12 @@ def _should_kind_be_locked_on_any_branch(kind: str, schema_branch: SchemaBranch)
     return False
 
 
+def _hash(value: str) -> str:
+    # Do not use builtin `hash` for lock names as due to randomization results would differ between
+    # different processes.
+    return hashlib.sha256(value.encode()).hexdigest()
+
+
 def get_lock_names_on_object_mutation(node: Node, branch: Branch, schema_branch: SchemaBranch) -> list[str]:
     """
     Return lock names for object on which we want to avoid concurrent mutation (create/update). Except for some specific kinds,
@@ -99,9 +107,9 @@ def get_lock_names_on_object_mutation(node: Node, branch: Branch, schema_branch:
                 if attr is None or attr.value is None:
                     # `attr.value` being None corresponds to optional unique attribute.
                     # `attr` being None is not supposed to happen.
-                    value_hashed = str(hash(""))
+                    value_hashed = _hash("")
                 else:
-                    value_hashed = str(hash(str(attr.value)))
+                    value_hashed = _hash(str(attr.value))
 
                 uc_attributes_values.append(value_hashed)
 

backend/tests/unit/core/test_get_kinds_lock.py

@@ -5,6 +5,7 @@
 from infrahub.database import InfrahubDatabase
 from infrahub.lock_getter import (
     _get_kinds_to_lock_on_object_mutation,
+    _hash,
     _should_kind_be_locked_on_any_branch,
     get_lock_names_on_object_mutation,
 )
@@ -78,7 +79,7 @@ async def test_lock_names_only_attributes(
         person = await create_and_save(db=db, schema="TestPerson", name="John")
         car = await create_and_save(db=db, schema="TestCar", name="mercedes", color="blue", owner=person)
         assert get_lock_names_on_object_mutation(car, branch=default_branch, schema_branch=schema_branch) == [
-            "global.object.TestCar." + str(hash("mercedes")) + "." + str(hash("blue"))
+            "global.object.TestCar." + _hash("mercedes") + "." + _hash("blue")
         ]
 
     async def test_lock_names_optional_empty_attribute(
@@ -95,5 +96,5 @@ async def test_lock_names_optional_empty_attribute(
         schema_branch = registry.schema.get_schema_branch(name=default_branch.name)
         person = await create_and_save(db=db, schema="TestPerson", name="John")
         assert get_lock_names_on_object_mutation(person, branch=default_branch, schema_branch=schema_branch) == [
-            "global.object.TestPerson." + str(hash("")) + "." + str(hash("John"))
+            "global.object.TestPerson." + _hash("") + "." + _hash("John")
         ]