Skip to content

Conversation

@minitriga
Copy link
Contributor

@minitriga minitriga commented Nov 4, 2025

…ants

Summary by CodeRabbit

  • New Features

    • Complex attribute types (List, JSON, Any) now display as individual badges in table and list views instead of appearing blank, improving visibility.
    • List attribute kind is now included in list views.
  • Tests

    • Updated tests to reflect List attribute visibility in list views.
  • Changelog

    • Added entry noting List attribute kind support in list views.

@minitriga minitriga requested a review from a team as a code owner November 4, 2025 17:56
@github-actions github-actions bot added the group/frontend Issue related to the frontend (React) label Nov 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

Walkthrough

The PR updates attribute rendering and list-view configuration: AttributeKind and AttributeSchema imports in the table attribute cell component were changed to type-only imports. Rendering now displays ATTRIBUTE_KIND.ANY, ATTRIBUTE_KIND.JSON, and ATTRIBUTE_KIND.LIST as horizontal Badge elements (mapping missing values to "-"). ATTRIBUTE_KIND.LIST was added to ATTRIBUTE_KINDS_FOR_LIST_VIEW, and corresponding tests and a changelog entry were updated.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: adding LIST attribute kind support to TableAttributeCell and constants, which aligns with file modifications in table-attribute-cell.tsx, constants.ts, and related test updates.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch atg-20251104-list-view-list

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71f8970 and 7882730.

📒 Files selected for processing (3)
  • changelog/+enable-list-attr-in-list-view.added.md (1 hunks)
  • frontend/app/src/entities/nodes/object/ui/object-table/cells/table-attribute-cell.tsx (3 hunks)
  • frontend/app/src/entities/nodes/object/utils/get-attributes-visible-in-list-view.test.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • changelog/+enable-list-attr-in-list-view.added.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/app/src/entities/nodes/object/ui/object-table/cells/table-attribute-cell.tsx
🧰 Additional context used
📓 Path-based instructions (1)
frontend/{app,packages}/**/*.test.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Place frontend tests alongside components

Files:

  • frontend/app/src/entities/nodes/object/utils/get-attributes-visible-in-list-view.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: E2E-testing-version-upgrade / From 1.3.0
  • GitHub Check: E2E-testing-invoke-demo-start
  • GitHub Check: E2E-testing-playwright
  • GitHub Check: documentation
🔇 Additional comments (1)
frontend/app/src/entities/nodes/object/utils/get-attributes-visible-in-list-view.test.ts (1)

38-53: LGTM! Test correctly reflects the new LIST visibility.

The test expectation now includes "List" in the visible attribute kinds, which accurately reflects the addition of ATTRIBUTE_KIND.LIST to ATTRIBUTE_KINDS_FOR_LIST_VIEW. The test data and assertion are consistent and well-structured.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

import { UrlCell } from "@/entities/nodes/object/ui/object-table/cells/url-cell";
import { ATTRIBUTE_KIND } from "@/entities/schema/constants";
import { AttributeKind, AttributeSchema } from "@/entities/schema/types";
import type { AttributeKind, AttributeSchema } from "@/entities/schema/types";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bilalabbad not sure about this. Biome suggested it when using :fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/frontend Issue related to the frontend (React)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants