Skip to content

Commit 2ef2d2f

Browse files
[FSSDK-12950] datafile field update
1 parent 15b39bb commit 2ef2d2f

4 files changed

Lines changed: 17 additions & 17 deletions

File tree

OptimizelySDK.Tests/DecisionServiceHoldoutTest.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,7 @@ public void TestExcludeTargetedDeliveries_DefaultFalse_HoldoutAppliesNormally()
704704
var decision = result[0].ResultObject;
705705
Assert.IsNotNull(decision);
706706
Assert.AreEqual(FeatureDecision.DECISION_SOURCE_HOLDOUT, decision.Source,
707-
"Global holdout with exclude_targeted_deliveries=false should apply to TD rules");
707+
"Global holdout with excludeTargetedDeliveries=false should apply to TD rules");
708708
}
709709

710710
[Test]
@@ -738,11 +738,11 @@ public void TestExcludeTargetedDeliveries_True_TDRuleEvaluatesNormally()
738738
var decision = result[0].ResultObject;
739739
Assert.IsNotNull(decision);
740740
Assert.AreEqual(FeatureDecision.DECISION_SOURCE_ROLLOUT, decision.Source,
741-
"With exclude_targeted_deliveries=true, TD rules should evaluate normally (not blocked by holdout)");
741+
"With excludeTargetedDeliveries=true, TD rules should evaluate normally (not blocked by holdout)");
742742

743743
var reasons = result[0].DecisionReasons.ToReport(true);
744744
var excludeTDReason = reasons.FirstOrDefault(r =>
745-
r.Contains("has exclude_targeted_deliveries enabled, continuing to rollout evaluation"));
745+
r.Contains("has excludeTargetedDeliveries enabled, continuing to rollout evaluation"));
746746
Assert.IsNotNull(excludeTDReason,
747747
"Reasons should include excludeTargetedDeliveries bypass message");
748748
Assert.IsTrue(excludeTDReason.Contains(globalHoldout.Key),
@@ -781,7 +781,7 @@ public void TestExcludeTargetedDeliveries_True_ABRuleStillBlocked()
781781
Assert.IsNotNull(decision);
782782

783783
Assert.AreNotEqual(FeatureDecision.DECISION_SOURCE_FEATURE_TEST, decision.Source,
784-
"With exclude_targeted_deliveries=true, A/B experiment rules should be skipped (not evaluated)");
784+
"With excludeTargetedDeliveries=true, A/B experiment rules should be skipped (not evaluated)");
785785
Assert.IsNull(decision.Variation,
786786
"Variation should be null since A/B was blocked and no TD rule matched");
787787
Assert.IsNotNull(decision.HoldoutDecision,
@@ -795,12 +795,12 @@ public void TestExcludeTargetedDeliveries_MissingField_DefaultsFalse()
795795

796796
var globalHoldout = NoExcludeTDConfig.GetGlobalHoldouts()[0];
797797
Assert.IsFalse(globalHoldout.ExcludeTargetedDeliveries,
798-
"Missing exclude_targeted_deliveries should default to false");
798+
"Missing excludeTargetedDeliveries should default to false");
799799

800800
foreach (var localHoldout in NoExcludeTDConfig.LocalHoldouts)
801801
{
802802
Assert.IsFalse(localHoldout.ExcludeTargetedDeliveries,
803-
$"Local holdout {localHoldout.Key} should default exclude_targeted_deliveries to false");
803+
$"Local holdout {localHoldout.Key} should default excludeTargetedDeliveries to false");
804804
}
805805
}
806806

@@ -830,7 +830,7 @@ public void TestLocalHoldout_ExcludeTargetedDeliveries_True_StillAppliesForTDRul
830830
var decision = result[0].ResultObject;
831831
Assert.IsNotNull(decision);
832832
Assert.AreEqual(FeatureDecision.DECISION_SOURCE_HOLDOUT, decision.Source,
833-
"Local holdout must apply to TD rules even when exclude_targeted_deliveries=true (flag is only for global holdouts)");
833+
"Local holdout must apply to TD rules even when excludeTargetedDeliveries=true (flag is only for global holdouts)");
834834
}
835835

836836
[Test]
@@ -859,7 +859,7 @@ public void TestLocalHoldout_ExcludeTargetedDeliveries_True_StillAppliesForABRul
859859
var decision = result[0].ResultObject;
860860
Assert.IsNotNull(decision);
861861
Assert.AreEqual(FeatureDecision.DECISION_SOURCE_HOLDOUT, decision.Source,
862-
"Local holdout with exclude_targeted_deliveries=true should still apply for A/B rules");
862+
"Local holdout with excludeTargetedDeliveries=true should still apply for A/B rules");
863863
}
864864

865865
[Test]
@@ -900,9 +900,9 @@ public void TestGlobalHoldout_ExcludeTargetedDeliveries_NoTDRuleMatch_ReturnsNul
900900
var decision = result[0].ResultObject;
901901
Assert.IsNotNull(decision);
902902
Assert.IsNull(decision.Variation,
903-
"When TD returns no match with exclude_targeted_deliveries=true, variation should be null (no holdout fallback)");
903+
"When TD returns no match with excludeTargetedDeliveries=true, variation should be null (no holdout fallback)");
904904
Assert.IsNull(decision.Experiment,
905-
"When TD returns no match with exclude_targeted_deliveries=true, experiment should be null (no holdout fallback)");
905+
"When TD returns no match with excludeTargetedDeliveries=true, experiment should be null (no holdout fallback)");
906906
Assert.IsNotNull(decision.HoldoutDecision,
907907
"HoldoutDecision should be attached for event dispatch even when decision is null");
908908
}

OptimizelySDK.Tests/TestData/HoldoutTestData.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -816,7 +816,7 @@
816816
],
817817
"audienceIds": [],
818818
"audienceConditions": [],
819-
"exclude_targeted_deliveries": true
819+
"excludeTargetedDeliveries": true
820820
}
821821
],
822822
"localHoldouts": [
@@ -844,7 +844,7 @@
844844
"includedRules": [
845845
"rule_id_1"
846846
],
847-
"exclude_targeted_deliveries": true
847+
"excludeTargetedDeliveries": true
848848
},
849849
{
850850
"id": "holdout_local_rule2",
@@ -870,7 +870,7 @@
870870
"includedRules": [
871871
"rule_id_2"
872872
],
873-
"exclude_targeted_deliveries": true
873+
"excludeTargetedDeliveries": true
874874
},
875875
{
876876
"id": "holdout_local_empty_rules",
@@ -894,7 +894,7 @@
894894
"audienceIds": [],
895895
"audienceConditions": [],
896896
"includedRules": [],
897-
"exclude_targeted_deliveries": true
897+
"excludeTargetedDeliveries": true
898898
},
899899
{
900900
"id": "holdout_local_exp_rule1",
@@ -920,7 +920,7 @@
920920
"includedRules": [
921921
"exp_rule_id_1"
922922
],
923-
"exclude_targeted_deliveries": true
923+
"excludeTargetedDeliveries": true
924924
}
925925
]
926926
},

OptimizelySDK/Bucketing/DecisionService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -964,7 +964,7 @@ public virtual Result<FeatureDecision> GetDecisionForFlag(
964964
{
965965
Logger.Log(LogLevel.INFO,
966966
reasons.AddInfo(
967-
$"Holdout \"{matchedHoldout.Key}\" has exclude_targeted_deliveries enabled, continuing to rollout evaluation."));
967+
$"Holdout \"{matchedHoldout.Key}\" has excludeTargetedDeliveries enabled, continuing to rollout evaluation."));
968968
}
969969
}
970970

OptimizelySDK/Entity/Holdout.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public override string LayerId
5252
/// </summary>
5353
public string[] IncludedRules { get; set; }
5454

55-
[JsonProperty("exclude_targeted_deliveries")]
55+
[JsonProperty("excludeTargetedDeliveries")]
5656
public bool ExcludeTargetedDeliveries { get; set; }
5757

5858
/// <summary>

0 commit comments

Comments
 (0)