Merge pull request #211 from optimizely/ll/cache-abstraction

Caching Abstraction

Author: loganlinn

docs/package.json

@@ -23,8 +23,6 @@
     "nuclear-js": "^1.0.5",
     "webpack": "^1.9.11",
     "webpack-dev-server": "^1.9.0",
-    "grunt-concurrent": "^1.0.0",
-    "grunt-contrib-connect": "^0.10.1",
     "remarkable": "^1.6.0",
     "front-matter": "^1.0.0",
     "glob": "^5.0.10",

src/reactor.js

@@ -1,6 +1,7 @@
 import Immutable from 'immutable'
 import createReactMixin from './create-react-mixin'
 import * as fns from './reactor/fns'
+import { DefaultCache } from './reactor/cache'
 import { isKeyPath } from './key-path'
 import { isGetter } from './getter'
 import { toJS } from './immutable-helpers'
@@ -27,6 +28,7 @@ class Reactor {
     const baseOptions = debug ? DEBUG_OPTIONS : PROD_OPTIONS
     const initialReactorState = new ReactorState({
       debug: debug,
+      cache: config.cache || DefaultCache(),
       // merge config options with the defaults
       options: baseOptions.merge(config.options || {}),
     })

src/reactor/cache.js

@@ -0,0 +1,221 @@
+import { List, Map, OrderedSet, Record } from 'immutable'
+
+export const CacheEntry = Record({
+  value: null,
+  storeStates: Map(),
+  dispatchId: null,
+})
+
+/*******************************************************************************
+ * interface PersistentCache {
+ *    has(item)
+ *    lookup(item, notFoundValue)
+ *    hit(item)
+ *    miss(item, entry)
+ *    evict(item)
+ *    asMap()
+ * }
+ *
+ * Inspired by clojure.core.cache/CacheProtocol
+ *******************************************************************************/
+
+/**
+ * Plain map-based cache
+ */
+export class BasicCache {
+
+  /**
+   * @param {Immutable.Map} cache
+   */
+  constructor(cache = Map()) {
+    this.cache = cache;
+  }
+
+  /**
+   * Retrieve the associated value, if it exists in this cache, otherwise
+   * returns notFoundValue (or undefined if not provided)
+   * @param {Object} item
+   * @param {Object?} notFoundValue
+   * @return {CacheEntry?}
+   */
+  lookup(item, notFoundValue) {
+    return this.cache.get(item, notFoundValue)
+  }
+
+  /**
+   * Checks if this cache contains an associated value
+   * @param {Object} item
+   * @return {boolean}
+   */
+  has(item) {
+    return this.cache.has(item)
+  }
+
+  /**
+   * Return cached items as map
+   * @return {Immutable.Map}
+   */
+  asMap() {
+    return this.cache
+  }
+
+  /**
+   * Updates this cache when it is determined to contain the associated value
+   * @param {Object} item
+   * @return {BasicCache}
+   */
+  hit(item) {
+    return this;
+  }
+
+  /**
+   * Updates this cache when it is determined to **not** contain the associated value
+   * @param {Object} item
+   * @param {CacheEntry} entry
+   * @return {BasicCache}
+   */
+  miss(item, entry) {
+    return new BasicCache(
+      this.cache.update(item, existingEntry => {
+        if (existingEntry && existingEntry.dispatchId > entry.dispatchId) {
+          throw new Error("Refusing to cache older value")
+        }
+        return entry
+      })
+    )
+  }
+
+  /**
+   * Removes entry from cache
+   * @param {Object} item
+   * @return {BasicCache}
+   */
+  evict(item) {
+    return new BasicCache(this.cache.remove(item))
+  }
+}
+
+const DEFAULT_LRU_LIMIT = 1000
+const DEFAULT_LRU_EVICT_COUNT = 1
+
+/**
+ * Implements caching strategy that evicts least-recently-used items in cache
+ * when an item is being added to a cache that has reached a configured size
+ * limit.
+ */
+export class LRUCache {
+
+  constructor(limit = DEFAULT_LRU_LIMIT, evictCount = DEFAULT_LRU_EVICT_COUNT, cache = new BasicCache(), lru = OrderedSet()) {
+    this.limit = limit;
+    this.evictCount = evictCount
+    this.cache = cache;
+    this.lru = lru;
+  }
+
+  /**
+   * Retrieve the associated value, if it exists in this cache, otherwise
+   * returns notFoundValue (or undefined if not provided)
+   * @param {Object} item
+   * @param {Object?} notFoundValue
+   * @return {CacheEntry}
+   */
+  lookup(item, notFoundValue) {
+    return this.cache.lookup(item, notFoundValue)
+  }
+
+  /**
+   * Checks if this cache contains an associated value
+   * @param {Object} item
+   * @return {boolean}
+   */
+  has(item) {
+    return this.cache.has(item)
+  }
+
+  /**
+   * Return cached items as map
+   * @return {Immutable.Map}
+   */
+  asMap() {
+    return this.cache.asMap()
+  }
+
+  /**
+   * Updates this cache when it is determined to contain the associated value
+   * @param {Object} item
+   * @return {LRUCache}
+   */
+  hit(item) {
+    if (!this.cache.has(item)) {
+      return this;
+    }
+
+    // remove it first to reorder in lru OrderedSet
+    return new LRUCache(this.limit, this.evictCount, this.cache, this.lru.remove(item).add(item))
+  }
+
+  /**
+   * Updates this cache when it is determined to **not** contain the associated value
+   * If cache has reached size limit, the LRU item is evicted.
+   * @param {Object} item
+   * @param {CacheEntry} entry
+   * @return {LRUCache}
+   */
+  miss(item, entry) {
+    if (this.lru.size >= this.limit) {
+      if (this.has(item)) {
+        return new LRUCache(
+          this.limit,
+          this.evictCount,
+          this.cache.miss(item, entry),
+          this.lru.remove(item).add(item)
+        )
+      }
+
+      const cache = (this.lru
+                     .take(this.evictCount)
+                     .reduce((c, evictItem) => c.evict(evictItem), this.cache)
+                     .miss(item, entry));
+
+      return new LRUCache(
+        this.limit,
+        this.evictCount,
+        cache,
+        this.lru.skip(this.evictCount).add(item)
+      )
+    } else {
+      return new LRUCache(
+        this.limit,
+        this.evictCount,
+        this.cache.miss(item, entry),
+        this.lru.add(item)
+      )
+    }
+  }
+
+  /**
+   * Removes entry from cache
+   * @param {Object} item
+   * @return {LRUCache}
+   */
+  evict(item) {
+    if (!this.cache.has(item)) {
+      return this;
+    }
+
+    return new LRUCache(
+      this.limit,
+      this.evictCount,
+      this.cache.evict(item),
+      this.lru.remove(item)
+    )
+  }
+}
+
+/**
+ * Returns default cache strategy
+ * @return {BasicCache}
+ */
+export function DefaultCache() {
+  return new BasicCache()
+}

src/reactor/fns.js

@@ -1,5 +1,6 @@
 import Immutable from 'immutable'
 import logging from '../logging'
+import { CacheEntry } from './cache'
 import { isImmutableValue } from '../immutable-helpers'
 import { toImmutable } from '../immutable-helpers'
 import { fromKeyPath, getStoreDeps, getComputeFn, getDeps, isGetter } from '../getter'
@@ -330,22 +331,21 @@ export function evaluate(reactorState, keyPathOrGetter) {
   }
 
   // Must be a Getter
-  // if the value is cached for this dispatch cycle, return the cached value
-  if (isCached(reactorState, keyPathOrGetter)) {
-    // Cache hit
-    return evaluateResult(
-      getCachedValue(reactorState, keyPathOrGetter),
-      reactorState
-    )
-  }
 
-  // evaluate dependencies
-  const args = getDeps(keyPathOrGetter).map(dep => evaluate(reactorState, dep).result)
-  const evaluatedValue = getComputeFn(keyPathOrGetter).apply(null, args)
+  const cache = reactorState.get('cache')
+  var cacheEntry = cache.lookup(keyPathOrGetter)
+  const isCacheMiss = !cacheEntry || isDirtyCacheEntry(reactorState, cacheEntry)
+  if (isCacheMiss) {
+    cacheEntry = createCacheEntry(reactorState, keyPathOrGetter)
+  }
 
   return evaluateResult(
-    evaluatedValue,
-    cacheValue(reactorState, keyPathOrGetter, evaluatedValue)
+    cacheEntry.get('value'),
+    reactorState.update('cache', cache => {
+      return isCacheMiss ?
+        cache.miss(keyPathOrGetter, cacheEntry) :
+        cache.hit(keyPathOrGetter)
+    })
   )
 }
 
@@ -375,57 +375,31 @@ export function resetDirtyStores(reactorState) {
   return reactorState.set('dirtyStores', Immutable.Set())
 }
 
-/**
- * Currently cache keys are always getters by reference
- * @param {Getter} getter
- * @return {Getter}
- */
-function getCacheKey(getter) {
-  return getter
-}
-
 /**
  * @param {ReactorState} reactorState
- * @param {Getter|KeyPath} keyPathOrGetter
- * @return {Immutable.Map}
+ * @param {CacheEntry} cacheEntry
+ * @return {boolean}
  */
-function getCacheEntry(reactorState, keyPathOrGetter) {
-  const key = getCacheKey(keyPathOrGetter)
-  return reactorState.getIn(['cache', key])
-}
+function isDirtyCacheEntry(reactorState, cacheEntry) {
+  const storeStates = cacheEntry.get('storeStates')
 
-/**
- * @param {ReactorState} reactorState
- * @param {Getter} getter
- * @return {Boolean}
- */
-function isCached(reactorState, keyPathOrGetter) {
-  const entry = getCacheEntry(reactorState, keyPathOrGetter)
-  if (!entry) {
-    return false
-  }
-
-  const storeStates = entry.get('storeStates')
-  if (storeStates.size === 0) {
-    // if there are no store states for this entry then it was never cached before
-    return false
-  }
-
-  return storeStates.every((stateId, storeId) => {
-    return reactorState.getIn(['storeStates', storeId]) === stateId
+  // if there are no store states for this entry then it was never cached before
+  return !storeStates.size || storeStates.some((stateId, storeId) => {
+    return reactorState.getIn(['storeStates', storeId]) !== stateId
   })
 }
 
 /**
- * Caches the value of a getter given state, getter, args, value
+ * Evaluates getter for given reactorState and returns CacheEntry
  * @param {ReactorState} reactorState
  * @param {Getter} getter
- * @param {*} value
- * @return {ReactorState}
+ * @return {CacheEntry}
  */
-function cacheValue(reactorState, getter, value) {
-  const cacheKey = getCacheKey(getter)
-  const dispatchId = reactorState.get('dispatchId')
+function createCacheEntry(reactorState, getter) {
+  // evaluate dependencies
+  const args = getDeps(getter).map(dep => evaluate(reactorState, dep).result)
+  const value = getComputeFn(getter).apply(null, args)
+
   const storeDeps = getStoreDeps(getter)
   const storeStates = toImmutable({}).withMutations(map => {
     storeDeps.forEach(storeId => {
@@ -434,19 +408,11 @@ function cacheValue(reactorState, getter, value) {
     })
   })
 
-  return reactorState.setIn(['cache', cacheKey], Immutable.Map({
+  return CacheEntry({
     value: value,
     storeStates: storeStates,
-    dispatchId: dispatchId,
-  }))
-}
-
-/**
- * Pulls out the cached value for a getter
- */
-function getCachedValue(reactorState, getter) {
-  const key = getCacheKey(getter)
-  return reactorState.getIn(['cache', key, 'value'])
+    dispatchId: reactorState.get('dispatchId'),
+  })
 }
 
 /**

src/reactor/records.js

@@ -1,4 +1,5 @@
 import { Map, Set, Record } from 'immutable'
+import { DefaultCache } from './cache'
 
 export const PROD_OPTIONS = Map({
   // logs information for each dispatch
@@ -38,7 +39,7 @@ export const ReactorState = Record({
   dispatchId: 0,
   state: Map(),
   stores: Map(),
-  cache: Map(),
+  cache: DefaultCache(),
   // maintains a mapping of storeId => state id (monotomically increasing integer whenever store state changes)
   storeStates: Map(),
   dirtyStores: Set(),