Skip to content

Commit 6620481

Browse files
refactor: update log level conversion logic
- Adjust method to correctly convert log level strings to integers - Refactor switch statement for better readability and maintainability
1 parent b70cc9e commit 6620481

File tree

2 files changed

+33
-3
lines changed

2 files changed

+33
-3
lines changed

android/src/main/java/com/optimizely/optimizely_flutter_sdk/FlutterLogbackAppender.java

Lines changed: 32 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
package com.optimizely.optimizely_flutter_sdk;
2+
import com.optimizely.optimizely_flutter_sdk.helper_classes.Constants;
23

34
import android.os.Handler;
45
import android.os.Looper;
@@ -27,10 +28,12 @@ protected void append(ILoggingEvent event) {
2728
}
2829

2930
String message = event.getFormattedMessage();
30-
int level = event.getLevel().toInt();
31-
31+
String level = event.getLevel().toString();
32+
// print level here
33+
System.out.println("loglevel: " + level);
34+
int logLevel = convertLogLevel(level);
3235
Map<String, Object> logData = new HashMap<>();
33-
logData.put("level", level);
36+
logData.put("level", logLevel);
3437
logData.put("message", message);
3538

3639
mainThreadHandler.post(() -> {
@@ -39,4 +42,30 @@ protected void append(ILoggingEvent event) {
3942
}
4043
});
4144
}
45+
46+
int convertLogLevel(String logLevel) {
47+
int level = 3; // Default to INFO
48+
49+
if (logLevel == null || logLevel.isEmpty()) {
50+
return level;
51+
}
52+
53+
switch (logLevel.toLowerCase()) {
54+
case Constants.LogLevel.ERROR:
55+
level = 1;
56+
break;
57+
case Constants.LogLevel.WARNING:
58+
level = 2;
59+
break;
60+
case Constants.LogLevel.INFO:
61+
level = 3;
62+
break;
63+
case Constants.LogLevel.DEBUG:
64+
level = 4;
65+
break;
66+
default: {
67+
}
68+
}
69+
return level;
70+
}
4271
}

android/src/main/java/com/optimizely/optimizely_flutter_sdk/OptimizelyFlutterSdkPlugin.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ public void onAttachedToEngine(@NonNull FlutterPluginBinding binding) {
176176
flutterLogbackAppender.setContext(lc);
177177
flutterLogbackAppender.start();
178178
Logger rootLogger = (Logger) LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME);
179+
rootLogger.setLevel(ch.qos.logback.classic.Level.ALL);
179180
rootLogger.addAppender(flutterLogbackAppender);
180181
}
181182

0 commit comments

Comments
 (0)