Skip to content

Commit 9b437e5

Browse files
[FSSDK-12882] review feedback
1 parent 3a6bbab commit 9b437e5

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/ghr_backfill.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,10 @@ jobs:
6363
6464
for v in $versions; do
6565
echo "::group::${pkg}@${v}"
66-
tarball=$(npm pack "${pkg}@${v}" --registry https://registry.npmjs.org 2>/dev/null | tail -n1)
66+
# npm pack writes the tarball filename to stdout and notices/errors to
67+
# stderr; keep stderr visible so pack failures (auth/404/network) show
68+
# in the logs. pipefail (set above) makes a failed pack abort the job.
69+
tarball=$(npm pack "${pkg}@${v}" --registry https://registry.npmjs.org | tail -n1)
6770
scripts/publish.sh "https://npm.pkg.github.com" "$tarball"
6871
rm -f "$tarball"
6972
echo "::endgroup::"

.github/workflows/react_release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ jobs:
3939
steps:
4040
- name: Checkout branch
4141
uses: actions/checkout@v4
42+
with:
43+
persist-credentials: false
4244

4345
# Install from the public npm registry so scoped dependencies
4446
# (e.g. @optimizely/optimizely-sdk) resolve normally. We do NOT route the

0 commit comments

Comments
 (0)