Correct the bucket value test function

Author: esrakartalOpt

lib/optimizely/decision_service.rb

@@ -282,7 +282,7 @@ def get_variations_for_feature_list(project_config, feature_flags, user_context,
       ignore_ups = decide_options.include? Optimizely::Decide::OptimizelyDecideOption::IGNORE_USER_PROFILE_SERVICE
       user_profile_tracker = nil
       unless ignore_ups && @user_profile_service
-        user_profile_tracker = UserProfileTracker.new(user_context.user_id, @user_profile_service, @logger) if user_context.respond_to?(:user_id)
+        user_profile_tracker = UserProfileTracker.new(user_context.user_id, @user_profile_service, @logger)
         user_profile_tracker.load_user_profile
       end
       decisions = []

spec/bucketing_holdout_spec.rb

@@ -43,6 +43,8 @@ def generate_bucket_value(bucketing_id)
 end
 
 describe 'Optimizely::Bucketer - Holdout Tests' do
+  let(:config_body) { OptimizelySpec::CONFIG_BODY_WITH_HOLDOUTS }
+  let(:config_body_JSON) { OptimizelySpec::CONFIG_BODY_WITH_HOLDOUTS_JSON }
   let(:error_handler) { Optimizely::NoOpErrorHandler.new }
   let(:spy_logger) { spy('logger') }
   let(:test_user_id) { 'test_user_id' }
@@ -68,7 +70,7 @@ def generate_bucket_value(bucketing_id)
       expect(holdout).not_to be_nil
 
       # Set bucket value to be within first variation's traffic allocation (0-5000 range)
-      test_bucketer.set_bucket_values([2500])
+      test_bucketer.bucket_values([2500])
 
       variation, _reasons = test_bucketer.bucket(config, holdout, test_bucketing_id, test_user_id)
 
@@ -92,7 +94,7 @@ def generate_bucket_value(bucketing_id)
       modified_holdout['trafficAllocation'][0]['endOfRange'] = 1000
 
       # Set bucket value outside traffic allocation range
-      test_bucketer.set_bucket_values([1500])
+      test_bucketer.bucket_values([1500])
 
       variation, _reasons = test_bucketer.bucket(config, modified_holdout, test_bucketing_id, test_user_id)
 
@@ -113,13 +115,13 @@ def generate_bucket_value(bucketing_id)
       modified_holdout = OptimizelySpec.deep_clone(holdout)
       modified_holdout['trafficAllocation'] = []
 
-      test_bucketer.set_bucket_values([5000])
+      test_bucketer.bucket_values([5000])
 
       variation, _reasons = test_bucketer.bucket(config, modified_holdout, test_bucketing_id, test_user_id)
 
       expect(variation).to be_nil
 
-      # Verify bucket was assigned but no variation found
+      # Verify bucket was assigned
       expect(spy_logger).to have_received(:log).with(
         Logger::DEBUG,
         "Assigned bucket 5000 to user '#{test_user_id}' with bucketing ID: '#{test_bucketing_id}'."
@@ -134,7 +136,7 @@ def generate_bucket_value(bucketing_id)
       modified_holdout = OptimizelySpec.deep_clone(holdout)
       modified_holdout['trafficAllocation'][0]['entityId'] = 'invalid_variation_id'
 
-      test_bucketer.set_bucket_values([5000])
+      test_bucketer.bucket_values([5000])
 
       variation, _reasons = test_bucketer.bucket(config, modified_holdout, test_bucketing_id, test_user_id)
 
@@ -152,7 +154,7 @@ def generate_bucket_value(bucketing_id)
       expect(holdout).not_to be_nil
       expect(holdout['variations']&.length || 0).to eq(0)
 
-      test_bucketer.set_bucket_values([5000])
+      test_bucketer.bucket_values([5000])
 
       variation, _reasons = test_bucketer.bucket(config, holdout, test_bucketing_id, test_user_id)
 
@@ -173,7 +175,7 @@ def generate_bucket_value(bucketing_id)
       modified_holdout = OptimizelySpec.deep_clone(holdout)
       modified_holdout['key'] = ''
 
-      test_bucketer.set_bucket_values([5000])
+      test_bucketer.bucket_values([5000])
 
       variation, _reasons = test_bucketer.bucket(config, modified_holdout, test_bucketing_id, test_user_id)
 
@@ -189,7 +191,7 @@ def generate_bucket_value(bucketing_id)
       modified_holdout = OptimizelySpec.deep_clone(holdout)
       modified_holdout['key'] = nil
 
-      test_bucketer.set_bucket_values([5000])
+      test_bucketer.bucket_values([5000])
 
       variation, _reasons = test_bucketer.bucket(config, modified_holdout, test_bucketing_id, test_user_id)
 
@@ -205,7 +207,7 @@ def generate_bucket_value(bucketing_id)
       expect(holdout['variations'].length).to be >= 2
 
       # Test user buckets into first variation
-      test_bucketer.set_bucket_values([2500])
+      test_bucketer.bucket_values([2500])
       variation, _reasons = test_bucketer.bucket(config, holdout, test_bucketing_id, test_user_id)
 
       expect(variation).not_to be_nil
@@ -223,7 +225,7 @@ def generate_bucket_value(bucketing_id)
       expect(holdout['variations'][1]['id']).to eq('var_2')
 
       # Test user buckets into second variation (bucket value 7500 should be in 5000-10000 range)
-      test_bucketer.set_bucket_values([7500])
+      test_bucketer.bucket_values([7500])
       variation, _reasons = test_bucketer.bucket(config, holdout, test_bucketing_id, test_user_id)
 
       expect(variation).not_to be_nil
@@ -240,14 +242,14 @@ def generate_bucket_value(bucketing_id)
       modified_holdout['trafficAllocation'][0]['endOfRange'] = 5000
 
       # Test exact boundary value (should be included)
-      test_bucketer.set_bucket_values([4999])
+      test_bucketer.bucket_values([4999])
       variation, _reasons = test_bucketer.bucket(config, modified_holdout, test_bucketing_id, test_user_id)
 
       expect(variation).not_to be_nil
       expect(variation['id']).to eq('var_1')
 
       # Test value just outside boundary (should not be included)
-      test_bucketer.set_bucket_values([5000])
+      test_bucketer.bucket_values([5000])
       variation, _reasons = test_bucketer.bucket(config, modified_holdout, test_bucketing_id, test_user_id)
 
       expect(variation).to be_nil
@@ -290,7 +292,7 @@ def generate_bucket_value(bucketing_id)
       holdout = config.get_holdout('holdout_1')
       expect(holdout).not_to be_nil
 
-      test_bucketer.set_bucket_values([5000])
+      test_bucketer.bucket_values([5000])
       _variation, reasons = test_bucketer.bucket(config, holdout, test_bucketing_id, test_user_id)
 
       expect(reasons).not_to be_nil

spec/config/datafile_project_config_spec.rb

@@ -1675,13 +1675,9 @@
         holdout = config_with_holdouts.holdouts.first
 
         if holdout
-          expect(holdout).to have_key('audiences')
-
-          # Empty audience array means it matches everyone (evaluates to TRUE)
-          if holdout['audiences'].empty?
-            # This is valid - empty audiences = no restrictions
-            expect(holdout['audiences']).to eq([])
-          end
+          expect(holdout).to have_key('id')
+          expect(holdout).to have_key('key')
+          expect(holdout.key?('audienceIds') || holdout.key?('audiences')).to be true
         end
       end
 

spec/spec_params.rb

@@ -1946,6 +1946,7 @@ module OptimizelySpec
           'id' => 'holdout_1',
           'key' => 'global_holdout',
           'status' => 'Running',
+          'audiences' => [],
           'includedFlags' => [],
           'excludedFlags' => ['155554'],
           'variations' => [
@@ -1975,6 +1976,7 @@ module OptimizelySpec
           'id' => 'holdout_empty_1',
           'key' => 'holdout_empty_1',
           'status' => 'Running',
+          'audiences' => [],
           'includedFlags' => [],
           'excludedFlags' => [],
           'variations' => [],
@@ -1984,6 +1986,7 @@ module OptimizelySpec
           'id' => 'holdout_2',
           'key' => 'specific_holdout',
           'status' => 'Running',
+          'audiences' => [],
           'includedFlags' => ['155559'],
           'excludedFlags' => [],
           'variations' => [
@@ -2004,6 +2007,7 @@ module OptimizelySpec
           'id' => 'holdout_3',
           'key' => 'inactive_holdout',
           'status' => 'Inactive',
+          'audiences' => [],
           'includedFlags' => ['155554'],
           'excludedFlags' => [],
           'variations' => [