Skip to content

Commit 2e54285

Browse files
committed
Merge branch 'ODSC-73735/smc-env-config-refractoring' of github.com:oracle/accelerated-data-science into list_models_using_openAI_API
2 parents fc96e33 + 15d3043 commit 2e54285

File tree

1 file changed

+4
-17
lines changed

1 file changed

+4
-17
lines changed

ads/aqua/config/container_config.py

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
UNKNOWN_JSON_STR,
1616
)
1717
from ads.common.extended_enum import ExtendedEnum
18-
from ads.common.utils import UNKNOWN
1918

2019

2120
class Usage(ExtendedEnum):
@@ -190,22 +189,10 @@ def from_service_config(
190189
container_item.model_formats.append(
191190
additional_configurations.get("modelFormats")
192191
)
193-
194-
# Parse environment variables from `additional_configurations`.
195-
# Only keys present in the configuration will be added to the result.
196-
config_keys = {
197-
"MODEL_DEPLOY_PREDICT_ENDPOINT": UNKNOWN,
198-
"MODEL_DEPLOY_HEALTH_ENDPOINT": UNKNOWN,
199-
"PORT": UNKNOWN,
200-
"HEALTH_CHECK_PORT": UNKNOWN,
201-
"VLLM_USE_V1": UNKNOWN,
202-
}
203-
204-
env_vars = [
205-
{key: additional_configurations.get(key, default)}
206-
for key, default in config_keys.items()
207-
if key in additional_configurations
208-
]
192+
env_vars_dict = json.loads(
193+
additional_configurations.get("env_vars") or "{}"
194+
)
195+
env_vars = [{key: value} for key, value in env_vars_dict.items()]
209196

210197
# Build container spec
211198
container_item.spec = AquaContainerConfigSpec(

0 commit comments

Comments
 (0)