Skip to content

Commit 6829706

Browse files
authored
Fixed custom model name for single deployment. (#1274)
2 parents d10b72a + 4168e87 commit 6829706

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

ads/aqua/modeldeployment/deployment.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -965,8 +965,7 @@ def _create(
965965
# adds `--enable_lora` to parameters
966966
params_dict.update({"--enable_lora": UNKNOWN})
967967
params = build_params_string(params_dict)
968-
969-
if create_deployment_details.model_name and "--served-model-name" in params:
968+
elif create_deployment_details.model_name and "--served-model-name" in params:
970969
# Replace existing --served-model-name argument with custom name provided by user
971970
params = re.sub(
972971
r"--served-model-name\s+\S+",

tests/unitary/default_setup/model_deployment/test_model_deployment_v2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -922,7 +922,7 @@ def test_update(
922922
model_deployment = self.initialize_model_deployment()
923923
model_deployment.dsc_model_deployment.id = "test_model_deployment_id"
924924
update_model_deployment_details = (
925-
model_deployment._update_model_deployment_details()
925+
model_deployment._update_model_deployment_details(update_type="ZDT")
926926
)
927927
model_deployment.update(wait_for_completion=True)
928928
mock_create.assert_called()

0 commit comments

Comments
 (0)