Fix and improve javadocs && Improve thread safety

Author: MouhsinElmajdouby

ojdbc-provider-observability/src/main/java/oracle/jdbc/provider/observability/ObservabilityConfiguration.java

@@ -124,15 +124,7 @@ public class ObservabilityConfiguration implements ObservabilityConfigurationMBe
   private static final String DEFAULT_ENABLED_TRACERS = "OTEL,JFR";
   private static final String DEFAULT_SENSITIVE_DATA_ENABLED = "false";
   private static final String DEFAULT_OPEN_TELEMETRY_ENABLED = "true";
-  private volatile String semconvOptIn = "";
-
-  public String getSemconvOptIn() {
-    return semconvOptIn == null ? "" : semconvOptIn;
-  }
-
-  public void setSemconvOptIn(String optIn) {
-    this.semconvOptIn = optIn == null ? "" : optIn;
-  }
+  private String semconvOptIn = "";
 
 
   /**
@@ -212,7 +204,7 @@ public ObservabilityConfiguration() {
 
     setEnabledTracers(enabledTracers);
     setSensitiveDataEnabled(Boolean.parseBoolean(sensitiveDataEnabled));
-    this.setSemconvOptIn(optIn);
+    setSemconvOptIn(optIn);
 
   }
 
@@ -317,6 +309,38 @@ public void setSensitiveDataEnabled(boolean sensitiveDataEnabled) {
     }
   }
 
+  /**
+   * Returns the OpenTelemetry semantic convention stability opt-in configuration.
+   *
+   * @return the current semantic convention mode, never {@code null}
+   */
+  @Override
+  public String getSemconvOptIn() {
+    observabilityConfigurationLock.lock();
+    try {
+      return semconvOptIn == null ? "" : semconvOptIn;
+    } finally {
+      observabilityConfigurationLock.unlock();
+    }
+  }
+
+  /**
+   * Sets the OpenTelemetry semantic convention stability opt-in configuration.
+   *
+   * @param optIn the semantic convention mode to set; {@code null} is
+   * treated as empty string
+   */
+  @Override
+  public void setSemconvOptIn(String optIn) {
+    observabilityConfigurationLock.lock();
+    try {
+      this.semconvOptIn = optIn == null ? "" : optIn;
+    } finally {
+      observabilityConfigurationLock.unlock();
+    }
+  }
+
+
   /**
    * Returns a list of enabled tracers.
    * @return then list of enabled tracers.

ojdbc-provider-observability/src/main/java/oracle/jdbc/provider/observability/ObservabilityConfigurationMBean.java

@@ -94,7 +94,19 @@ public interface ObservabilityConfigurationMBean {
    */
   void setSensitiveDataEnabled(boolean sensitiveDataEnabled);
 
+  /**
+   * Returns the OpenTelemetry semantic convention stability opt-in configuration.
+   *
+   * @return the current semantic convention mode, never {@code null}
+   */
   String getSemconvOptIn();
+
+  /**
+   * Sets the OpenTelemetry semantic convention stability opt-in configuration.
+   *
+   * @param optIn the semantic convention mode to set; {@code null} is
+   * treated as empty string
+   */
   void setSemconvOptIn(String optIn);
 
 }

ojdbc-provider-observability/src/main/java/oracle/jdbc/provider/observability/tracers/otel/OTelTracer.java

@@ -64,7 +64,6 @@
  * Open Telemetry tracer. Exports round trip event and execution events to
  * Open Telemetry. with support for both stable and experimental semantic
  * conventions.
- * </p>
  * <p>
  * <b>Semantic Convention Modes:</b>
  * </p>