add more tests for result and maputils

Author: markxnelson

src/test/java/weblogic/logging/exporter/ResultTest.java

@@ -0,0 +1,37 @@
+/*
+ * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
+ *
+ * Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+ */
+
+package weblogic.logging.exporter;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+@DisplayName("Test the Result object")
+public class ResultTest {
+
+  private static final String EXPECTED_STRING =
+      "Result{response='good', status=1, successful=true}";
+
+  @DisplayName("Check constructor and getters")
+  @Test
+  public void testConstructorAndGetters() {
+    Result result = new Result("good", 1, true);
+
+    assertEquals("good", result.getResponse());
+    assertEquals(1, result.getStatus());
+    assertEquals(true, result.isSuccessful());
+  }
+
+  @DisplayName("Check toString() works")
+  @Test
+  public void checkToString() {
+    Result result = new Result("good", 1, true);
+
+    assertEquals(EXPECTED_STRING, result.toString());
+  }
+}

src/test/java/weblogic/logging/exporter/config/FilterConfigTest.java

@@ -11,6 +11,7 @@
 import java.io.ByteArrayOutputStream;
 import java.io.PrintStream;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
@@ -93,4 +94,19 @@ public void checkDuplicateValuesAreRejected() {
 
     assertThrows(ConfigurationException.class, () -> FilterConfig.create(map));
   }
+
+  @DisplayName("Check getServers() returns the right data")
+  @Test
+  public void checkGetServersWorks() {
+    Map<String, Object> map = new HashMap<>();
+    map.put("FilterServers", new String[] {"managed-server-1", "managed-server-2"});
+    FilterConfig filterConfig = FilterConfig.create(map);
+
+    assertTrue(filterConfig.getServers() instanceof List);
+    assertEquals(2, filterConfig.getServers().size());
+    assertTrue(filterConfig.getServers().get(0) instanceof String);
+    assertEquals("managed-server-1", filterConfig.getServers().get(0));
+    assertTrue(filterConfig.getServers().get(1) instanceof String);
+    assertEquals("managed-server-2", filterConfig.getServers().get(1));
+  }
 }

src/test/java/weblogic/logging/exporter/config/MapUtilsTest.java

@@ -6,11 +6,14 @@
 
 import static org.hamcrest.Matchers.arrayContaining;
 import static org.hamcrest.junit.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Map;
 import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 
 @SuppressWarnings("EmptyMethod")
@@ -41,6 +44,60 @@ public void whenStringArrayValueIsList_returnAsArray() {
     assertThat(MapUtils.getStringArray(map, "values"), arrayContaining("7", "8", "true"));
   }
 
+  @DisplayName("Check getBooleanValue for true values")
+  @Test
+  public void checkGetBooleanForTrueValues() {
+    Map<String, Object> map = new HashMap<>();
+    map.put("1", "true");
+    map.put("2", "t");
+    map.put("3", "yes");
+    map.put("4", "on");
+    map.put("5", "y");
+    map.put("6", "truenot");
+    map.put("7", "nottrue");
+    map.put("8", "yesss");
+    map.put("9", "y ");
+    map.put("10", " y ");
+
+    assertEquals(true, MapUtils.getBooleanValue(map, "1"));
+    assertEquals(true, MapUtils.getBooleanValue(map, "2"));
+    assertEquals(true, MapUtils.getBooleanValue(map, "3"));
+    assertEquals(true, MapUtils.getBooleanValue(map, "4"));
+    assertEquals(true, MapUtils.getBooleanValue(map, "5"));
+    assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "6"));
+    assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "7"));
+    assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "8"));
+    assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "9"));
+    assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "10"));
+  }
+
+  @DisplayName("Check getBooleanValue for false values")
+  @Test
+  public void checkGetBooleanForFalseValues() {
+    Map<String, Object> map = new HashMap<>();
+    map.put("1", "false");
+    map.put("2", "f");
+    map.put("3", "no");
+    map.put("4", "off");
+    map.put("5", "n");
+    map.put("6", "falsedata");
+    map.put("7", "sofalse");
+    map.put("8", "ono");
+    map.put("9", "n ");
+    map.put("10", " n ");
+
+    assertEquals(false, MapUtils.getBooleanValue(map, "1"));
+    assertEquals(false, MapUtils.getBooleanValue(map, "2"));
+    assertEquals(false, MapUtils.getBooleanValue(map, "3"));
+    assertEquals(false, MapUtils.getBooleanValue(map, "4"));
+    assertEquals(false, MapUtils.getBooleanValue(map, "5"));
+    assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "6"));
+    assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "7"));
+    assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "8"));
+    assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "9"));
+    assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "10"));
+  }
+
   private Map<String, Object> createMapWithValue(Object value) {
     Map<String, Object> map = new HashMap<>();
     map.put("values", value);