Use dedicated option to download iso and hdd with archive subcommand

Based on the history this did not meant to download other assets than 'other'
assets and it is implemeted using the `asset-size-limit` parameter, which was
set in a quite small size.
#1571 (comment)

With this size in place, the error is confusing and not intuitive. It makes
more sense to remove the limit in case you want to get the full assets.

- Introduce `--all` to skip _asset-size-limit_
- keep _asset-size-limit_ for the 'other' assets

Signed-off-by: Ioannis Bonatakis <[email protected]>

Author: d3flex

lib/OpenQA/CLI/archive.pm

@@ -21,7 +21,8 @@ sub command ($self, @args) {
             url => $url,
             archive => $path,
             'with-thumbnails' => $options{'with-thumbnails'},
-            'asset-size-limit' => $options{'asset-size-limit'}});
+            'asset-size-limit' => $options{'asset-size-limit'},
+            'all' => $options{'all'}});
 
     return 0;
 }

lib/OpenQA/Client/Archive.pm

@@ -18,7 +18,8 @@ sub run ($self, $options) {
     my $res = $req->res;
     my $default_max_asset_size = 1024 * 1024 * 200;
     $options->{'asset-size-limit'} //= $default_max_asset_size;
-    $self->client->max_response_size($options->{'asset-size-limit'});
+    $options->{'all'} //= 0;
+    $self->client->max_response_size($options->{'all'} ? 0 : $options->{'asset-size-limit'});
 
     my $code = $res->code;
     die "There's an error openQA client returned $code" unless $code eq 200;
@@ -32,7 +33,7 @@ sub run ($self, $options) {
     delete($job->{assets}->{repo});
 
     $path->child('testresults', 'thumbnails')->make_path if $options->{'with-thumbnails'};
-    $self->_download_assets($url, $job, $path);
+    $self->_download_assets($url, $job, $path) if $options->{'all'};
     $self->_download_test_results($url, $job, $path, $options);
 }
 

public/openqa-cli.yaml

@@ -163,6 +163,7 @@ subcommands:
     options:
       - asset-size-limit|l=i   --Asset size limit in bytes
       - with-thumbnails|t      --Download thumbnails as well
+      - all|a      --Download including iso, hdd as well
 
   schedule:
     summary: Schedules a set of jobs (via "isos post" creating a schedule product)