Emit restart events when a job is enqueued

Use the `auto_duplicate` to emit an event as it is invoked by other
functions which try to handle individual job restarts.
That should make sure that the event is send to AMQP for jobs with
`RETRY` once it is actually triggered.

issue: https://progress.opensuse.org/issues/190557
Signed-off-by: Ioannis Bonatakis <[email protected]>

Author: d3flex

lib/OpenQA/Schema/Result/Jobs.pm

@@ -16,6 +16,7 @@ use OpenQA::Utils (
 use OpenQA::App;
 use OpenQA::Jobs::Constants;
 use OpenQA::JobDependencies::Constants;
+use OpenQA::Events;
 use OpenQA::Markdown 'markdown_to_html';
 use OpenQA::Setup;
 use OpenQA::ScreenshotDeletion;
@@ -1001,6 +1002,7 @@ sub auto_duplicate ($self, $args = {}) {
     $dup->{cluster_cloned} = {map { $_ => $clones->{$_}->{clone} } keys %$clones};
     $dup->{comments_created} = $args->{comments};
     log_debug("Job $job_id duplicated as $clone_id");
+    OpenQA::Events->singleton->emit_event('job_restart', data => {id => $clone_id});
     return $dup;
 }
 

t/10-jobs.t

@@ -19,6 +19,7 @@ use OpenQA::Jobs::Constants;
 use OpenQA::Test::Case;
 use Test::MockModule 'strict';
 use Test::Mojo;
+use Test::Output;
 use Test::Warnings qw(:report_warnings warning);
 use Mojo::File 'path';
 use Mojo::JSON qw(decode_json encode_json);
@@ -899,7 +900,8 @@ subtest 'job setting based retriggering' => sub {
     my $finalize_job_count_before = @{$get_jobs->('finalize_job_results')};
     $job->update({state => SCHEDULED, result => NONE});
     $job->done(result => FAILED);
-    perform_minion_jobs($minion);
+    stdout_like { perform_minion_jobs($minion) } qr/Job \d+ duplicated as \d+/,
+      'check debug message from auto_duplicate';
     is $jobs->count, $jobs_nr + 2, 'job retriggered as it FAILED (with retry)';
     $job->update;
     $job->discard_changes;

t/20-stale-job-detection.t

@@ -13,6 +13,7 @@ use Test::Output qw(combined_like stderr_like);
 use Test::MockModule;
 use OpenQA::App;
 use OpenQA::Constants qw(DEFAULT_WORKER_TIMEOUT DB_TIMESTAMP_ACCURACY);
+use OpenQA::Events;
 use OpenQA::Jobs::Constants;
 use OpenQA::WebSockets;
 use OpenQA::Scheduler;
@@ -43,9 +44,24 @@ subtest 'worker with job and not updated in last 120s is considered dead' => sub
     $workers->update_all({t_seen => undef});
     is($jobs->stale_ones->count, 3, 'jobs considered stale if t_seen is not set');
 
+    my @emitted_events;
+    my $mock_events = Test::MockModule->new('OpenQA::Events');
+    $mock_events->redefine(
+        emit_event => sub {
+            my ($self, $type, %args) = @_;
+            push @emitted_events, {type => $type, %args};
+        });
+
     stderr_like { OpenQA::Scheduler::Model::Jobs->singleton->incomplete_and_duplicate_stale_jobs }
     qr/Dead job 99961 aborted and duplicated 99982\n.*Dead job 99963 aborted as incomplete/, 'dead jobs logged';
 
+    is(scalar @emitted_events, 1, 'one event emitted for the duplicated job');
+    is_deeply(
+        $emitted_events[0],
+        {type => 'job_restart', data => {id => 99982}},
+        'job_restart event with correct type and data'
+    );
+
     for my $job_id (99961, 99963) {
         my $job = $jobs->find(99963);
         is($job->state, DONE, "running job $job_id is now done");