Skip to content

Commit 41675c6

Browse files
committed
[Library] Issue #7 part 2 : Change way of onSubmitValueParser default value
1 parent cef7d95 commit 41675c6

File tree

7 files changed

+8
-12
lines changed

7 files changed

+8
-12
lines changed

src/JsonTree.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { ADD_DELTA_TYPE, REMOVE_DELTA_TYPE, UPDATE_DELTA_TYPE } from './types/de
1414
import { getObjectType } from './utils/objectTypes';
1515
import DATA_TYPES from './types/dataTypes';
1616
import INPUT_USAGE_TYPES from './types/inputUsageTypes';
17+
import parse from './utils/parse';
1718

1819
/* ************************************* */
1920
/* ******** VARIABLES ******** */
@@ -74,6 +75,7 @@ const defaultProps = {
7475
beforeAddAction: (key, keyPath, deep, newValue) => new Promise(resolve => resolve()),
7576
beforeUpdateAction: (key, keyPath, deep, oldValue, newValue) => new Promise(resolve => resolve()),
7677
logger: { error: () => {} },
78+
onSubmitValueParser: (isEditMode, keyPath, deep, name, rawValue) => parse(rawValue),
7779
// inputElement : (usage, keyPath, deep, keyName, data, dataType)
7880
// textareaElement : (usage, keyPath, deep, keyName, data, dataType)
7981
/* eslint-enable */

src/components/JsonAddValue.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import React, { Component } from 'react';
1010
import PropTypes from 'prop-types';
1111
import { HotKeys } from 'react-hotkeys';
12-
import parse from '../utils/parse';
1312
import inputUsageTypes from '../types/inputUsageTypes';
1413

1514
/* ************************************* */
@@ -25,15 +24,14 @@ const propTypes = {
2524
inputElementGenerator: PropTypes.func,
2625
keyPath: PropTypes.array,
2726
deep: PropTypes.number,
28-
onSubmitValueParser: PropTypes.func,
27+
onSubmitValueParser: PropTypes.func.isRequired,
2928
};
3029
// Default props
3130
const defaultProps = {
3231
onlyValue: false,
3332
addButtonElement: <button>+</button>,
3433
cancelButtonElement: <button>c</button>,
3534
inputElementGenerator: () => <input />,
36-
onSubmitValueParser: (isEditMode, keyPath, deep, name, value) => parse(value),
3735
};
3836

3937
/* ************************************* */

src/components/JsonArray.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const propTypes = {
4040
beforeAddAction: PropTypes.func,
4141
beforeUpdateAction: PropTypes.func,
4242
logger: PropTypes.object.isRequired,
43-
onSubmitValueParser: PropTypes.func,
43+
onSubmitValueParser: PropTypes.func.isRequired,
4444
};
4545
// Default props
4646
const defaultProps = {

src/components/JsonFunctionValue.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import React, { Component } from 'react';
1010
import PropTypes from 'prop-types';
1111
import { HotKeys } from 'react-hotkeys';
12-
import parse from '../utils/parse';
1312
import { isComponentWillChange } from '../utils/objectTypes';
1413
import inputUsageTypes from '../types/inputUsageTypes';
1514

@@ -33,7 +32,7 @@ const propTypes = {
3332
textareaElementGenerator: PropTypes.func,
3433
minusMenuElement: PropTypes.element,
3534
logger: PropTypes.object.isRequired,
36-
onSubmitValueParser: PropTypes.func,
35+
onSubmitValueParser: PropTypes.func.isRequired,
3736
};
3837
// Default props
3938
const defaultProps = {
@@ -45,7 +44,6 @@ const defaultProps = {
4544
cancelButtonElement: <button>c</button>,
4645
textareaElementGenerator: () => <textarea />,
4746
minusMenuElement: <span> - </span>,
48-
onSubmitValueParser: (isEditMode, keyPath, deep, name, value) => parse(value),
4947
};
5048

5149
/* ************************************* */

src/components/JsonNode.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ const propTypes = {
4242
beforeAddAction: PropTypes.func,
4343
beforeUpdateAction: PropTypes.func,
4444
logger: PropTypes.object.isRequired,
45-
onSubmitValueParser: PropTypes.func,
45+
onSubmitValueParser: PropTypes.func.isRequired,
4646
};
4747
// Default props
4848
const defaultProps = {

src/components/JsonObject.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const propTypes = {
4040
beforeAddAction: PropTypes.func,
4141
beforeUpdateAction: PropTypes.func,
4242
logger: PropTypes.object.isRequired,
43-
onSubmitValueParser: PropTypes.func,
43+
onSubmitValueParser: PropTypes.func.isRequired,
4444
};
4545
// Default props
4646
const defaultProps = {

src/components/JsonValue.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import React, { Component } from 'react';
1010
import PropTypes from 'prop-types';
1111
import { HotKeys } from 'react-hotkeys';
12-
import parse from '../utils/parse';
1312
import { isComponentWillChange } from '../utils/objectTypes';
1413
import inputUsageTypes from '../types/inputUsageTypes';
1514

@@ -33,7 +32,7 @@ const propTypes = {
3332
inputElementGenerator: PropTypes.func,
3433
minusMenuElement: PropTypes.element,
3534
logger: PropTypes.object.isRequired,
36-
onSubmitValueParser: PropTypes.func,
35+
onSubmitValueParser: PropTypes.func.isRequired,
3736
};
3837
// Default props
3938
const defaultProps = {
@@ -44,7 +43,6 @@ const defaultProps = {
4443
cancelButtonElement: <button>c</button>,
4544
inputElementGenerator: () => <input />,
4645
minusMenuElement: <span> - </span>,
47-
onSubmitValueParser: (isEditMode, keyPath, deep, name, value) => parse(value),
4846
};
4947

5048
/* ************************************* */

0 commit comments

Comments
 (0)