Issue #14 (#15) (#16)

- update 'regon' validation rule - support validation 14 digit number

Author: WiktorPacer

src/Rules/REGONRule.php

@@ -23,11 +23,19 @@ class REGONRule implements Rule
      */
     public function passes($attribute, $value)
     {
-        return $this->checkREGON($value);
+        if ($value === null) {
+            return false;
+        }
+
+        return match (strlen($value)) {
+            9       => $this->checkREGON($value),
+            14      => $this->checkLongREGON($value),
+            default => false,
+        };
     }
 
     /**
-     * Check if given REGON number is valid.
+     * Check if given REGON number is valid - 9 digit version.
      *
      * @param null|string $string
      *
@@ -38,25 +46,46 @@ public function passes($attribute, $value)
      */
     private function checkREGON(?string $string): bool
     {
-        if ($string === null) {
-            return false;
+        $arrSteps = [8, 9, 2, 3, 4, 5, 6, 7];
+        $intSum = 0;
+
+        for ($i = 0; $i < 8; $i++) {
+            $intSum += $arrSteps[$i] * $string[$i];
         }
 
-        if (strlen($string) != 9) {
-            return false;
+        $int = $intSum % 11;
+        $intControlNr = ($int == 10) ? 0 : $int;
+
+        if ($intControlNr == $string[8]) {
+            return true;
         }
 
-        $arrSteps = [8, 9, 2, 3, 4, 5, 6, 7];
+        return false;
+    }
+
+    /**
+     * Check if given REGON number is valid - 14 digits version.
+     *
+     * @param null|string $string
+     *
+     * @return bool
+     *
+     * @see http://phpedia.pl/wiki/REGON Souce of this algorithm
+     * @since 2023-05-22
+     */
+    private function checkLongRegon(?string $string): bool
+    {
+        $arrSteps = [2, 4, 8, 5, 0, 9, 7, 3, 6, 1, 2, 4, 8];
         $intSum = 0;
 
-        for ($i = 0; $i < 8; $i++) {
+        for ($i = 0; $i < 13; $i++) {
             $intSum += $arrSteps[$i] * $string[$i];
         }
 
         $int = $intSum % 11;
         $intControlNr = ($int == 10) ? 0 : $int;
 
-        if ($intControlNr == $string[8]) {
+        if ($intControlNr == $string[13]) {
             return true;
         }
 

tests/Unit/REGONRuleTest.php

@@ -35,7 +35,32 @@ public function setUp(): void
      */
     public function testValidREGON()
     {
-        $this->assertEquals(true, $this->rule->passes('regon', '499273139'));
+        $validNumbers = [
+            '734530267',
+            '053955500',
+            '253338390',
+            '947187850',
+            '130433149',
+            '843308426',
+            '386679662',
+            '347116739',
+            '988319794',
+            '303398620',
+            '75147943205580',
+            '25713726382524',
+            '48323221384555',
+            '30936418398037',
+            '63946570931273',
+            '45829482847518',
+            '27025051044606',
+            '94035209178263',
+            '20978490719275',
+            '08942642204556',
+        ];
+
+        foreach ($validNumbers as $number) {
+            $this->assertTrue($this->rule->passes('regon', $number));
+        }
     }
 
     /**
@@ -47,7 +72,10 @@ public function testValidREGON()
      */
     public function testNotValidREGON()
     {
-        $this->assertEquals(false, $this->rule->passes('regon', '499273138'));
+        $this->assertFalse($this->rule->passes('regon', '499273138'));
+        $this->assertFalse($this->rule->passes('regon', '490003138'));
+        $this->assertFalse($this->rule->passes('regon', '574625967547362'));
+        $this->assertFalse($this->rule->passes('regon', '653231231237362'));
     }
 
     /**