Skip to content

Commit 27dc1fa

Browse files
committed
Adoptions after Rebase
Updated everything to github v70 Removed unused test function
1 parent ce4c3d5 commit 27dc1fa

File tree

6 files changed

+6
-46
lines changed

6 files changed

+6
-46
lines changed

policy/approval/approve_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
"testing"
2323
"time"
2424

25-
"github.com/google/go-github/v69/github"
25+
"github.com/google/go-github/v70/github"
2626
"github.com/palantir/policy-bot/policy/common"
2727
"github.com/palantir/policy-bot/policy/predicate"
2828
"github.com/palantir/policy-bot/pull"

policy/predicate/status_check_test.go

Lines changed: 1 addition & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import (
2020
"testing"
2121
"time"
2222

23-
"github.com/google/go-github/v69/github"
23+
"github.com/google/go-github/v70/github"
2424
"github.com/palantir/policy-bot/policy/common"
2525
"github.com/palantir/policy-bot/pull/pulltest"
2626
"github.com/stretchr/testify/assert"
@@ -729,43 +729,3 @@ func TestHasStatusCheck(t *testing.T) {
729729
runStatusCheckTestCase(t, checkAndRepoStatusMixedTestCases)
730730
runStatusCheckTestCase(t, regexTestCases)
731731
}
732-
733-
func TestjoinElementsWithOr(t *testing.T) {
734-
testCases := []struct {
735-
name string
736-
input []string
737-
expected string
738-
}{
739-
{
740-
"empty",
741-
[]string{},
742-
"",
743-
},
744-
{
745-
"single",
746-
[]string{"a"},
747-
"a",
748-
},
749-
{
750-
"two",
751-
[]string{"a", "b"},
752-
"a or b",
753-
},
754-
{
755-
"three",
756-
[]string{"a", "b", "c"},
757-
"a, b, or c",
758-
},
759-
{
760-
"conclusions get sorted",
761-
[]string{"c", "a", "b"},
762-
"a, b, or c",
763-
},
764-
}
765-
766-
for _, tc := range testCases {
767-
t.Run(tc.name, func(t *testing.T) {
768-
assert.Equal(t, tc.expected, joinElementsWithOr(tc.input))
769-
})
770-
}
771-
}

policy/predicate/workflow_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import (
1818
"context"
1919
"testing"
2020

21-
"github.com/google/go-github/v69/github"
21+
"github.com/google/go-github/v70/github"
2222
"github.com/palantir/policy-bot/policy/common"
2323
"github.com/palantir/policy-bot/pull/pulltest"
2424
"github.com/stretchr/testify/assert"

policy/predicate/workflowresult_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import (
1919
"testing"
2020
"time"
2121

22-
"github.com/google/go-github/v69/github"
22+
"github.com/google/go-github/v70/github"
2323
"github.com/palantir/policy-bot/policy/common"
2424
"github.com/palantir/policy-bot/pull/pulltest"
2525
"github.com/stretchr/testify/assert"

pull/context.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ package pull
1717
import (
1818
"time"
1919

20-
"github.com/google/go-github/v69/github"
20+
"github.com/google/go-github/v70/github"
2121
)
2222

2323
// MembershipContext defines methods to get information

pull/pulltest/context.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ package pulltest
1717
import (
1818
"time"
1919

20-
"github.com/google/go-github/v69/github"
20+
"github.com/google/go-github/v70/github"
2121
"github.com/palantir/policy-bot/pull"
2222
)
2323

0 commit comments

Comments
 (0)