feat: #1300 concat Series with dtype #1302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_frame.py
Outdated
| @@ -2523,8 +2523,8 @@ def test_types_regressions() -> None: | |||
| ts1 = pd.concat([s1, s2], axis=0) | |||
| ts2 = pd.concat([s1, s2]) | |||
|
|
|||
| check(assert_type(ts1, pd.Series), pd.Series) | |||
| check(assert_type(ts2, pd.Series), pd.Series) | |||
| check(assert_type(ts1, "pd.Series[int]"), pd.Series, np.int64) | |||
There was a problem hiding this comment.
In general I would recommend using np.integer, np.floating and np.complexfloating in those instances since those types are a little wider and don't rely only on 16/32/64 bits (same in the other places you have modified).
The rest looks good to me.
cmp0xff
added a commit
to cmp0xff/pandas-stubs
that referenced
this pull request
Aug 1, 2025
https://github.com/pandas-dev/pandas-stubs/pull/1302/files#r2248094383 Co-authored-by: Irv Lustig <[email protected]>
Dr-Irv
approved these changes
Aug 1, 2025
|
Thanks @loicdiridollou for the idea and @Dr-Irv for the review 😄 |
Dr-Irv
pushed a commit
that referenced
this pull request
Aug 1, 2025
* feat(series): #1098 arithmetic truediv * fix(typing): __truediv__ * fix(typing): truediv * fix(typing): __rtruediv__ and rtruediv * fix(typing): div and rdiv * fix(comment): ordering #1280 (review) * fix(comment): #1302 (comment) * fix(typing): truediv path * fix(comment): ordering #1280 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking @loicdiridollou's idea from #1300 (comment)
assert_type()to assert the type of any return value