-
-
Notifications
You must be signed in to change notification settings - Fork 152
Type Series
#1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type Series
#1467
Conversation
|
Just a kind reminder: please remove from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is room to improve. Examples:
__getitem__and__setitem__are duplicated. I think we can make@type_check_onlyclasses to deduplicate.pd.Series([1, 2]).iloc[pd.Series([1])]seems to work, soidxin__setitem__can also beSeries, it seems to meIndex | Seriesmay be worthy to combine intoIndexOpsMixin
Overall, the PR does what it should - adding types to Series. I'll give green light. The new ideas can be addressed in a separate PR with new tests. Thank you @MarcoGorelli !
closes #1444
assert_type()to assert the type of any return value