-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Closed
Copy link
Labels
A-engineRelated to the engine implementationRelated to the engine implementationC-debtA clean up/refactor of existing codeA clean up/refactor of existing codeS-needs-benchmarkThis set of changes needs performance benchmarking to double-check that they helpThis set of changes needs performance benchmarking to double-check that they help
Description
Right now max concurrency as a variable is only used for in-flight requests. Previously it was used for both workers and in-flight requests. We should make it clear and remove any decoupling.
What we need to do
- Rename max concurrency as a variable for inflight limit
- Remove max concurrency as a cli arg
- Bench different values of inflight limit
Motivation:
if max_concurrency cli arg removed, which reduced max_concurrency default from 256 to 32 and this reduction could cause perf degredation. Happened due to how we make use of inflight allowance with workers.
Context:
#18872
Metadata
Metadata
Assignees
Labels
A-engineRelated to the engine implementationRelated to the engine implementationC-debtA clean up/refactor of existing codeA clean up/refactor of existing codeS-needs-benchmarkThis set of changes needs performance benchmarking to double-check that they helpThis set of changes needs performance benchmarking to double-check that they help
Type
Projects
Status
Done