Skip to content

Commit 432e188

Browse files
committed
Merge branch 'develop' of github.com:parley-messaging/android-library into develop
2 parents b737f8d + 7a06c84 commit 432e188

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

parley/src/main/java/nu/parley/android/view/compose/ComposeMediaInputView.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
import androidx.annotation.NonNull;
2222
import androidx.annotation.Nullable;
23-
import androidx.appcompat.widget.AppCompatImageView;
23+
import androidx.appcompat.widget.AppCompatImageButton;
2424
import androidx.core.widget.ImageViewCompat;
2525

2626
import java.io.File;
@@ -39,7 +39,7 @@
3939

4040
public final class ComposeMediaInputView extends FrameLayout implements View.OnClickListener {
4141

42-
private AppCompatImageView addMediaView;
42+
private AppCompatImageButton addMediaView;
4343
private ParleyLaunchCallback launchCallback;
4444

4545
private File currentPhotoPath;
@@ -64,7 +64,7 @@ private void init() {
6464

6565
addMediaView = findViewById(R.id.add_media_view);
6666

67-
setOnClickListener(this);
67+
addMediaView.setOnClickListener(this);
6868
}
6969

7070
@Nullable

parley/src/main/res/layout/view_compose.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
android:layout_width="wrap_content"
3535
android:layout_height="wrap_content"
3636
android:layout_gravity="end|bottom"
37-
android:contentDescription="@string/parley_accessibility_photo_button" />
37+
/>
3838
</FrameLayout>
3939

4040
<com.google.android.material.floatingactionbutton.FloatingActionButton

parley/src/main/res/layout/view_compose_media.xml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@
55
android:layout_height="wrap_content"
66
android:layout_gravity="center">
77

8-
<androidx.appcompat.widget.AppCompatImageView
8+
<androidx.appcompat.widget.AppCompatImageButton
99
android:id="@+id/add_media_view"
1010
android:layout_width="wrap_content"
1111
android:layout_height="wrap_content"
12-
android:importantForAccessibility="no"
13-
tools:src="@drawable/parley_ic_add" />
12+
android:background="@null"
13+
android:contentDescription="@string/parley_accessibility_photo_button"
14+
tools:src="@drawable/parley_ic_add"
15+
/>
1416

1517
</FrameLayout>

parley/src/main/res/values-nl/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<!-- Accessibility -->
3232
<string name="parley_accessibility_close">Sluiten</string>
3333
<string name="parley_accessibility_button">Knop</string>
34-
<string name="parley_accessibility_photo_button">Foto. Knop.</string>
34+
<string name="parley_accessibility_photo_button">Foto</string>
3535
<string name="parley_accessibility_send">Versturen</string>
3636
<string name="parley_accessibility_message_informational">Informatief bericht.</string>
3737
<string name="parley_accessibility_message_from_you">Bericht van jou.</string>

parley/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<!-- Accessibility -->
3333
<string name="parley_accessibility_close">Close</string>
3434
<string name="parley_accessibility_button">Button</string>
35-
<string name="parley_accessibility_photo_button">Photo. Button.</string>
35+
<string name="parley_accessibility_photo_button">Photo</string>
3636
<string name="parley_accessibility_send">Send</string>
3737
<string name="parley_accessibility_message_informational">Informational message.</string>
3838
<string name="parley_accessibility_message_from_you">Message from you.</string>

0 commit comments

Comments
 (0)